Test whether created sockets are select()able by sipa · Pull Request #6412 · bitcoin/bitcoin

sipa · 2015-07-09T22:38:21Z

This provides a belt-and-suspends check against file descriptor overflowing, to fix #6411.

luke-jr · 2015-07-09T22:48:00Z

Suggest removing " (file descriptor limit exceeded?)" since this description is inaccurate and likely to confuse someone trying to debug it.

"non-selectable socket created" is completely unhelpful for indicating the reason or helping debug it. So I prefer to explain it a bit at least. Do you have a better suggestion?

I'd say the file descriptor limit exceeded is the part of the message that matters most.

" (socket cannot be included in fdset)" perhaps? The actual fd limit very much has not been exceeded in most situations you'd get this error...

Well OK @luke-jr is right in that this is not "the" file descriptor limit, just the select file descriptor limit. Let's just name the beast as it is:
Cannot create connection: non-selectable socket created (>=FD_SETSIZE)

ajweiss · 2015-07-09T23:26:20Z

select() is also used in netbase, seems it would make sense to check there. Also, if connect() were to return an EINVAL for any reason, that could trigger this in netbase. Have you considered just printing the fd value? For language I'd go simple "invalid file descriptor %ud from netbase on connect".

laanwj · 2015-07-10T04:59:14Z

utACK

luke-jr · 2015-07-10T05:03:43Z

return s != INVALID_SOCKET; ?

Don' think it should double as "is this an error return value"

sipa · 2015-07-10T14:29:49Z

Updated. The test is now done also in netbase (causing simple failure, as netbase does not usually print error messages), and when creating a listen socket.

laanwj · 2015-07-10T14:58:10Z

Needs backport to 0.11 and 0.10 (doesn't seem to involved, I'm willing to do that)

sipa · 2015-07-10T15:03:59Z

See my branches nonselectsocket-0.11 and nonselectsocket-0.10.

laanwj · 2015-07-10T16:00:37Z

strprintf doesn't work without arguments (and is redundant)

sipa · 2015-07-10T16:18:46Z

@laanwj Done.

laanwj · 2015-07-13T11:54:47Z

This brings up a warning, as SOCKET is defined as unsigned int:

compat.h: In function ‘bool IsSelectableSocket(SOCKET)’:
compat.h:99:18: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     return (s >= 0 && s < FD_SETSIZE);

laanwj · 2015-07-17T20:01:35Z

@sipa are you planning to fix the warning or should we not hold this up on that?

d422f9b Test whether created sockets are select()able (Pieter Wuille)

SOCKET are defined as unsigned integers, thus always >=0.

SOCKET are defined as unsigned integers, thus always >=0. Rebased-From: 89289d8

laanwj · 2015-07-20T15:24:29Z

Backported to 0.11 as e8b87c8
Warning fixed in 89289d8 (e8b87c8 in 0.11)

To 0.10 as 0739e6e ae52a7f

Conflicts: src/net.cpp Github-Pull: #6412 Rebased-From: d422f9b

SOCKET are defined as unsigned integers, thus always >=0. Rebased-From: 89289d8

ae52a7f Fix warning introduced by bitcoin#6412 (Wladimir J. van der Laan) 0739e6e Test whether created sockets are select()able (Pieter Wuille) 255eced Updated URL location of netinstall for Debian (฿tcDrak) 7e66e9c openssl: avoid config file load/race (Cory Fields) 3f55638 doc: update mailing list address (Wladimir J. van der Laan) be64204 Add option `-alerts` to opt out of alert system (Wladimir J. van der Laan) 0fd8464 Fix getbalance * (Tom Harding) 09334e0 configure: Detect (and reject) LibreSSL (Luke Dashjr) 181771b json: fail read_string if string contains trailing garbage (Wladimir J. van der Laan) ecc96f5 Remove P2SH coinbase flag, no longer interesting (Luke Dashjr) ebd7d8d Parameter interaction: disable upnp if -proxy set (Wladimir J. van der Laan) ae3d8f3 Fix two problems in CSubNet parsing (Wladimir J. van der Laan) e4a7d51 Simplify code for CSubnet (Wladimir J. van der Laan) Conflicts: README.md

Conflicts: src/net.cpp Github-Pull: bitcoin#6412 Rebased-From: d422f9b (cherry picked from commit 0739e6e)

SOCKET are defined as unsigned integers, thus always >=0. Rebased-From: 89289d8 (cherry picked from commit ae52a7f)

luke-jr reviewed Jul 9, 2015
View reviewed changes

luke-jr reviewed Jul 10, 2015
View reviewed changes

sipa force-pushed the nonselectsocket branch 2 times, most recently from b40d7b6 to a29e66c Compare July 10, 2015 14:29

sipa force-pushed the nonselectsocket branch 2 times, most recently from 1cf0d45 to 68c0819 Compare July 10, 2015 14:31

laanwj reviewed Jul 10, 2015
View reviewed changes

Comment thread src/net.cpp Outdated

laanwj Jul 10, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strprintf doesn't work without arguments (and is redundant)

Test whether created sockets are select()able

d422f9b

sipa force-pushed the nonselectsocket branch from 68c0819 to d422f9b Compare July 10, 2015 16:05

sipa mentioned this pull request Jul 10, 2015

connection limit calculation for select() is overly ambitious with -txindex #6411

Closed

laanwj added the Bug label Jul 11, 2015

jonasschnelli mentioned this pull request Jul 13, 2015

bitcoind crashes when RPC server encounters an error #6427

Closed

laanwj merged commit d422f9b into bitcoin:master Jul 20, 2015

laanwj added a commit that referenced this pull request Jul 20, 2015

Merge pull request #6412

1a2de32

d422f9b Test whether created sockets are select()able (Pieter Wuille)

laanwj added a commit that referenced this pull request Jul 20, 2015

Fix warning introduced by #6412

89289d8

SOCKET are defined as unsigned integers, thus always >=0.

laanwj added a commit that referenced this pull request Jul 20, 2015

Fix warning introduced by #6412

e8b87c8

SOCKET are defined as unsigned integers, thus always >=0. Rebased-From: 89289d8

sipa added a commit that referenced this pull request Jul 20, 2015

Test whether created sockets are select()able

0739e6e

Conflicts: src/net.cpp Github-Pull: #6412 Rebased-From: d422f9b

laanwj added a commit that referenced this pull request Jul 20, 2015

Fix warning introduced by #6412

ae52a7f

SOCKET are defined as unsigned integers, thus always >=0. Rebased-From: 89289d8

dgenr8 mentioned this pull request May 18, 2017

Networking improvements bitcoinxt/bitcoinxt#203

Merged

reddink pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request May 27, 2020

Test whether created sockets are select()able

72d3187

Conflicts: src/net.cpp Github-Pull: bitcoin#6412 Rebased-From: d422f9b (cherry picked from commit 0739e6e)

reddink pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request May 27, 2020

Fix warning introduced by bitcoin#6412

083d866

SOCKET are defined as unsigned integers, thus always >=0. Rebased-From: 89289d8 (cherry picked from commit ae52a7f)

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Conversation

sipa commented Jul 9, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajweiss commented Jul 9, 2015

Uh oh!

laanwj commented Jul 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sipa commented Jul 10, 2015

Uh oh!

laanwj commented Jul 10, 2015

Uh oh!

sipa commented Jul 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sipa commented Jul 10, 2015

Uh oh!

laanwj commented Jul 13, 2015

Uh oh!

laanwj commented Jul 17, 2015

Uh oh!

laanwj commented Jul 20, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants