Fix intermittent test failure, reduce test time #6414

Merged
merged 1 commit into from Jul 10, 2015

Conversation

Projects
None yet
2 participants
@dgenr8
Contributor

dgenr8 commented Jul 10, 2015

In txn_clone.py, non-essential test transaction tx2 was asserted to be unconfirmed, but would occasionally confirm depending on network behavior. Fix by explicitly sharing with miner and checking for 1 confirmation.

Reduce required conflict tests from 4 to 2, by moving one invocation each of txn_clone.py and txn_doublespend.py to the extended test section. This saves about 15 seconds per test run for me.

Fix intermittent test failure, reduce test time
In txn_clone.py, non-essential test transaction tx2 was asserted
to be unconfirmed, but would occasionally confirm depending on
network behavior.  Fix by explicitly sharing with miner and
checking for 1 confirmation.

Reduce required conflict tests from 4 to 2, by moving one invocation
each of txn_clone.py and txn_doublespend.py to the extented test
section.  This saves about 15 seconds per test run for me.

@laanwj laanwj added the Tests label Jul 10, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 10, 2015

Member

utACK

Member

laanwj commented Jul 10, 2015

utACK

@laanwj laanwj merged commit 8a0b933 into bitcoin:master Jul 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 10, 2015

Merge pull request #6414
8a0b933 Fix intermittent test failure, reduce test time (Tom Harding)

@str4d str4d referenced this pull request in zcash/zcash Feb 15, 2017

Merged

Bitcoin 0.12 test PRs 1 #2101

zkbot added a commit to zcash/zcash that referenced this pull request Feb 15, 2017

zkbot added a commit to zcash/zcash that referenced this pull request Feb 20, 2017

@dagurval dagurval referenced this pull request in bitcoinxt/bitcoinxt Jul 3, 2017

Merged

Fix intermittent test failure, reduce test time #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment