Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] fix possible reorg issue in (fund)rawtransaction(s).py RPC test #6417

Merged
merged 2 commits into from Jul 13, 2015

Conversation

@jonasschnelli
Copy link
Member

jonasschnelli commented Jul 10, 2015

  • added missing mempool sync between blocks generating

Also removed checks of expected inputs because the coin selection is not exact foreseeable.

Fixes #6391.
Thanks @sdaftuar and @morcos for analyzing this issue!

….py RPC test

- added missing mempool sync between block generations
@jonasschnelli jonasschnelli force-pushed the jonasschnelli:2015/07/qa_fix_missing_sync branch to 6ed38b0 Jul 10, 2015
@jonasschnelli jonasschnelli changed the title [QA] fix possible reorg issue in rawtransaction.py RPC test [QA] fix possible reorg issue in (fund)rawtransaction(s).py RPC test Jul 10, 2015
@sdaftuar

This comment has been minimized.

Copy link

sdaftuar commented on qa/rpc-tests/fundrawtransaction.py in 6ed38b0 Jul 10, 2015

nit: enought -> enough (and again at line 66)

This comment has been minimized.

Copy link
Owner Author

jonasschnelli replied Jul 10, 2015

forcefixed. Thanks.

rawtransactions.py is already in the standard test list
@jonasschnelli jonasschnelli force-pushed the jonasschnelli:2015/07/qa_fix_missing_sync branch to 9da8fc8 Jul 10, 2015
@sdaftuar
Copy link
Member

sdaftuar commented Jul 10, 2015

ACK, thanks for fixing!

@laanwj laanwj added the Tests label Jul 13, 2015
@laanwj laanwj merged commit 9da8fc8 into bitcoin:master Jul 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jul 13, 2015
9da8fc8 [QA] remove rawtransactions.py from the extended test list (Jonas Schnelli)
6ed38b0 [QA] fix possible reorg issue in rawtransaction.py/fundrawtransaction.py RPC test (Jonas Schnelli)
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 9, 2016
…ansaction.py RPC test

- added missing mempool sync between block generations

Github-Pull: bitcoin#6417
Partial-Rebased-From: 6ed38b0
@str4d str4d mentioned this pull request Feb 15, 2017
@dagurval dagurval mentioned this pull request Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.