[QA] fix possible reorg issue in (fund)rawtransaction(s).py RPC test #6417

Merged
merged 2 commits into from Jul 13, 2015

Conversation

Projects
None yet
3 participants
@jonasschnelli
Member

jonasschnelli commented Jul 10, 2015

  • added missing mempool sync between blocks generating

Also removed checks of expected inputs because the coin selection is not exact foreseeable.

Fixes #6391.
Thanks @sdaftuar and @morcos for analyzing this issue!

[QA] fix possible reorg issue in rawtransaction.py/fundrawtransaction…
….py RPC test

- added missing mempool sync between block generations

@jonasschnelli jonasschnelli changed the title from [QA] fix possible reorg issue in rawtransaction.py RPC test to [QA] fix possible reorg issue in (fund)rawtransaction(s).py RPC test Jul 10, 2015

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Jul 10, 2015

nit: enought -> enough (and again at line 66)

nit: enought -> enough (and again at line 66)

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 10, 2015

Owner

forcefixed. Thanks.

Owner

jonasschnelli replied Jul 10, 2015

forcefixed. Thanks.

[QA] remove rawtransactions.py from the extended test list
rawtransactions.py is already in the standard test list
@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Jul 10, 2015

Member

ACK, thanks for fixing!

Member

sdaftuar commented Jul 10, 2015

ACK, thanks for fixing!

@laanwj laanwj added the Tests label Jul 13, 2015

@laanwj laanwj merged commit 9da8fc8 into bitcoin:master Jul 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 13, 2015

Merge pull request #6417
9da8fc8 [QA] remove rawtransactions.py from the extended test list (Jonas Schnelli)
6ed38b0 [QA] fix possible reorg issue in rawtransaction.py/fundrawtransaction.py RPC test (Jonas Schnelli)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 9, 2016

Partial: [QA] fix possible reorg issue in rawtransaction.py/fundrawtr…
…ansaction.py RPC test

- added missing mempool sync between block generations

Github-Pull: #6417
Partial-Rebased-From: 6ed38b0

@str4d str4d referenced this pull request in zcash/zcash Feb 15, 2017

Merged

Bitcoin 0.12 RPC PRs 1 #2100

@dagurval dagurval referenced this pull request in bitcoinxt/bitcoinxt Dec 27, 2017

Merged

Add fundrawtransaction #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment