Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[QA] fix possible reorg issue in (fund)rawtransaction(s).py RPC test #6417
Conversation
….py RPC test - added missing mempool sync between block generations
jonasschnelli
force-pushed the
jonasschnelli:2015/07/qa_fix_missing_sync
branch
to
6ed38b0
jonasschnelli
changed the title
This comment has been minimized.
This comment has been minimized.
sdaftuar
commented on qa/rpc-tests/fundrawtransaction.py in 6ed38b0
Jul 10, 2015
|
nit: enought -> enough (and again at line 66) |
This comment has been minimized.
This comment has been minimized.
|
forcefixed. Thanks. |
rawtransactions.py is already in the standard test list
jonasschnelli
force-pushed the
jonasschnelli:2015/07/qa_fix_missing_sync
branch
to
9da8fc8
|
ACK, thanks for fixing! |
laanwj
added a commit
that referenced
this pull request
Jul 13, 2015
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 9, 2016
…ansaction.py RPC test - added missing mempool sync between block generations Github-Pull: bitcoin#6417 Partial-Rebased-From: 6ed38b0
Merged
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 15, 2017
Bitcoin 0.12 RPC PRs 1 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6266 - bitcoin/bitcoin#6257 - bitcoin/bitcoin#6271 - bitcoin/bitcoin#6158 - bitcoin/bitcoin#6307 - bitcoin/bitcoin#6290 - bitcoin/bitcoin#6262 - bitcoin/bitcoin#6088 - bitcoin/bitcoin#6339 - bitcoin/bitcoin#6299 (partial, remainder in #2099) - bitcoin/bitcoin#6350 - bitcoin/bitcoin#6247 - bitcoin/bitcoin#6362 - bitcoin/bitcoin#5486 - bitcoin/bitcoin#6417 - bitcoin/bitcoin#6398 (partial, remainder was included in #1950) - bitcoin/bitcoin#6444 - bitcoin/bitcoin#6456 (partial, remainder was included in #2082) - bitcoin/bitcoin#6380 Part of #2074.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 4, 2017
Bitcoin 0.12 RPC PRs 1 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6266 - bitcoin/bitcoin#6257 - bitcoin/bitcoin#6271 - bitcoin/bitcoin#6158 - bitcoin/bitcoin#6307 - bitcoin/bitcoin#6290 - bitcoin/bitcoin#6262 - bitcoin/bitcoin#6088 - bitcoin/bitcoin#6339 - bitcoin/bitcoin#6299 (partial, remainder in #2099) - bitcoin/bitcoin#6350 - bitcoin/bitcoin#6247 - bitcoin/bitcoin#6362 - bitcoin/bitcoin#5486 - bitcoin/bitcoin#6417 - bitcoin/bitcoin#6398 (partial, remainder was included in #1950) - bitcoin/bitcoin#6444 - bitcoin/bitcoin#6456 (partial, remainder was included in #2082) - bitcoin/bitcoin#6380 - bitcoin/bitcoin#6970 Part of #2074.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jonasschnelli commentedJul 10, 2015
Also removed checks of expected inputs because the coin selection is not exact foreseeable.
Fixes #6391.
Thanks @sdaftuar and @morcos for analyzing this issue!