Skip to content

Add autogen.sh to source tarball.#6418

Merged
laanwj merged 1 commit into
bitcoin:masterfrom
randy-waterhouse:master
Jul 14, 2015
Merged

Add autogen.sh to source tarball.#6418
laanwj merged 1 commit into
bitcoin:masterfrom
randy-waterhouse:master

Conversation

@randy-waterhouse

Copy link
Copy Markdown
Contributor

Closes issue #4997 and restores consistency with the "To Build" instructions in doc/build-unix.md file packaged with the source tarball.

@jgarzik

jgarzik commented Jul 11, 2015

Copy link
Copy Markdown
Contributor

Concept ACK - though why not use EXTRA_DIST?

@randy-waterhouse

Copy link
Copy Markdown
Contributor Author

We use the noinst because this script is packaged with the src only for building/dev but not to be installed in system directories as are execution/docs/helper script, etc files. tl;dr it gets ignored by the "make install" step but is packaged with src for building/dev.

@jgarzik

jgarzik commented Jul 11, 2015

Copy link
Copy Markdown
Contributor

@randy-waterhouse EXTRA_DIST files are not installed with "make install"

@randy-waterhouse

Copy link
Copy Markdown
Contributor Author

@jgarzik oh yes right,dist_noinst_SCRIPTS preserves attributes as they are in the source, and treats it correctly as if it is a source script file with autotool rules that apply to SCRIPTS (that should not be installed) http://www.gnu.org/software/automake/manual/html_node/Scripts.html#Scripts EXTRA_DIST is for files that cannot be handled by regular dist variables and is a generic call that just dists files/directories of all types. As a design philosophy I think executable scripts should be placed clearly up front and treated as an executable script by the build system, with all that implies.

@laanwj

laanwj commented Jul 11, 2015

Copy link
Copy Markdown
Member

utACK

@theuni

theuni commented Jul 13, 2015

Copy link
Copy Markdown
Member

ut ACK

@laanwj laanwj merged commit 60d5432 into bitcoin:master Jul 14, 2015
laanwj added a commit that referenced this pull request Jul 14, 2015
60d5432 Add autogen.sh to source tarball. (randy-waterhouse)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants