Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autogen.sh to source tarball. #6418

Merged
merged 1 commit into from Jul 14, 2015
Merged

Conversation

@randy-waterhouse
Copy link
Contributor

randy-waterhouse commented Jul 11, 2015

Closes issue #4997 and restores consistency with the "To Build" instructions in doc/build-unix.md file packaged with the source tarball.

@jgarzik
Copy link
Contributor

jgarzik commented Jul 11, 2015

Concept ACK - though why not use EXTRA_DIST?

@randy-waterhouse
Copy link
Contributor Author

randy-waterhouse commented Jul 11, 2015

We use the noinst because this script is packaged with the src only for building/dev but not to be installed in system directories as are execution/docs/helper script, etc files. tl;dr it gets ignored by the "make install" step but is packaged with src for building/dev.

@jgarzik
Copy link
Contributor

jgarzik commented Jul 11, 2015

@randy-waterhouse EXTRA_DIST files are not installed with "make install"

@randy-waterhouse
Copy link
Contributor Author

randy-waterhouse commented Jul 11, 2015

@jgarzik oh yes right,dist_noinst_SCRIPTS preserves attributes as they are in the source, and treats it correctly as if it is a source script file with autotool rules that apply to SCRIPTS (that should not be installed) http://www.gnu.org/software/automake/manual/html_node/Scripts.html#Scripts EXTRA_DIST is for files that cannot be handled by regular dist variables and is a generic call that just dists files/directories of all types. As a design philosophy I think executable scripts should be placed clearly up front and treated as an executable script by the build system, with all that implies.

@laanwj
Copy link
Member

laanwj commented Jul 11, 2015

utACK

@laanwj laanwj added the Build system label Jul 11, 2015
@theuni
Copy link
Member

theuni commented Jul 13, 2015

ut ACK

@laanwj laanwj merged commit 60d5432 into bitcoin:master Jul 14, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jul 14, 2015
60d5432 Add autogen.sh to source tarball. (randy-waterhouse)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.