Add autogen.sh to source tarball. #6418

Merged
merged 1 commit into from Jul 14, 2015

Conversation

Projects
None yet
4 participants
@randy-waterhouse
Contributor

randy-waterhouse commented Jul 11, 2015

Closes issue #4997 and restores consistency with the "To Build" instructions in doc/build-unix.md file packaged with the source tarball.

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Jul 11, 2015

Contributor

Concept ACK - though why not use EXTRA_DIST?

Contributor

jgarzik commented Jul 11, 2015

Concept ACK - though why not use EXTRA_DIST?

@randy-waterhouse

This comment has been minimized.

Show comment
Hide comment
@randy-waterhouse

randy-waterhouse Jul 11, 2015

Contributor

We use the noinst because this script is packaged with the src only for building/dev but not to be installed in system directories as are execution/docs/helper script, etc files. tl;dr it gets ignored by the "make install" step but is packaged with src for building/dev.

Contributor

randy-waterhouse commented Jul 11, 2015

We use the noinst because this script is packaged with the src only for building/dev but not to be installed in system directories as are execution/docs/helper script, etc files. tl;dr it gets ignored by the "make install" step but is packaged with src for building/dev.

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Jul 11, 2015

Contributor

@randy-waterhouse EXTRA_DIST files are not installed with "make install"

Contributor

jgarzik commented Jul 11, 2015

@randy-waterhouse EXTRA_DIST files are not installed with "make install"

@randy-waterhouse

This comment has been minimized.

Show comment
Hide comment
@randy-waterhouse

randy-waterhouse Jul 11, 2015

Contributor

@jgarzik oh yes right,dist_noinst_SCRIPTS preserves attributes as they are in the source, and treats it correctly as if it is a source script file with autotool rules that apply to SCRIPTS (that should not be installed) http://www.gnu.org/software/automake/manual/html_node/Scripts.html#Scripts EXTRA_DIST is for files that cannot be handled by regular dist variables and is a generic call that just dists files/directories of all types. As a design philosophy I think executable scripts should be placed clearly up front and treated as an executable script by the build system, with all that implies.

Contributor

randy-waterhouse commented Jul 11, 2015

@jgarzik oh yes right,dist_noinst_SCRIPTS preserves attributes as they are in the source, and treats it correctly as if it is a source script file with autotool rules that apply to SCRIPTS (that should not be installed) http://www.gnu.org/software/automake/manual/html_node/Scripts.html#Scripts EXTRA_DIST is for files that cannot be handled by regular dist variables and is a generic call that just dists files/directories of all types. As a design philosophy I think executable scripts should be placed clearly up front and treated as an executable script by the build system, with all that implies.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 11, 2015

Member

utACK

Member

laanwj commented Jul 11, 2015

utACK

@laanwj laanwj added the Build system label Jul 11, 2015

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jul 13, 2015

Member

ut ACK

Member

theuni commented Jul 13, 2015

ut ACK

@laanwj laanwj merged commit 60d5432 into bitcoin:master Jul 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 14, 2015

Merge pull request #6418
60d5432 Add autogen.sh to source tarball. (randy-waterhouse)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment