doc: add documentation for shared library libbitcoinconsensus #6430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks! |
|
Nice. Thanks. |
|
Looks great, thanks. One nit though: Please specify that bitcoinconsensus_ERR_OK only means that the inputs were sane and that verification was attempted, it does not mean that verification succeeded. |
|
ACK |
|
Could you add another Example Implementations for NBitcoin? It is a library for .NET that implements the consensus library too. https://github.com/NicolasDorier/NBitcoin/blob/master/NBitcoin/Script.cs#L814 |
|
ACK |
laanwj
added a commit
that referenced
this pull request
Jul 17, 2015
fanquake
added a commit
that referenced
this pull request
Dec 7, 2020
…fix NBitcoin link cb0b712 doc: libbitcoinconsensus: add missing error code description, fix NBitcoin link (Sebastian Falbesoner) Pull request description: This PR improves the libbitcoinconsensus description in `shared-libraries.md` in two ways: * adds the missing error code description for `bitcoinconsensus_ERR_INVALID_FLAGS` (introduced by commit 5ca8ef2, PR #8976) * updates and fixes the link to the NBitcoin implementation (introduced by commit 3361edd, PR #6430) * the owner of the `NBitcoin` github repository changed from `NicolasDorier` to `MetacoSA` (redirection still worked though) * instead of dynamically referring to a file in master with a fixed line number (which is obviously always quickly outdated), use a permalink with a file numbers area ACKs for top commit: MarcoFalke: cr ACK cb0b712 harding: Code (documentation) review ACK cb0b712. Text is clear and seems accurate, and the link checks out. Tree-SHA512: 9840458db6fb40e71c9852104aefcec5abbaf5054c6123701181dd477cea8c81d3647f376b67692159adf577c9b6305b05b784728bf9f14a753fab5898075a4e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5311