Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add documentation for shared library libbitcoinconsensus #6430

Merged
merged 3 commits into from Jul 17, 2015

Conversation

@braydonf
Copy link

braydonf commented Jul 13, 2015

Related Issue: #5311

@laanwj laanwj added the Docs label Jul 14, 2015
@laanwj
Copy link
Member

laanwj commented Jul 14, 2015

Looks good to me, thanks!

@jonasschnelli
Copy link
Member

jonasschnelli commented Jul 14, 2015

Nice. Thanks.
ACK.
I also like name shared-libraries.md which implies that more things should be available as library.

@theuni
Copy link
Member

theuni commented Jul 14, 2015

Looks great, thanks. One nit though: Please specify that bitcoinconsensus_ERR_OK only means that the inputs were sane and that verification was attempted, it does not mean that verification succeeded.

@fanquake
Copy link
Member

fanquake commented Jul 15, 2015

ACK

@lontivero
Copy link

lontivero commented Jul 15, 2015

Could you add another Example Implementations for NBitcoin? It is a library for .NET that implements the consensus library too.

https://github.com/NicolasDorier/NBitcoin/blob/master/NBitcoin/Script.cs#L814

@paveljanik
Copy link
Contributor

paveljanik commented Jul 15, 2015

ACK

@laanwj laanwj merged commit 3361edd into bitcoin:master Jul 17, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jul 17, 2015
3361edd doc: Add NBitcoin to bitcoinconsensus examples (Braydon Fuller)
b1bac4e Add description for bitcoinconsensus_ERR_OK (Braydon Fuller)
c156ada doc: add documentation for shared library libbitcoinconsensus (Braydon Fuller)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.