doc: add documentation for shared library libbitcoinconsensus #6430

Merged
merged 3 commits into from Jul 17, 2015

Conversation

Projects
None yet
7 participants
@braydonf

Related Issue: #5311

@laanwj laanwj added the Docs label Jul 14, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 14, 2015

Member

Looks good to me, thanks!

Member

laanwj commented Jul 14, 2015

Looks good to me, thanks!

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 14, 2015

Member

Nice. Thanks.
ACK.
I also like name shared-libraries.md which implies that more things should be available as library.

Member

jonasschnelli commented Jul 14, 2015

Nice. Thanks.
ACK.
I also like name shared-libraries.md which implies that more things should be available as library.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jul 14, 2015

Member

Looks great, thanks. One nit though: Please specify that bitcoinconsensus_ERR_OK only means that the inputs were sane and that verification was attempted, it does not mean that verification succeeded.

Member

theuni commented Jul 14, 2015

Looks great, thanks. One nit though: Please specify that bitcoinconsensus_ERR_OK only means that the inputs were sane and that verification was attempted, it does not mean that verification succeeded.

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jul 15, 2015

Member

ACK

Member

fanquake commented Jul 15, 2015

ACK

@lontivero

This comment has been minimized.

Show comment
Hide comment
@lontivero

lontivero Jul 15, 2015

Could you add another Example Implementations for NBitcoin? It is a library for .NET that implements the consensus library too.

https://github.com/NicolasDorier/NBitcoin/blob/master/NBitcoin/Script.cs#L814

Could you add another Example Implementations for NBitcoin? It is a library for .NET that implements the consensus library too.

https://github.com/NicolasDorier/NBitcoin/blob/master/NBitcoin/Script.cs#L814

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jul 15, 2015

Contributor

ACK

Contributor

paveljanik commented Jul 15, 2015

ACK

@laanwj laanwj merged commit 3361edd into bitcoin:master Jul 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 17, 2015

Merge pull request #6430
3361edd doc: Add NBitcoin to bitcoinconsensus examples (Braydon Fuller)
b1bac4e Add description for bitcoinconsensus_ERR_OK (Braydon Fuller)
c156ada doc: add documentation for shared library libbitcoinconsensus (Braydon Fuller)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment