Exempt unspendable transaction outputs from dust checks #6444

Merged
merged 1 commit into from Jul 21, 2015

Conversation

Projects
None yet
8 participants
@dexX7
Contributor

dexX7 commented Jul 15, 2015

Since unspendable outputs can't be spent, there is no threshold at which it would be uneconomic to spend them.

This primarily targets transaction outputs with OP_RETURN, and allows funding of data-only transactions with "fundrawtransaction".

@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd Jul 17, 2015

Contributor

utACK

Pretty obvious fix, regardless of what we do with the IsDust() code in the future re: refactoring.

Contributor

petertodd commented Jul 17, 2015

utACK

Pretty obvious fix, regardless of what we do with the IsDust() code in the future re: refactoring.

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Jul 17, 2015

Contributor

ACK

Contributor

jgarzik commented Jul 17, 2015

ACK

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jul 17, 2015

Member

Seems reasonable.

Member

sipa commented Jul 17, 2015

Seems reasonable.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jul 18, 2015

Contributor

ACK
minor nit: one line if, please remove { and }

Contributor

paveljanik commented Jul 18, 2015

ACK
minor nit: one line if, please remove { and }

Exempt unspendable transaction outputs from dust checks
Since unspendable outputs can't be spent, there is no threshold at which it would be uneconomic to spend them.

This primarily targets transaction outputs with `OP_RETURN`.

---

Initially based on:

commit 9cf0ae26350033d43d5dd3c95054c0d1b1641eda
Author: zathras-crypto <zathrasc@gmail.com>
Date:   Wed Mar 25 02:04:02 2015 -0700

Changes:

- cherry-picked on top of bitcoin:master
- added RPC test for fundrawtransaction
@dexX7

This comment has been minimized.

Show comment
Hide comment
@dexX7

dexX7 Jul 18, 2015

Contributor

@paveljanik: sure, updated.

Contributor

dexX7 commented Jul 18, 2015

@paveljanik: sure, updated.

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Jul 18, 2015

Member

ACK

Member

btcdrak commented Jul 18, 2015

ACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 21, 2015

Member

utACK

minor nit: one line if, please remove { and }

We don't actually have a coding style rule that says that.

Member

laanwj commented Jul 21, 2015

utACK

minor nit: one line if, please remove { and }

We don't actually have a coding style rule that says that.

@laanwj laanwj merged commit 0aad1f1 into bitcoin:master Jul 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 21, 2015

Merge pull request #6444
0aad1f1 Exempt unspendable transaction outputs from dust checks (zathras-crypto)

@str4d str4d referenced this pull request in zcash/zcash Feb 15, 2017

Merged

Bitcoin 0.12 RPC PRs 1 #2100

@daira daira referenced this pull request in zcash/zcash Feb 26, 2017

Open

No dust #2133

@dagurval dagurval referenced this pull request in bitcoinxt/bitcoinxt Dec 27, 2017

Merged

Add fundrawtransaction #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment