Separate core memory usage computation in core_memusage.h #6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return memusage::DynamicUsage(locator.vHave); | ||
| } | ||
|
|
||
| #endif // BITCOIN_PRIMITIVES_TRANSACTION_H |
|
utACK, looks like the good solution to me |
laanwj
added a commit
that referenced
this pull request
Jul 20, 2015
9e38d0f Separate core memory usage computation in core_memusage.h (Pieter Wuille)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 23, 2017
Bitcoin 0.12 mempool memory usage PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6410 - bitcoin/bitcoin#6453 - bitcoin/bitcoin#6013 (excludes changes to docs we deleted) Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Remove support for computing recursive memory usage from memusage.h, making it more easy to plug in other functions.
Furthermore, move the computation of memory usage of core data structures from primitives/*, to reduce its dependencies, specifically on boost.
Should fix #6441.