Include pruned state in chaininfo.json #6457

Merged
merged 2 commits into from Jul 20, 2015

Conversation

Projects
None yet
4 participants
@sime
Contributor

sime commented Jul 18, 2015

No description provided.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jul 19, 2015

Contributor

When you are at it, can you please document "softforks" (from #6353) in the doc/REST-interface.md file?

Please also add "pruned" and "pruneheight" into helptext here https://github.com/bitcoin/bitcoin/blob/master/src/rpcblockchain.cpp#L597 to make it complete.

Contributor

paveljanik commented Jul 19, 2015

When you are at it, can you please document "softforks" (from #6353) in the doc/REST-interface.md file?

Please also add "pruned" and "pruneheight" into helptext here https://github.com/bitcoin/bitcoin/blob/master/src/rpcblockchain.cpp#L597 to make it complete.

@sime

This comment has been minimized.

Show comment
Hide comment
@sime

sime Jul 19, 2015

Contributor

@paveljanik I've included the extra documentation. should doc/REST-interface.md go into the array contents of softforks? As I have only include the upper most level.

Contributor

sime commented Jul 19, 2015

@paveljanik I've included the extra documentation. should doc/REST-interface.md go into the array contents of softforks? As I have only include the upper most level.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
Member

jonasschnelli commented Jul 20, 2015

ACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 20, 2015

Member

LGTM, ACK

Member

laanwj commented Jul 20, 2015

LGTM, ACK

@laanwj laanwj merged commit 0ef9858 into bitcoin:master Jul 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 20, 2015

Merge pull request #6457
0ef9858 Documenting pruned, pruneheight and softforks in getblockchaininfo (Simon Males)
0c89579 Include pruned state in chaininfo.json (Simon Males)

@laanwj laanwj added the Docs label Jul 20, 2015

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 28, 2015

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment