Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: use CHashWriter also in SignVerifyMessageDialog #6484

Merged
merged 1 commit into from Jul 28, 2015
Merged

qt: use CHashWriter also in SignVerifyMessageDialog #6484

merged 1 commit into from Jul 28, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2015

This eliminates unnecessary copying of data being hashed.

@laanwj laanwj added the GUI label Jul 28, 2015
@laanwj
Copy link
Member

laanwj commented Jul 28, 2015

It doesn't shave off much code, but looks like a better fit, yes. utACK

@laanwj
Copy link
Member

laanwj commented Jul 28, 2015

Having some more explanation in the commit message would be nice though!

@sipa
Copy link
Member

sipa commented Jul 28, 2015

This eliminates unnecessary copying of data being hashed.
@ghost
Copy link
Author

ghost commented Jul 28, 2015

Added an explanation.

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jul 28, 2015

utACK.

@laanwj laanwj merged commit 5e56ef5 into bitcoin:master Jul 28, 2015
1 check passed
laanwj added a commit that referenced this issue Jul 28, 2015
5e56ef5 qt: use CHashWriter also in SignVerifyMessageDialog (Pavel Vasin)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants