Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: use CHashWriter also in SignVerifyMessageDialog #6484

Merged
merged 1 commit into from Jul 28, 2015
Merged

Conversation

@x-rat4-x
Copy link
Contributor

x-rat4-x commented Jul 28, 2015

This eliminates unnecessary copying of data being hashed.

@laanwj laanwj added the GUI label Jul 28, 2015
@laanwj
Copy link
Member

laanwj commented Jul 28, 2015

It doesn't shave off much code, but looks like a better fit, yes. utACK

@laanwj
Copy link
Member

laanwj commented Jul 28, 2015

Having some more explanation in the commit message would be nice though!

@sipa
Copy link
Member

sipa commented Jul 28, 2015

This eliminates unnecessary copying of data being hashed.
@x-rat4-x x-rat4-x force-pushed the x-rat4-x:patch branch to 5e56ef5 Jul 28, 2015
@x-rat4-x
Copy link
Contributor Author

x-rat4-x commented Jul 28, 2015

Added an explanation.

@jonasschnelli
Copy link
Member

jonasschnelli commented Jul 28, 2015

utACK.

@laanwj laanwj merged commit 5e56ef5 into bitcoin:master Jul 28, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jul 28, 2015
5e56ef5 qt: use CHashWriter also in SignVerifyMessageDialog (Pavel Vasin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.