qt: use CHashWriter also in SignVerifyMessageDialog #6484

Merged
merged 1 commit into from Jul 28, 2015

Conversation

Projects
None yet
4 participants
@JohnDolittle
Contributor

JohnDolittle commented Jul 28, 2015

This eliminates unnecessary copying of data being hashed.

@laanwj laanwj added the GUI label Jul 28, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 28, 2015

Member

It doesn't shave off much code, but looks like a better fit, yes. utACK

Member

laanwj commented Jul 28, 2015

It doesn't shave off much code, but looks like a better fit, yes. utACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 28, 2015

Member

Having some more explanation in the commit message would be nice though!

Member

laanwj commented Jul 28, 2015

Having some more explanation in the commit message would be nice though!

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jul 28, 2015

Member
Member

sipa commented Jul 28, 2015

qt: use CHashWriter also in SignVerifyMessageDialog
This eliminates unnecessary copying of data being hashed.
@JohnDolittle

This comment has been minimized.

Show comment
Hide comment
@JohnDolittle

JohnDolittle Jul 28, 2015

Contributor

Added an explanation.

Contributor

JohnDolittle commented Jul 28, 2015

Added an explanation.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 28, 2015

Member

utACK.

Member

jonasschnelli commented Jul 28, 2015

utACK.

@laanwj laanwj merged commit 5e56ef5 into bitcoin:master Jul 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 28, 2015

Merge pull request #6484
5e56ef5 qt: use CHashWriter also in SignVerifyMessageDialog (Pavel Vasin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment