Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking file descriptors in RegisterLoad #6488

Merged
merged 1 commit into from Jul 29, 2015
Merged

Conversation

@casey
Copy link
Contributor

casey commented Jul 28, 2015

This is pretty trivial, but if there's an error here we'll leak a file descriptor. Changed it to always close the file.

This is pretty trivial, but if there's an error here we'll leak a file
descriptor. Changed it to always close the file.
@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Jul 28, 2015

utACK

@laanwj
Copy link
Member

laanwj commented Jul 29, 2015

utACK. Looks good to me. Non-RAII C types are a continuing exception-safety hazard.

@jonasschnelli
Copy link
Member

jonasschnelli commented Jul 29, 2015

Nice catch.
utACK.

@laanwj laanwj merged commit 17ac0f4 into bitcoin:master Jul 29, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jul 29, 2015
17ac0f4 Avoid leaking file descriptors in RegisterLoad (Casey Rodarmor)
@casey casey deleted the casey:register-load-filehandle-leak branch Jul 29, 2015
@jgarzik
Copy link
Contributor

jgarzik commented Jul 29, 2015

posthumous ut ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.