New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking file descriptors in RegisterLoad #6488

Merged
merged 1 commit into from Jul 29, 2015

Conversation

Projects
None yet
5 participants
@casey
Contributor

casey commented Jul 28, 2015

This is pretty trivial, but if there's an error here we'll leak a file descriptor. Changed it to always close the file.

Avoid leaking file descriptors in RegisterLoad
This is pretty trivial, but if there's an error here we'll leak a file
descriptor. Changed it to always close the file.
@TheBlueMatt

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Jul 28, 2015

Contributor

utACK

Contributor

TheBlueMatt commented Jul 28, 2015

utACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 29, 2015

Member

utACK. Looks good to me. Non-RAII C types are a continuing exception-safety hazard.

Member

laanwj commented Jul 29, 2015

utACK. Looks good to me. Non-RAII C types are a continuing exception-safety hazard.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 29, 2015

Member

Nice catch.
utACK.

Member

jonasschnelli commented Jul 29, 2015

Nice catch.
utACK.

@laanwj laanwj merged commit 17ac0f4 into bitcoin:master Jul 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 29, 2015

Merge pull request #6488
17ac0f4 Avoid leaking file descriptors in RegisterLoad (Casey Rodarmor)

@casey casey deleted the casey:register-load-filehandle-leak branch Jul 29, 2015

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Jul 29, 2015

Contributor

posthumous ut ACK

Contributor

jgarzik commented Jul 29, 2015

posthumous ut ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment