Avoid leaking file descriptors in RegisterLoad#6488
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jul 29, 2015
casey:register-load-filehandle-leak
Merged
Avoid leaking file descriptors in RegisterLoad#6488laanwj merged 1 commit intobitcoin:masterfrom casey:register-load-filehandle-leak
laanwj merged 1 commit intobitcoin:masterfrom
casey:register-load-filehandle-leak
Conversation
This is pretty trivial, but if there's an error here we'll leak a file descriptor. Changed it to always close the file.
Contributor
|
utACK |
Member
|
utACK. Looks good to me. Non-RAII C types are a continuing exception-safety hazard. |
Contributor
|
Nice catch. |
laanwj
added a commit
that referenced
this pull request
Jul 29, 2015
17ac0f4 Avoid leaking file descriptors in RegisterLoad (Casey Rodarmor)
Contributor
|
posthumous ut ACK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty trivial, but if there's an error here we'll leak a file descriptor. Changed it to always close the file.