Give a better error message if system clock is bad

[casey]

Fixes #2007

This checks to see if the system clock appears to be bad and gives a
helpful error message. If the user's clock is set incorrectly, hopefully
they'll abort, fix it, and then save themselves a fruitless resync.

I wasn't sure if I needed to grab cs_main before accessing chainActive.Tip(), is that correct?

[sipa]

You do need cs_main for that.

[laanwj]

Any specific reason to read the block from disk here? Reminder: tip itself, a CBlockIndex, also has nTime

[casey]

Ahh, okay. Fixed.

[laanwj]

Concept ACK

[casey]

Updated the commit to use chainActive.Tip()->nTime directly

[bensussman]

Is there no styleguide for the bitcoin codebase that says ">250 character lines are just TOO LONG @casey"?!

[casey]

This string is going to be translated via gettext (that's what the "_" is for) so it's better than it appear in the source as one line, as opposed to being broken up.

[laanwj]

@bensussman To answer your question: no, there is no such rule. See https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md

@casey Using multiple "line" "line2" line3" does not affect translation IIRC if you specify only one _, eg:

strLoadError = _("The block database contains a block which appears to be from the future. "
    "This may be due to your computer's date and time being set incorrectly. "
    "Only rebuild the block database if you are sure that your computer's date and time are correct");

[casey]

Changed to use less ridiculously long strings.

[laanwj]

utACK

[sipa]

utACK

[fanquake]

utACK

On Tuesday, August 4, 2015, Pieter Wuille notifications@github.com wrote:

utACK

—
Reply to this email directly or view it on GitHub
#6489 (comment).

[Diapolo]

computer's is some weird grammar, no?

[ghost]

Not really. It indicates that the computer is the owner of the date & time, which in this case it is.