New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc build fixes #6501

Merged
merged 2 commits into from Aug 3, 2015

Conversation

Projects
None yet
3 participants
@theuni
Member

theuni commented Aug 1, 2015

The first commit addresses #6458 and #6432. I'm not sure if it's enough to fix it completely, but it addresses the bulk of the pkg-config issue.

The second commit (maybe) addresses #6486. I noticed it while I was looking at configure. It's not clear if #6486 is a real bug for that user or not, but either way it was prone to failure before and should work as expected after the change.

theuni added some commits Aug 1, 2015

build: fix libressl detection
Checking libcrypto for a function after we've already found a (possibly
different) libcrypto is not what we want to do here.

pkg-config might've found a cross lib while AC_CHECK_LIB may find a different
or native one.

Run a link-test against the lib that's already been found instead.

@laanwj laanwj added the Build system label Aug 1, 2015

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Aug 1, 2015

Contributor

ut ACK

Contributor

jgarzik commented Aug 1, 2015

ut ACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 3, 2015

Member

Tested ACK

Member

laanwj commented Aug 3, 2015

Tested ACK

@laanwj laanwj merged commit 31bfc27 into bitcoin:master Aug 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 3, 2015

Merge pull request #6501
31bfc27 build: make sure pkg-config checks are guarded by an m4_ifdef (Cory Fields)
d9add71 build: fix libressl detection (Cory Fields)

str4d added a commit to str4d/zcash that referenced this pull request Sep 22, 2016

build: remove libressl check
Now that BIP66 passed, OpenSSL is no longer directly part of the
consensus. What matters is that DER signatures are correctly parsed, and
secp256k1 crypto is implemented correctly (as well as the other
functions we use from OpenSSL, such as random number generation)

This means that effectively, using LibreSSL is not a larger risk than
using another version of OpenSSL.

Remove the specific check for LibreSSL.

Includes the still-relevant part of #6729: make sure CHECK_HEADER is
called using the right CXXFLAGS, not CFLAGS (as AC_LANG is c++).

Zcash Note:
This includes a code removal from d9add71
that was omitted from 5a39133 during
backporting of bitcoin/bitcoin#6501 to 0.11.* in bitcoin/bitcoin#6703

str4d added a commit to str4d/zcash that referenced this pull request Sep 22, 2016

build: remove libressl check
Now that BIP66 passed, OpenSSL is no longer directly part of the
consensus. What matters is that DER signatures are correctly parsed, and
secp256k1 crypto is implemented correctly (as well as the other
functions we use from OpenSSL, such as random number generation)

This means that effectively, using LibreSSL is not a larger risk than
using another version of OpenSSL.

Remove the specific check for LibreSSL.

Includes the still-relevant part of #6729: make sure CHECK_HEADER is
called using the right CXXFLAGS, not CFLAGS (as AC_LANG is c++).

Zcash Note:
This includes a code removal from d9add71
that was omitted from 5a39133 during
backporting of bitcoin/bitcoin#6501 to 0.11.* in bitcoin/bitcoin#6703

str4d added a commit to str4d/zcash that referenced this pull request Sep 26, 2016

build: remove libressl check
Now that BIP66 passed, OpenSSL is no longer directly part of the
consensus. What matters is that DER signatures are correctly parsed, and
secp256k1 crypto is implemented correctly (as well as the other
functions we use from OpenSSL, such as random number generation)

This means that effectively, using LibreSSL is not a larger risk than
using another version of OpenSSL.

Remove the specific check for LibreSSL.

Includes the still-relevant part of #6729: make sure CHECK_HEADER is
called using the right CXXFLAGS, not CFLAGS (as AC_LANG is c++).

Zcash Note:
This includes a code removal from d9add71
that was omitted from 5a39133 during
backporting of bitcoin/bitcoin#6501 to 0.11.* in bitcoin/bitcoin#6703

str4d added a commit to str4d/zcash that referenced this pull request Sep 29, 2016

build: remove libressl check
Now that BIP66 passed, OpenSSL is no longer directly part of the
consensus. What matters is that DER signatures are correctly parsed, and
secp256k1 crypto is implemented correctly (as well as the other
functions we use from OpenSSL, such as random number generation)

This means that effectively, using LibreSSL is not a larger risk than
using another version of OpenSSL.

Remove the specific check for LibreSSL.

Includes the still-relevant part of #6729: make sure CHECK_HEADER is
called using the right CXXFLAGS, not CFLAGS (as AC_LANG is c++).

Zcash Note:
This includes a code removal from d9add71
that was omitted from 5a39133 during
backporting of bitcoin/bitcoin#6501 to 0.11.* in bitcoin/bitcoin#6703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment