Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rationalize currency unit to "BTC" #6504
Previously various user-facing strings have used inconsistent currency units "BTC", "btc" and "bitcoins". This adds a single constant and uses it for each reference to the currency unit.
Also adds a description of the unit for --maxtxfee, and adds the missing "amount" field description to the (deprecated) move RPC command.
I would suggest using XBT instead of the BTx is the ISO prefix for Bhutan.
On Saturday, August 1, 2015, Ross Nicoll firstname.lastname@example.org wrote:
Concept ACK on moving the currency unit to a constant.
Don't touch the file manually. Translation strings are extracted automatically by
Aug 3, 2015
1 check was pending
added a commit
this pull request
Aug 3, 2015
This was referenced
Aug 6, 2015
@luke-jr (On your August 1st comment.) - In 3 letters ISO codes, BTC will never be accepted (even it is used today) by the power to be.
I do prefer the BTC version until I read everything there was on ISO4217 and participated in the foundation working group - https://en.wikipedia.org/wiki/ISO_4217
Once I read it, X (Supranational) BT (Bitcoin) makes more scene than BTC which belong to Bhutan.
Just saying. XBT is free in the ISO code nomenclature. Why not claim it.
I see your point ... leave it as BTC now and wait ... maybe later 1 XBT = 1 µBTC.
To avoid headaches, I use 1 BTC = 1 XBT, 100'000 mBTC = 100'000 mXBT, and 100 µBTC = 100 µXBT and leave the fixing of the social ill to the pope. ISO standard has a field for the decimal (and I believe it does go to 8) so it would be a "trivial" change to use 1 BTC = 1 XBT which makes it simpler in the code to replace.
If the amount changes in the future, we'll change it to something else when we cross that bridge. Anyway, it was a small "loaded" request ....