Use unique name for AlertNotify tempfile

[casey]

Fixes #6524

Use a unique name for alertnotify.txt tempfile during AlertNotify test

[jonasschnelli]

minor nit: wrong indent (same on L171 / not related to this PR)

[casey]

Isn't the right indentation four spaces? Or is it different for a line continuation?

[jonasschnelli]

Meh. Sorry. I oversaw the line break... all good!
You can always use clang-format -i <file> if you wan't to confirm to the code-style-guidelines.

[randy-waterhouse]

tested ACK

[jonasschnelli]

ACK.
Couldn't find any details about when files generated with boost::filesystem::unique_path are deleted.
I think adding a boost::filesystem::remove(temp); wouldn't harm?

[laanwj]

ACK. Using a hardcoded/predictable temporary file name can be dangerous.

And agree with @jonasschnelli that the test should try to clean up after itself.

[casey]

@jonasschnelli @laanwj It actually does clean up after itself; there's a call to boost::filesystem::remove(temp) at the end of the function.

[jonasschnelli]

@casey: Ah. Now i see how this works. The boost::filesystem::remove(temp); removed in this PR was there because the file was not really a random tmp file.

ACK.

[laanwj]

Oh! oops. Apologies for the spurious comment, then.