New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] show client user agent in debug window #6529

Merged
merged 1 commit into from Aug 7, 2015

Conversation

Projects
None yet
6 participants
@Diapolo

Diapolo commented Aug 6, 2015

subver

I added the same indentation to the subversion as we have for the lib versions, this is just an obsolete screenshot.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 6, 2015

Member

ACK

Member

laanwj commented Aug 6, 2015

ACK

@laanwj laanwj added the GUI label Aug 6, 2015

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Aug 6, 2015

Member

Tested ACK
screen shot 4

Member

fanquake commented Aug 6, 2015

Tested ACK
screen shot 4

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 7, 2015

Member

Small nit: let's call it "User agent" instead of "Client subversion". I can see "subversion" resulting in quite funny translations, and more people will understand it by comparing it to HTTP user agent (that's also why we use option -uacomment)

Member

laanwj commented Aug 7, 2015

Small nit: let's call it "User agent" instead of "Client subversion". I can see "subversion" resulting in quite funny translations, and more people will understand it by comparing it to HTTP user agent (that's also why we use option -uacomment)

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Aug 7, 2015

Contributor

Do we need starting and trailing / in Client version and User agent/Client subversion at all?

Contributor

paveljanik commented Aug 7, 2015

Do we need starting and trailing / in Client version and User agent/Client subversion at all?

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 7, 2015

Member

IMO, yes. Don't try to be smart and just report as it is sent to the P2P network.

Member

laanwj commented Aug 7, 2015

IMO, yes. Don't try to be smart and just report as it is sent to the P2P network.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Aug 7, 2015

Contributor

ACK

Contributor

paveljanik commented Aug 7, 2015

ACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Aug 7, 2015

Member

+1 for User Agent (The Peers-tab in the debug window already calls it that way)

Member

MarcoFalke commented Aug 7, 2015

+1 for User Agent (The Peers-tab in the debug window already calls it that way)

@Diapolo Diapolo changed the title from [Qt] show client subversion in debug window to [Qt] show client user agent in debug window Aug 7, 2015

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Aug 7, 2015

Updated to User Agent.

Diapolo commented Aug 7, 2015

Updated to User Agent.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Aug 7, 2015

Member

Tested ACK.
+1 for user agent.
bildschirmfoto 2015-08-07 um 14 31 29

Member

jonasschnelli commented Aug 7, 2015

Tested ACK.
+1 for user agent.
bildschirmfoto 2015-08-07 um 14 31 29

@laanwj laanwj merged commit 54bd28f into bitcoin:master Aug 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 7, 2015

Merge pull request #6529
54bd28f [Qt] show client user agent in debug window (Philip Kaufmann)

@Diapolo Diapolo deleted the Diapolo:Qt_subver branch Aug 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment