Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] show client user agent in debug window #6529

Merged
merged 1 commit into from Aug 7, 2015
Merged

Conversation

@Diapolo
Copy link

Diapolo commented Aug 6, 2015

subver

I added the same indentation to the subversion as we have for the lib versions, this is just an obsolete screenshot.

@laanwj
Copy link
Member

laanwj commented Aug 6, 2015

ACK

@laanwj laanwj added the GUI label Aug 6, 2015
@fanquake
Copy link
Member

fanquake commented Aug 6, 2015

Tested ACK
screen shot 4

@laanwj
Copy link
Member

laanwj commented Aug 7, 2015

Small nit: let's call it "User agent" instead of "Client subversion". I can see "subversion" resulting in quite funny translations, and more people will understand it by comparing it to HTTP user agent (that's also why we use option -uacomment)

@paveljanik
Copy link
Contributor

paveljanik commented Aug 7, 2015

Do we need starting and trailing / in Client version and User agent/Client subversion at all?

@laanwj
Copy link
Member

laanwj commented Aug 7, 2015

IMO, yes. Don't try to be smart and just report as it is sent to the P2P network.

@paveljanik
Copy link
Contributor

paveljanik commented Aug 7, 2015

ACK

@MarcoFalke
Copy link
Member

MarcoFalke commented Aug 7, 2015

+1 for User Agent (The Peers-tab in the debug window already calls it that way)

@Diapolo Diapolo changed the title [Qt] show client subversion in debug window [Qt] show client user agent in debug window Aug 7, 2015
@Diapolo
Copy link
Author

Diapolo commented Aug 7, 2015

Updated to User Agent.

@jonasschnelli
Copy link
Member

jonasschnelli commented Aug 7, 2015

Tested ACK.
+1 for user agent.
bildschirmfoto 2015-08-07 um 14 31 29

@laanwj laanwj merged commit 54bd28f into bitcoin:master Aug 7, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Aug 7, 2015
54bd28f [Qt] show client user agent in debug window (Philip Kaufmann)
@Diapolo Diapolo deleted the Diapolo:Qt_subver branch Aug 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.