[Qt] show client user agent in debug window #6529
Merged
+54
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
|
Tested ACK |
|
Small nit: let's call it "User agent" instead of "Client subversion". I can see "subversion" resulting in quite funny translations, and more people will understand it by comparing it to HTTP user agent (that's also why we use option |
|
Do we need starting and trailing |
|
IMO, yes. Don't try to be smart and just report as it is sent to the P2P network. |
|
ACK |
|
+1 for |
Diapolo
changed the title
|
Updated to |
|
Tested ACK. |
laanwj
added a commit
that referenced
this pull request
Aug 7, 2015
54bd28f [Qt] show client user agent in debug window (Philip Kaufmann)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the same indentation to the subversion as we have for the lib versions, this is just an obsolete screenshot.