Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for miniupnpc api version 14 #6583

Merged
merged 1 commit into from Aug 31, 2015
Merged

add support for miniupnpc api version 14 #6583

merged 1 commit into from Aug 31, 2015

Conversation

@x-rat4-x
Copy link
Contributor

x-rat4-x commented Aug 23, 2015

The value of new arg ttl is set to 2 as it's recommended default.

The value of new arg ttl is set to 2 as it's recommended default.
@laanwj laanwj added the P2P label Aug 24, 2015
@fanquake
Copy link
Member

fanquake commented Aug 24, 2015

@laanwj
Copy link
Member

laanwj commented Aug 24, 2015

utACK

@theuni
Copy link
Member

theuni commented Aug 24, 2015

ut ACK. Any reason not to bump to 1.9.20150730 in depends as well?

@laanwj
Copy link
Member

laanwj commented Aug 25, 2015

@theuni sounds good to me

@sipa
Copy link
Member

sipa commented Aug 25, 2015

ut ACK

@laanwj laanwj merged commit 9f3e48e into bitcoin:master Aug 31, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Aug 31, 2015
9f3e48e add support for miniupnpc api version 14 (Pavel Vasin)
laanwj added a commit that referenced this pull request Jul 29, 2019
59cb722 Update configure to reject unsafe miniUPnPc API ver (Hennadii Stepanov)
ab21905 doc: Add release notes for 15993 (Hennadii Stepanov)
02709e9 Align formatting with clang-format (Hennadii Stepanov)
91a1b85 Use PACKAGE_NAME in UPnP description (Hennadii Stepanov)
9f76e45 Drop support of insecure miniUPnPc versions (Hennadii Stepanov)

Pull request description:

  1. Minimum supported miniUPnPc API version is set to 10:
  - https://packages.ubuntu.com/xenial/libminiupnpc-dev
  - https://packages.debian.org/jessie/libminiupnpc-dev

  Refs:
  - #6583
  - #6789
  - #10414

  2. The hardcoded "Bitcoin" replaced with `PACKAGE_NAME`:
  ![Screenshot from 2019-05-06 23-10-29](https://user-images.githubusercontent.com/32963518/57253178-afc60780-7056-11e9-83c9-e85670c58c1e.png)

  3. Also style-only commit applied.

  Pardon: could not reopen my previous PR #15966.

ACKs for top commit:
  ryanofsky:
    utACK 59cb722. Changes since last review: adding a new commit which updates configure script to fall back to disabling upnp if version is too old, adding a requested comment explaining static_assert condition, and fixing a spelling (jessy/jessie)

Tree-SHA512: 42ed11bc2fb2ec83d5dd58e2383da5444a24fd572707f6cf10b622cb8943e28adfcca4750d06801024c4472625b5ea9279516fbd9d2ccebc9bbaafe1d148e80d
sidhujag added a commit to syscoin/syscoin that referenced this pull request Jul 30, 2019
…ions

59cb722 Update configure to reject unsafe miniUPnPc API ver (Hennadii Stepanov)
ab21905 doc: Add release notes for 15993 (Hennadii Stepanov)
02709e9 Align formatting with clang-format (Hennadii Stepanov)
91a1b85 Use PACKAGE_NAME in UPnP description (Hennadii Stepanov)
9f76e45 Drop support of insecure miniUPnPc versions (Hennadii Stepanov)

Pull request description:

  1. Minimum supported miniUPnPc API version is set to 10:
  - https://packages.ubuntu.com/xenial/libminiupnpc-dev
  - https://packages.debian.org/jessie/libminiupnpc-dev

  Refs:
  - bitcoin#6583
  - bitcoin#6789
  - bitcoin#10414

  2. The hardcoded "Bitcoin" replaced with `PACKAGE_NAME`:
  ![Screenshot from 2019-05-06 23-10-29](https://user-images.githubusercontent.com/32963518/57253178-afc60780-7056-11e9-83c9-e85670c58c1e.png)

  3. Also style-only commit applied.

  Pardon: could not reopen my previous PR bitcoin#15966.

ACKs for top commit:
  ryanofsky:
    utACK 59cb722. Changes since last review: adding a new commit which updates configure script to fall back to disabling upnp if version is too old, adding a requested comment explaining static_assert condition, and fixing a spelling (jessy/jessie)

Tree-SHA512: 42ed11bc2fb2ec83d5dd58e2383da5444a24fd572707f6cf10b622cb8943e28adfcca4750d06801024c4472625b5ea9279516fbd9d2ccebc9bbaafe1d148e80d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.