New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include bitcoin-tx binary on Debian/Ubuntu #6600

Merged
merged 3 commits into from Sep 24, 2015

Conversation

Projects
None yet
7 participants
@zw
Contributor

zw commented Aug 29, 2015

Currently left out of Matt's PPA. Debian's package for unstable already has it.

Include bitcoin-tx binary on Debian/Ubuntu
Currently left out of Matt's PPA.  Debian's package for unstable already has it.
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented Aug 29, 2015

utACK

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Aug 29, 2015

Member

This should be a separate package.

Member

luke-jr commented Aug 29, 2015

This should be a separate package.

@zw

This comment has been minimized.

Show comment
Hide comment
@zw

zw Aug 29, 2015

Contributor

@luke-jr I've no strong feelings; I'm sure I've come across both single-binary packages and lump-it-in-with-the-oft-unused-daemon packages in Debian. Seems like a distro decision to me, but consistency over where to find what binary seems a good idea, however it's achieved.

This does highlight the slightly silly situation of Debian's debianisation living with them (neither clearly following git nor pushing stuff like this to git), and the PPA's debianisation living here. Would be nice to change things in just one place.

Contributor

zw commented Aug 29, 2015

@luke-jr I've no strong feelings; I'm sure I've come across both single-binary packages and lump-it-in-with-the-oft-unused-daemon packages in Debian. Seems like a distro decision to me, but consistency over where to find what binary seems a good idea, however it's achieved.

This does highlight the slightly silly situation of Debian's debianisation living with them (neither clearly following git nor pushing stuff like this to git), and the PPA's debianisation living here. Would be nice to change things in just one place.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 31, 2015

Member

No strong feelings on this, although @luke-jr does have a point. bitcoin-tx is an utility that depends on neither the server nor the RPC client.

Member

laanwj commented Aug 31, 2015

No strong feelings on this, although @luke-jr does have a point. bitcoin-tx is an utility that depends on neither the server nor the RPC client.

@laanwj laanwj added the Build system label Aug 31, 2015

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Aug 31, 2015

Contributor

ACK

Contributor

jgarzik commented Aug 31, 2015

ACK

@zw

This comment has been minimized.

Show comment
Hide comment
@zw

zw Sep 1, 2015

Contributor

Filed a bug with Debian's maintainers, making a case for splitting it out like Gentoo does. Let's see what they say.

Contributor

zw commented Sep 1, 2015

Filed a bug with Debian's maintainers, making a case for splitting it out like Gentoo does. Let's see what they say.

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Sep 15, 2015

Contributor

For the moment, the pull request is obviously better than not shipping the tool at all.

It is better to merge this, and then update if the new pkg route is chosen.

Contributor

jgarzik commented Sep 15, 2015

For the moment, the pull request is obviously better than not shipping the tool at all.

It is better to merge this, and then update if the new pkg route is chosen.

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Sep 16, 2015

Contributor

ACK, merge unless/until a new package is created.

Contributor

dcousens commented Sep 16, 2015

ACK, merge unless/until a new package is created.

Split bitcoin-tx into its own package
Reverts the change putting it in the bitcoind deb.
@zw

This comment has been minimized.

Show comment
Hide comment
@zw

zw Sep 17, 2015

Contributor

No reply on the bug but I can't really see Debian folks disagreeing, so the updated version puts bitcoin-tx in its own single-binary package. @TheBlueMatt might want to comment and/or add a changelog entry, if only so that the resulting package version is bumped to 0.11 - there are Ubuntu-specific suffixes in there so I'm not sure I should touch it.

Contributor

zw commented Sep 17, 2015

No reply on the bug but I can't really see Debian folks disagreeing, so the updated version puts bitcoin-tx in its own single-binary package. @TheBlueMatt might want to comment and/or add a changelog entry, if only so that the resulting package version is bumped to 0.11 - there are Ubuntu-specific suffixes in there so I'm not sure I should touch it.

Drop "with minimal dependencies" from description
Five boost libs plus libcrypto are needed; I don't think that quite passes for minimal.
@TheBlueMatt

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Sep 19, 2015

Contributor

utACK as it is now. I would prefer you not touch the changelog (I need to push an update that syncs it with the latest version used against the Ubuntu repo first, so unless you want to do that, just leave it).

On September 17, 2015 1:36:20 AM CDT, Zak Wilcox notifications@github.com wrote:

No reply on the bug but I can't really see Debian folks disagreeing, so
the updated version puts bitcoin-tx in its own single-binary package.
@TheBlueMatt might want to comment and/or add a changelog entry, if
only so that the resulting package version is bumped to 0.11 - there
are Ubuntu-specific suffixes in there so I'm not sure I should touch
it.


Reply to this email directly or view it on GitHub:
#6600 (comment)

Contributor

TheBlueMatt commented Sep 19, 2015

utACK as it is now. I would prefer you not touch the changelog (I need to push an update that syncs it with the latest version used against the Ubuntu repo first, so unless you want to do that, just leave it).

On September 17, 2015 1:36:20 AM CDT, Zak Wilcox notifications@github.com wrote:

No reply on the bug but I can't really see Debian folks disagreeing, so
the updated version puts bitcoin-tx in its own single-binary package.
@TheBlueMatt might want to comment and/or add a changelog entry, if
only so that the resulting package version is bumped to 0.11 - there
are Ubuntu-specific suffixes in there so I'm not sure I should touch
it.


Reply to this email directly or view it on GitHub:
#6600 (comment)

@laanwj laanwj merged commit b0beae8 into bitcoin:master Sep 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 24, 2015

Merge pull request #6600
b0beae8 Drop "with minimal dependencies" from description (Zak Wilcox)
5e5e00b Split bitcoin-tx into its own package (Zak Wilcox)
05179f7 Include bitcoin-tx binary on Debian/Ubuntu (Zak Wilcox)

@zw zw deleted the zw:patch-1 branch Sep 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment