Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: bump miniupnpc and ccache #6619

Merged
merged 2 commits into from Sep 25, 2015
Merged

depends: bump miniupnpc and ccache #6619

merged 2 commits into from Sep 25, 2015

Conversation

@fanquake
Copy link
Member

fanquake commented Sep 2, 2015

@theuni mentioned we can bump miniupnpc to 1.9.20150730 in #6583.
release notes

$Id: Changelog.txt,v 1.212 2015/07/23 20:41:50 nanard Exp $
miniUPnP client Changelog.
2015/07/23:
  split getDevicesFromMiniSSDPD
  add ttl argument to upnpDiscover() functions
  increments API_VERSION to 14

2015/07/22:
  Read USN from SSDP messages.

2015/07/15:
  Check malloc/calloc

2015/06/16:
  update getDevicesFromMiniSSDPD() to process longer minissdpd
    responses

We could also bump ccache to 3.2.3 (currently 3.2.2) release notes

ccache 3.2.3
Release date: 2015-08-16

New features and improvements
Added support for compiler option -gsplit-dwarf.

Bug fixes
Support external zlib in nonstandard directory.

Avoid calling exit() inside an exit handler.

Let exit handler terminate properly.

Bail out on compiler option --save-temps in addition to -save-temps.

Only log "Disabling direct mode" once when failing to read potential include files.

qrencode (3.44) and protobuf (2.6.1) are still both the most recent releases.

Boost 1.59.0 is out, release notes here

@jonasschnelli
Copy link
Member

jonasschnelli commented Sep 2, 2015

Tried a gitian build... seems to be a hash/checksum issue somewhere:
https://builds.jonasschnelli.ch/pulls/6619/
https://builds.jonasschnelli.ch/pulls/6619/build-linux.log

@fanquake
Copy link
Member Author

fanquake commented Sep 2, 2015

Can you manually download http://miniupnp.free.fr/files/miniupnpc-1.9.20150730.tar.gz, and see if you get a different SHA256?

7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2
@jonasschnelli
Copy link
Member

jonasschnelli commented Sep 2, 2015

Jup. Is different.

jonasschnelli$ openssl dgst -sha256 miniupnpc-1.9.20150730.tar.gz 
SHA256(miniupnpc-1.9.20150730.tar.gz)= 1d64fab1fd3b4c8545139341ba197f19329a863f4f21b578fc2a228ab586a604
@fanquake
Copy link
Member Author

fanquake commented Sep 2, 2015

Interesting, can someone else download and confirm I'm generating the wrong hash?

fanquake$ openssl dgst -sha256 miniupnpc-1.9.20150730.tar.gz 
SHA256(miniupnpc-1.9.20150730.tar.gz)= 7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2

fanquake$ shasum -a 256 miniupnpc-1.9.20150730.tar.gz 
7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2  miniupnpc-1.9.20150730.tar.gz
@theuni
Copy link
Member

theuni commented Sep 2, 2015

cory@cory-i7:/tmp$ sha256sum miniupnpc-1.9.20150730.tar.gz 
1d64fab1fd3b4c8545139341ba197f19329a863f4f21b578fc2a228ab586a604  miniupnpc-1.9.20150730.tar.gz
@fanquake fanquake force-pushed the fanquake:depends-bump branch Sep 2, 2015
@laanwj
Copy link
Member

laanwj commented Sep 2, 2015

Just downloaded:

Sha256: 1d64fab1fd3b4c8545139341ba197f19329a863f4f21b578fc2a228ab586a604  miniupnpc-1.9.20150730.tar.gz
Size: 81431 

Would be very interested in @fanquake's variant.

@fanquake fanquake force-pushed the fanquake:depends-bump branch to 42cf089 Sep 2, 2015
@fanquake
Copy link
Member Author

fanquake commented Sep 2, 2015

I've amended the miniupnpc commit

@laanwj If I download using the depends system, or wget directly, I get the correct file and hash. However if I download using the exact same link in Chrome, I'm getting a different 400kb file..

@theuni
Copy link
Member

theuni commented Sep 2, 2015

@fanquake same! firefox is the good hash, chromium is different (7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2, same as yours). Investigating now.

@theuni
Copy link
Member

theuni commented Sep 2, 2015

ok, mystery solved, though it only raises further questions:

cory$ sha256sum miniupnpc-1.9.20150730.tar.gz 
1d64fab1fd3b4c8545139341ba197f19329a863f4f21b578fc2a228ab586a604  miniupnpc-1.9.20150730.tar.gz
cory$ gzip -d miniupnpc-1.9.20150730.tar.gz 
cory$ sha256sum miniupnpc-1.9.20150730.tar 
7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2  miniupnpc-1.9.20150730.tar
@laanwj laanwj added the Build system label Sep 3, 2015
@laanwj
Copy link
Member

laanwj commented Sep 4, 2015

ACK

@laanwj
Copy link
Member

laanwj commented Sep 23, 2015

This is the complete diff between the two miniupnp versions: https://gist.github.com/laanwj/18e5da2b68f3a7127e27

@laanwj laanwj merged commit 42cf089 into bitcoin:master Sep 25, 2015
laanwj added a commit that referenced this pull request Sep 25, 2015
42cf089 depends: bump ccache to 3.2.3 (fanquake)
888c595 depends: bump miniupnpc to 1.9.20150730 (fanquake)
@theuni
Copy link
Member

theuni commented Sep 25, 2015

post-merge ACK

@fanquake fanquake deleted the fanquake:depends-bump branch May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.