Replace boost::reverse_lock with our own #6630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ACK if Travis is happy. |
Contributor
Author
|
Travis is unhappy; I think I neglected to add the new file to the makefile. Fixing it now. |
Contributor
|
ACK after minor nits. |
src/reverselock.h
Outdated
Member
|
utACK, thanks for adding tests! |
Contributor
|
ACK, works nicely on my OSX machine. |
laanwj
added a commit
that referenced
this pull request
Sep 3, 2015
86270c8 Replace boost::reverse_lock with our own. (Casey Rodarmor)
Contributor
|
Great work @casey 👍 , utACK |
Contributor
|
PostMerge ACK. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6608 for discussion.
This removes boost::reverse_lock so that we don't depend on boost 1.50, and replaces it with our own implementation.
This implementation is stricter than boost::reverse_lock. Reverse locking an unlocked lock, and re-locking a lock while a reverse_lock is active are both errors.