New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report minimum ping time in getpeerinfo #6633

Merged
merged 1 commit into from Sep 4, 2015

Conversation

Projects
None yet
6 participants
@TheBlueMatt
Contributor

TheBlueMatt commented Sep 3, 2015

No description provided.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Sep 4, 2015

Member

utACK

Member

jonasschnelli commented Sep 4, 2015

utACK

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Sep 4, 2015

Contributor

ACK

Contributor

paveljanik commented Sep 4, 2015

ACK

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Sep 4, 2015

Member

utACK

On Friday, September 4, 2015, paveljanik notifications@github.com wrote:

ACK


Reply to this email directly or view it on GitHub
#6633 (comment).

Member

fanquake commented Sep 4, 2015

utACK

On Friday, September 4, 2015, paveljanik notifications@github.com wrote:

ACK


Reply to this email directly or view it on GitHub
#6633 (comment).

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Sep 4, 2015

Member

minping seems to be zero in most cases. Being connected to 3 "incoming peers" on localhost and 8 "outgoing peers" on testnet I get

$ getpeerinfo|grep minping
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.107754,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.219713,
    "minping": 9.6e-05,
    "minping": 0,
Member

MarcoFalke commented Sep 4, 2015

minping seems to be zero in most cases. Being connected to 3 "incoming peers" on localhost and 8 "outgoing peers" on testnet I get

$ getpeerinfo|grep minping
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.107754,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.219713,
    "minping": 9.6e-05,
    "minping": 0,
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Sep 4, 2015

Member

@MarcoFalke Good catch: nMinPingUsecTime is left uninitialized on CNode creation. And as it is a moving minimum, it should probably default to std::numeric_limits<int64_t>::max() initially, not zero.

Member

laanwj commented Sep 4, 2015

@MarcoFalke Good catch: nMinPingUsecTime is left uninitialized on CNode creation. And as it is a moving minimum, it should probably default to std::numeric_limits<int64_t>::max() initially, not zero.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Sep 4, 2015

Member

ACK on this pull.

Member

laanwj commented Sep 4, 2015

ACK on this pull.

@laanwj laanwj merged commit a6eb4ba into bitcoin:master Sep 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 4, 2015

Merge pull request #6633
a6eb4ba Report minimum ping time in getpeerinfo (Matt Corallo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment