Skip to content

Report minimum ping time in getpeerinfo#6633

Merged
laanwj merged 1 commit intobitcoin:masterfrom
TheBlueMatt:minpingreport
Sep 4, 2015
Merged

Report minimum ping time in getpeerinfo#6633
laanwj merged 1 commit intobitcoin:masterfrom
TheBlueMatt:minpingreport

Conversation

@TheBlueMatt
Copy link
Copy Markdown
Contributor

No description provided.

@jonasschnelli
Copy link
Copy Markdown
Contributor

utACK

@paveljanik
Copy link
Copy Markdown
Contributor

ACK

@fanquake
Copy link
Copy Markdown
Member

fanquake commented Sep 4, 2015

utACK

On Friday, September 4, 2015, paveljanik notifications@github.com wrote:

ACK


Reply to this email directly or view it on GitHub
#6633 (comment).

@maflcko
Copy link
Copy Markdown
Member

maflcko commented Sep 4, 2015

minping seems to be zero in most cases. Being connected to 3 "incoming peers" on localhost and 8 "outgoing peers" on testnet I get

$ getpeerinfo|grep minping
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.107754,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.219713,
    "minping": 9.6e-05,
    "minping": 0,

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Sep 4, 2015

@MarcoFalke Good catch: nMinPingUsecTime is left uninitialized on CNode creation. And as it is a moving minimum, it should probably default to std::numeric_limits<int64_t>::max() initially, not zero.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Sep 4, 2015

ACK on this pull.

@laanwj laanwj merged commit a6eb4ba into bitcoin:master Sep 4, 2015
laanwj added a commit that referenced this pull request Sep 4, 2015
a6eb4ba Report minimum ping time in getpeerinfo (Matt Corallo)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants