Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report minimum ping time in getpeerinfo #6633

Merged
merged 1 commit into from
Sep 4, 2015
Merged

Report minimum ping time in getpeerinfo #6633

merged 1 commit into from
Sep 4, 2015

Conversation

TheBlueMatt
Copy link
Contributor

No description provided.

@jonasschnelli
Copy link
Contributor

utACK

@paveljanik
Copy link
Contributor

ACK

@fanquake
Copy link
Member

fanquake commented Sep 4, 2015

utACK

On Friday, September 4, 2015, paveljanik notifications@github.com wrote:

ACK

—
Reply to this email directly or view it on GitHub
#6633 (comment).

@maflcko
Copy link
Member

maflcko commented Sep 4, 2015

minping seems to be zero in most cases. Being connected to 3 "incoming peers" on localhost and 8 "outgoing peers" on testnet I get

$ getpeerinfo|grep minping
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.107754,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.219713,
    "minping": 9.6e-05,
    "minping": 0,

@laanwj
Copy link
Member

laanwj commented Sep 4, 2015

@MarcoFalke Good catch: nMinPingUsecTime is left uninitialized on CNode creation. And as it is a moving minimum, it should probably default to std::numeric_limits<int64_t>::max() initially, not zero.

@laanwj
Copy link
Member

laanwj commented Sep 4, 2015

ACK on this pull.

@laanwj laanwj merged commit a6eb4ba into bitcoin:master Sep 4, 2015
laanwj added a commit that referenced this pull request Sep 4, 2015
@laanwj
Merge pull request #6633
bbc2b39 
a6eb4ba Report minimum ping time in getpeerinfo (Matt Corallo)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TheBlueMatt @jonasschnelli @paveljanik @fanquake @maflcko @laanwj