New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Pop debug window in foreground when opened twice #6653

Merged
merged 2 commits into from Sep 23, 2015

Conversation

Projects
None yet
5 participants
@MarcoFalke
Member

MarcoFalke commented Sep 8, 2015

Currently the debug window stays in the background when opened a second time. It should pop up in the foreground, instead.

The commit is pretty much a conceptual copy of 5ffaaba and 382e9e2.

@Diapolo

View changes

Show outdated Hide outdated src/qt/bitcoingui.cpp
// prevents an open debug window from becoming stuck/unusable on client shutdown
connect(quitAction, SIGNAL(triggered()), rpcConsole, SLOT(hide()));

This comment has been minimized.

@Diapolo

Diapolo Sep 9, 2015

Nit: Please remove one of the new-lines.

@Diapolo

Diapolo Sep 9, 2015

Nit: Please remove one of the new-lines.

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Sep 9, 2015

Seems to be another try like mine with #6288.

Diapolo commented Sep 9, 2015

Seems to be another try like mine with #6288.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
Member

jonasschnelli commented Sep 10, 2015

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Sep 11, 2015

Member

@Diapolo Thanks for the feedback. I have rearranged the commits according to comments. The rename commit is now HEAD, so it can be easily dropped.

@jonasschnelli Thanks for the binaries. The binaries are using now outdated a bit because I force pushed ed2c72e in the meantime. You can expect the following from ed2c72e:

Debug window ... Mac OS [fanquake] Fedora Linux (GNOME) Windows 7
... on another virtual desktop: switch to virtual desktop and show switch to virtual desktop and show n.a.
... hidden behind other windows: raise to foreground raise to foreground raise to foreground
... minimized: show n.a. show
Member

MarcoFalke commented Sep 11, 2015

@Diapolo Thanks for the feedback. I have rearranged the commits according to comments. The rename commit is now HEAD, so it can be easily dropped.

@jonasschnelli Thanks for the binaries. The binaries are using now outdated a bit because I force pushed ed2c72e in the meantime. You can expect the following from ed2c72e:

Debug window ... Mac OS [fanquake] Fedora Linux (GNOME) Windows 7
... on another virtual desktop: switch to virtual desktop and show switch to virtual desktop and show n.a.
... hidden behind other windows: raise to foreground raise to foreground raise to foreground
... minimized: show n.a. show
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Sep 12, 2015

Member

Tested ed2c72e on OS X

On another virtual desktop: switch to virtual desktop and show
Hidden behind other windows: raise to foreground
Minimised: show
Member

fanquake commented Sep 12, 2015

Tested ed2c72e on OS X

On another virtual desktop: switch to virtual desktop and show
Hidden behind other windows: raise to foreground
Minimised: show

MarcoFalke added some commits Aug 18, 2015

[Qt] Raise debug window when requested
* Raise the debug window when hidden behind other windows
* Switch to the debug window when on another virtual desktop
* Show the debug window when minimized

This change is a conceptual copy of 5ffaaba and 382e9e2
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Sep 23, 2015

Member

Trivial rebase (3-way merge)

Member

MarcoFalke commented Sep 23, 2015

Trivial rebase (3-way merge)

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Sep 23, 2015

Member

ReACK.

Member

jonasschnelli commented Sep 23, 2015

ReACK.

@laanwj laanwj merged commit 4dee609 into bitcoin:master Sep 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 23, 2015

Merge pull request #6653
4dee609 Rename rpcconsole.ui => debugwindow.ui (MarcoFalke)
0d0a2d6 [Qt] Raise debug window when requested (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:MarcoFalke-2015-GUI-ActivateDebugWindow branch Sep 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment