Skip to content

[Qt] Pop debug window in foreground when opened twice#6653

Merged
laanwj merged 2 commits intobitcoin:masterfrom
maflcko:MarcoFalke-2015-GUI-ActivateDebugWindow
Sep 23, 2015
Merged

[Qt] Pop debug window in foreground when opened twice#6653
laanwj merged 2 commits intobitcoin:masterfrom
maflcko:MarcoFalke-2015-GUI-ActivateDebugWindow

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Sep 8, 2015

Currently the debug window stays in the background when opened a second time. It should pop up in the foreground, instead.

The commit is pretty much a conceptual copy of 5ffaaba and 382e9e2.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please remove one of the new-lines.

@Diapolo
Copy link

Diapolo commented Sep 9, 2015

Seems to be another try like mine with #6288.

@jonasschnelli
Copy link
Contributor

Tested ACK.
Binaries: https://builds.jonasschnelli.ch/pulls/6653/

@maflcko maflcko force-pushed the MarcoFalke-2015-GUI-ActivateDebugWindow branch from ad3c945 to ed2c72e Compare September 11, 2015 09:21
@maflcko
Copy link
Member Author

maflcko commented Sep 11, 2015

@Diapolo Thanks for the feedback. I have rearranged the commits according to comments. The rename commit is now HEAD, so it can be easily dropped.

@jonasschnelli Thanks for the binaries. The binaries are using now outdated a bit because I force pushed ed2c72e in the meantime. You can expect the following from ed2c72e:

Debug window ... Mac OS [fanquake] Fedora Linux (GNOME) Windows 7
... on another virtual desktop: switch to virtual desktop and show switch to virtual desktop and show n.a.
... hidden behind other windows: raise to foreground raise to foreground raise to foreground
... minimized: show n.a. show

@fanquake
Copy link
Member

Tested ed2c72e on OS X

On another virtual desktop: switch to virtual desktop and show
Hidden behind other windows: raise to foreground
Minimised: show

MarcoFalke added 2 commits September 23, 2015 10:27
* Raise the debug window when hidden behind other windows
* Switch to the debug window when on another virtual desktop
* Show the debug window when minimized

This change is a conceptual copy of 5ffaaba and 382e9e2
@maflcko maflcko force-pushed the MarcoFalke-2015-GUI-ActivateDebugWindow branch from ed2c72e to 4dee609 Compare September 23, 2015 08:28
@maflcko
Copy link
Member Author

maflcko commented Sep 23, 2015

Trivial rebase (3-way merge)

@jonasschnelli
Copy link
Contributor

ReACK.

@laanwj laanwj merged commit 4dee609 into bitcoin:master Sep 23, 2015
laanwj added a commit that referenced this pull request Sep 23, 2015
4dee609 Rename rpcconsole.ui => debugwindow.ui (MarcoFalke)
0d0a2d6 [Qt] Raise debug window when requested (MarcoFalke)
@maflcko maflcko deleted the MarcoFalke-2015-GUI-ActivateDebugWindow branch September 24, 2015 10:04
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants