devtools: don't push if signing fails in github-merge#6692
Merged
laanwj merged 1 commit intobitcoin:masterfrom Sep 18, 2015
Merged
devtools: don't push if signing fails in github-merge#6692laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
If a problem happens with gpg, exit prematurely so that it doesn't push the branch upstream.
Contributor
|
ut ACK |
laanwj
added a commit
that referenced
this pull request
Sep 18, 2015
3802ae7 devtools: don't push if signing fails in github-merge (Wladimir J. van der Laan)
Contributor
|
This is not sufficient, sadly. You really need to call contrib/verify-commits/verify-commits.sh with #6671 applied (or use the push-hook included in the same dir). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a problem happens with gpg, exit prematurely so that it doesn't push the branch upstream.