Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools: don't push if signing fails in github-merge #6692

Merged
merged 1 commit into from Sep 18, 2015

Conversation

@laanwj
Copy link
Member

laanwj commented Sep 18, 2015

If a problem happens with gpg, exit prematurely so that it doesn't push the branch upstream.

If a problem happens with gpg, exit prematurely so that it doesn't push
the branch upstream.
@jgarzik
Copy link
Contributor

jgarzik commented Sep 18, 2015

ut ACK

@laanwj laanwj merged commit 3802ae7 into bitcoin:master Sep 18, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Sep 18, 2015
3802ae7 devtools: don't push if signing fails in github-merge (Wladimir J. van der Laan)
@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Sep 18, 2015

This is not sufficient, sadly. You really need to call contrib/verify-commits/verify-commits.sh with #6671 applied (or use the push-hook included in the same dir).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.