devtools: don't push if signing fails in github-merge #6692

Merged
merged 1 commit into from Sep 18, 2015

Conversation

Projects
None yet
3 participants
@laanwj
Member

laanwj commented Sep 18, 2015

If a problem happens with gpg, exit prematurely so that it doesn't push the branch upstream.

devtools: don't push if signing fails in github-merge
If a problem happens with gpg, exit prematurely so that it doesn't push
the branch upstream.
@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Sep 18, 2015

Contributor

ut ACK

Contributor

jgarzik commented Sep 18, 2015

ut ACK

@laanwj laanwj merged commit 3802ae7 into bitcoin:master Sep 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 18, 2015

Merge pull request #6692
3802ae7 devtools: don't push if signing fails in github-merge (Wladimir J. van der Laan)
@TheBlueMatt

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Sep 18, 2015

Contributor

This is not sufficient, sadly. You really need to call contrib/verify-commits/verify-commits.sh with #6671 applied (or use the push-hook included in the same dir).

Contributor

TheBlueMatt commented Sep 18, 2015

This is not sufficient, sadly. You really need to call contrib/verify-commits/verify-commits.sh with #6671 applied (or use the push-hook included in the same dir).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment