Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Creates unittests for addrman, makes addrman more testable. #6720
@jonasschnelli What advantages are offered by using the --enable-tests flag?
Also how would one learn the value of --enable-tests at the level necessary to change code behavior? I suppose you could move the MakeDeterministic method into its own source file and then only include that source when building tests but that is a bit complicated.
I could also remove the ifdef ADDRMAN_TEST check completely.
@eth0: maybe remote the
Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
I am developing some non-unittest code which builds on the