Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[rpc-tests] Check return code #6827
referenced this pull request
Oct 14, 2015
If that's the only one, can you just do them in the same PR? It seems overkill for each to have it's own.
On October 14, 2015 11:36:42 AM PDT, MarcoFalke firstname.lastname@example.org wrote:
utACK. But agree with @TheBlueMatt. The fee tolerance change might be controversial. Not sure anymore, but when i first implemented this, fees had a tiny variance because of signature sizes, etc.
It would be nice if we could fix the fee tolerance in a proper way, although, very precise fees are not the main objective to test during fundrawtransaction rpc tests.
@jonasschnelli I am not changing the behavior of fundrawtransaction. The fee tolerance was already there with
Also, ping @laanwj for input.