http: Restrict maximum size of http + headers #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
force-pushed
the
2015_10_max_http_headers
branch
from
12eb669
to
3ae69de
Compare
|
|
| @@ -414,6 +417,7 @@ bool InitHTTPServer() | |||
| } | |||
|
|
|||
| evhttp_set_timeout(http, GetArg("-rpcservertimeout", DEFAULT_HTTP_SERVER_TIMEOUT)); | |||
| evhttp_set_max_headers_size(http, MAX_HEADERS_SIZE); | |||
There was a problem hiding this comment.
Wait, this PR is only further restricting the headers.
Shouldn't the title be then: "http: Restrict maximum size of headers"
There was a problem hiding this comment.
This should also be restricting the body size, but to something much larger.
Edit: derp it is below!
|
To be precise, it restricts the size of request line + headers, the first part of the request. The body is limited separately (to a much larger size). #6844 should use POST data to submit the transaction, which is not affected by this. |
|
ut ACK - agree "http + headers" in commit msg seemed to imply http body |
Prevent memory exhaustion by sending lots of data. Also add a test to `httpbasics.py`. Closes bitcoin#6425
laanwj
force-pushed
the
2015_10_max_http_headers
branch
from
3ae69de
to
41db8c4
Compare
|
Updated the ocmmit message |
|
utACK
|
|
ACK |
|
utACK |
laanwj
added a commit
that referenced
this pull request
Oct 21, 2015
41db8c4 http: Restrict maximum size of request line + headers (Wladimir J. van der Laan)
sickpig
pushed a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
Mar 12, 2018
HTTP Server cherries from Core: bitcoin/bitcoin#6719 - Make HTTP server shutdown more graceful bitcoin/bitcoin#6859 - http: Restrict maximum size of http + headers bitcoin/bitcoin#6990 - http: speed up shutdown bitcoin/bitcoin#7966 - http: Do a pending c++11 simplification handling work items bitcoin/bitcoin#8421 - httpserver: drop boost (#8023 dependency) bitcoin/bitcoin#11006 - Improve shutdown process
marlengit
pushed a commit
to marlengit/BitcoinUnlimited
that referenced
this pull request
Sep 25, 2018
HTTP Server cherries from Core: bitcoin/bitcoin#6719 - Make HTTP server shutdown more graceful bitcoin/bitcoin#6859 - http: Restrict maximum size of http + headers bitcoin/bitcoin#6990 - http: speed up shutdown bitcoin/bitcoin#7966 - http: Do a pending c++11 simplification handling work items bitcoin/bitcoin#8421 - httpserver: drop boost (#8023 dependency) bitcoin/bitcoin#11006 - Improve shutdown process
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Oct 1, 2020
Small httpserver.cpp backports Also includes a change to the `uiInterface.NotifyBlockTip` signal API. These remove merge conflicts from subsequent backports for `sync.h`. Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6859 - bitcoin/bitcoin#7112 - Only the non-QT changes. - bitcoin/bitcoin#7966 - bitcoin/bitcoin#8421 - We already backported the second commit in #2555
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent memory exhaustion by sending lots of data.
Also add a test to
httpbasics.py.Closes #6425