New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Add maxmempool and effective min fee to getmempoolinfo #6877

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Projects
None yet
6 participants
@laanwj
Member

laanwj commented Oct 23, 2015

I think these can be useful.

Context: lots of these in my log

2015-10-23 06:19:39 b84b52b021d6703dacb85c73b799a232ce6ae1ef7d3a3945c3d2899fc067d642 from peer=7929 was not accepted: mempool min fee not met, 15000 < 20424 (code 66)

Which doesn't give information about the transaction size, so can't reason back to what the effective minfee was.

@laanwj laanwj added the RPC/REST/ZMQ label Oct 23, 2015

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Oct 23, 2015

Member

Makes sense.

Concept ACK

Member

btcdrak commented Oct 23, 2015

Makes sense.

Concept ACK

@TheBlueMatt

View changes

Show outdated Hide outdated src/rpcblockchain.cpp
@@ -772,6 +772,9 @@ UniValue mempoolInfoToJSON()
ret.push_back(Pair("size", (int64_t) mempool.size()));
ret.push_back(Pair("bytes", (int64_t) mempool.GetTotalTxSize()));
ret.push_back(Pair("usage", (int64_t) mempool.DynamicMemoryUsage()));
size_t maxmempool = GetArg("-maxmempool", DEFAULT_MAX_MEMPOOL_SIZE) * 1000000;
ret.push_back(Pair("maxmempool", (int64_t) maxmempool));
ret.push_back(Pair("effectiveminfee", ValueFromAmount(mempool.GetMinFee(maxmempool).GetFeePerK())));

This comment has been minimized.

@TheBlueMatt

TheBlueMatt Oct 23, 2015

Contributor

"effectiveminfee" seems misleading if your GetMinFee() is 0.

@TheBlueMatt

TheBlueMatt Oct 23, 2015

Contributor

"effectiveminfee" seems misleading if your GetMinFee() is 0.

This comment has been minimized.

@laanwj

laanwj Oct 23, 2015

Member

Better suggestions?
Hm maybe just 'minfee' (context is getmempoolinfo, after all) or 'mempoolminfee'. I agree it's not really the effective number used and shouldn't be named that...

@laanwj

laanwj Oct 23, 2015

Member

Better suggestions?
Hm maybe just 'minfee' (context is getmempoolinfo, after all) or 'mempoolminfee'. I agree it's not really the effective number used and shouldn't be named that...

This comment has been minimized.

@TheBlueMatt

TheBlueMatt Oct 24, 2015

Contributor

mempoolminfee?

@TheBlueMatt

TheBlueMatt Oct 24, 2015

Contributor

mempoolminfee?

This comment has been minimized.

@laanwj

laanwj Oct 26, 2015

Member

seems we have two votes for mempoolminfee - changing to that

@laanwj

laanwj Oct 26, 2015

Member

seems we have two votes for mempoolminfee - changing to that

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Oct 23, 2015

Contributor

ACK

Contributor

jgarzik commented Oct 23, 2015

ACK

@laanwj laanwj merged commit 10e2eae into bitcoin:master Oct 26, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

laanwj added a commit that referenced this pull request Oct 26, 2015

Merge pull request #6877
10e2eae rpc: Add maxmempool and effective min fee to getmempoolinfo (Wladimir J. van der Laan)
@@ -772,6 +772,9 @@ UniValue mempoolInfoToJSON()
ret.push_back(Pair("size", (int64_t) mempool.size()));
ret.push_back(Pair("bytes", (int64_t) mempool.GetTotalTxSize()));
ret.push_back(Pair("usage", (int64_t) mempool.DynamicMemoryUsage()));
size_t maxmempool = GetArg("-maxmempool", DEFAULT_MAX_MEMPOOL_SIZE) * 1000000;
ret.push_back(Pair("maxmempool", (int64_t) maxmempool));
ret.push_back(Pair("mempoolminfee", ValueFromAmount(mempool.GetMinFee(maxmempool).GetFeePerK())));

This comment has been minimized.

@MarcoFalke

MarcoFalke Nov 6, 2015

Member

You'd need to update help getmempoolinfo as well.

@MarcoFalke

MarcoFalke Nov 6, 2015

Member

You'd need to update help getmempoolinfo as well.

This comment has been minimized.

@paveljanik

paveljanik Nov 27, 2015

Contributor

Documented in #7118.

@paveljanik

paveljanik Nov 27, 2015

Contributor

Documented in #7118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment