rpc: Add maxmempool and effective min fee to getmempoolinfo - #6877
Merged
Conversation
laanwj
force-pushed
the
2015_10_mempool_effective_fee
branch
from
October 23, 2015 07:56
7915afe to
507f1b5
Compare
Contributor
|
Makes sense. Concept ACK |
Contributor
There was a problem hiding this comment.
"effectiveminfee" seems misleading if your GetMinFee() is 0.
Member
Author
There was a problem hiding this comment.
Better suggestions?
Hm maybe just 'minfee' (context is getmempoolinfo, after all) or 'mempoolminfee'. I agree it's not really the effective number used and shouldn't be named that...
Member
Author
There was a problem hiding this comment.
seems we have two votes for mempoolminfee - changing to that
Contributor
|
ACK |
laanwj
force-pushed
the
2015_10_mempool_effective_fee
branch
from
October 26, 2015 08:59
507f1b5 to
10e2eae
Compare
laanwj
added a commit
that referenced
this pull request
Oct 26, 2015
10e2eae rpc: Add maxmempool and effective min fee to getmempoolinfo (Wladimir J. van der Laan)
Member
There was a problem hiding this comment.
You'd need to update help getmempoolinfo as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think these can be useful.
Context: lots of these in my log
Which doesn't give information about the transaction size, so can't reason back to what the effective minfee was.