Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[qt] Update coin control and smartfee labels #6887
I think most of the pull makes sense, but I'd save removing the AbsurdFee check until we replace it with something better. Having the only effective high fee check be the ATMP check is dicey since that depends on minRelayTxFee which people might be adjusting for other reasons. Also I'm not sure how this is meant to work with #6726. I don't like the idea of having less and less checks for accidental high fees. I just think we should rework them to be better organized.
I agree with @morcos. The absurdfee check is just a belt-and-suspenders check, in case something goes wrong due to a bug in another part of the code. I don't feel good about removing it.