[Tests] Fix BIP65 p2p test #6894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create_coinbase() was being called with the wrong arguments
|
Why did Travis not detect this problem? |
|
It's one of the extended tests, not run by Travis.
|
|
it-works ACK |
laanwj
added a commit
that referenced
this pull request
Oct 29, 2015
3e187f2 Fix BIP65 p2p test (Suhas Daftuar)
|
Tested ACK Gah, I should have caught that. :( |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Nov 18, 2015
create_coinbase() was being called with the wrong arguments Github-Pull: bitcoin#6894 Rebased-From: 3e187f2
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 8, 2016
create_coinbase() was being called with the wrong arguments Github-Pull: bitcoin#6894 Rebased-From: 3e187f2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_coinbase() was being called with the wrong argument