Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix BIP65 p2p test #6894

Merged
merged 1 commit into from Oct 29, 2015
Merged

Conversation

sdaftuar
Copy link
Member

@sdaftuar sdaftuar commented Oct 27, 2015

create_coinbase() was being called with the wrong argument

create_coinbase() was being called with the wrong arguments
@sipa
Copy link
Member

sipa commented Oct 28, 2015

Why did Travis not detect this problem?

@laanwj laanwj added the Tests label Oct 28, 2015
@sdaftuar
Copy link
Member Author

sdaftuar commented Oct 28, 2015

@jgarzik
Copy link
Contributor

jgarzik commented Oct 29, 2015

it-works ACK

@laanwj laanwj merged commit 3e187f2 into bitcoin:master Oct 29, 2015
1 check passed
laanwj added a commit that referenced this issue Oct 29, 2015
3e187f2 Fix BIP65 p2p test (Suhas Daftuar)
@petertodd
Copy link
Contributor

petertodd commented Oct 30, 2015

Tested ACK

Gah, I should have caught that. :(

luke-jr pushed a commit to luke-jr/bitcoin that referenced this issue Nov 18, 2015
create_coinbase() was being called with the wrong arguments

Github-Pull: bitcoin#6894
Rebased-From: 3e187f2
luke-jr pushed a commit to luke-jr/bitcoin that referenced this issue Jan 8, 2016
create_coinbase() was being called with the wrong arguments

Github-Pull: bitcoin#6894
Rebased-From: 3e187f2
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants