New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject invalid pubkeys when reading ckey items from the wallet. #6906

Merged
merged 1 commit into from Oct 30, 2015

Conversation

Projects
None yet
6 participants
@gmaxwell
Member

gmaxwell commented Oct 29, 2015

This makes the behavior more consistent with key objects and will
reject some corrupted pubkeys (e.g. zero length).

Reject invalid pubkeys when reading ckey items from the wallet.
This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Oct 29, 2015

Member

utACK.
Makes sense. LoadCryptedKey() will cast it to a CPubKey object anyways. And the serialization of a CPubKey is equal to a vector<unsigned char> (compact size and the bytestream).

Member

jonasschnelli commented Oct 29, 2015

utACK.
Makes sense. LoadCryptedKey() will cast it to a CPubKey object anyways. And the serialization of a CPubKey is equal to a vector<unsigned char> (compact size and the bytestream).

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Oct 29, 2015

Contributor

utACK

Contributor

dcousens commented Oct 29, 2015

utACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Oct 29, 2015

Member

utACK

Member

MarcoFalke commented Oct 29, 2015

utACK

@instagibbs

This comment has been minimized.

Show comment
Hide comment
@instagibbs

instagibbs Oct 30, 2015

Member

utACK

Member

instagibbs commented Oct 30, 2015

utACK

@laanwj laanwj added the Wallet label Oct 30, 2015

@laanwj laanwj merged commit 30d9662 into bitcoin:master Oct 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Oct 30, 2015

Merge pull request #6906
30d9662 Reject invalid pubkeys when reading ckey items from the wallet. (Gregory Maxwell)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Nov 18, 2015

Reject invalid pubkeys when reading ckey items from the wallet.
This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).

Github-Pull: #6906
Rebased-From: 30d9662

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 8, 2015

Reject invalid pubkeys when reading ckey items from the wallet.
This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).

Github-Pull: #6906
Rebased-From: 30d9662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment