Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject invalid pubkeys when reading ckey items from the wallet. #6906

Merged
merged 1 commit into from Oct 30, 2015

Conversation

@gmaxwell
Copy link
Contributor

gmaxwell commented Oct 29, 2015

This makes the behavior more consistent with key objects and will
reject some corrupted pubkeys (e.g. zero length).

This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).
@jonasschnelli
Copy link
Member

jonasschnelli commented Oct 29, 2015

utACK.
Makes sense. LoadCryptedKey() will cast it to a CPubKey object anyways. And the serialization of a CPubKey is equal to a vector<unsigned char> (compact size and the bytestream).

@dcousens
Copy link
Contributor

dcousens commented Oct 29, 2015

utACK

2 similar comments
@MarcoFalke
Copy link
Member

MarcoFalke commented Oct 29, 2015

utACK

@instagibbs
Copy link
Member

instagibbs commented Oct 30, 2015

utACK

@laanwj laanwj added the Wallet label Oct 30, 2015
@laanwj laanwj merged commit 30d9662 into bitcoin:master Oct 30, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Oct 30, 2015
30d9662 Reject invalid pubkeys when reading ckey items from the wallet. (Gregory Maxwell)
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Nov 18, 2015
This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).

Github-Pull: bitcoin#6906
Rebased-From: 30d9662
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 8, 2015
This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).

Github-Pull: bitcoin#6906
Rebased-From: 30d9662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.