Skip to content

Reject invalid pubkeys when reading ckey items from the wallet.#6906

Merged
laanwj merged 1 commit intobitcoin:masterfrom
gmaxwell:ckey_pubkey_check
Oct 30, 2015
Merged

Reject invalid pubkeys when reading ckey items from the wallet.#6906
laanwj merged 1 commit intobitcoin:masterfrom
gmaxwell:ckey_pubkey_check

Conversation

@gmaxwell
Copy link
Copy Markdown
Contributor

This makes the behavior more consistent with key objects and will
reject some corrupted pubkeys (e.g. zero length).

This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).
@jonasschnelli
Copy link
Copy Markdown
Contributor

utACK.
Makes sense. LoadCryptedKey() will cast it to a CPubKey object anyways. And the serialization of a CPubKey is equal to a vector<unsigned char> (compact size and the bytestream).

@dcousens
Copy link
Copy Markdown
Contributor

utACK

2 similar comments
@maflcko
Copy link
Copy Markdown
Member

maflcko commented Oct 29, 2015

utACK

@instagibbs
Copy link
Copy Markdown
Member

utACK

@laanwj laanwj added the Wallet label Oct 30, 2015
@laanwj laanwj merged commit 30d9662 into bitcoin:master Oct 30, 2015
laanwj added a commit that referenced this pull request Oct 30, 2015
30d9662 Reject invalid pubkeys when reading ckey items from the wallet. (Gregory Maxwell)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Nov 18, 2015
This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).

Github-Pull: bitcoin#6906
Rebased-From: 30d9662
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Dec 8, 2015
This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).

Github-Pull: bitcoin#6906
Rebased-From: 30d9662
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants