Skip to content

/ bitcoin Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restores mempool only BIP113 enforcement #6934

Merged
merged 2 commits into from Nov 5, 2015
Merged

Restores mempool only BIP113 enforcement #6934

merged 2 commits into from Nov 5, 2015

Conversation

@gmaxwell
Copy link
Contributor

@gmaxwell gmaxwell commented Nov 3, 2015

This undoes my prior revert to restore BIP113 (MedianTimePast) mempool only.

After careful analysis and testing I determined that the behavior is, in fact, safe-- I and others were just suffering momentary confusion related to locktime semantics.

The block time must be beyond the tx lock time for the transaction to be included. The MTP is already required to be before the blocktime, so using it instead is strictly more strict.
gmaxwell added 2 commits Nov 3, 2015
@gmaxwell
Restore MedianTimePast for locktime.
e4e5334 
Revert "Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations""
This reverts commit 40cd32e.

After careful analysis it was determined that the change was, in fact, safe and several people were suffering
momentary confusion about locktime semantics.
@gmaxwell
Revert "Revert "Enable policy enforcing GetMedianTimePast as the end …
d1c3762 
…point of lock-time constraints""

This reverts commit 8537ecd.
@gmaxwell gmaxwell changed the title Restores mempool only BIP113 enforces Restores mempool only BIP113 enforcement Nov 4, 2015
@btcdrak
Copy link
Contributor

@btcdrak btcdrak commented Nov 4, 2015

utACK

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Nov 4, 2015

Concept ACK

@laanwj laanwj added the Mempool label Nov 4, 2015
@petertodd
Copy link
Contributor

@petertodd petertodd commented Nov 4, 2015

ACK

2 similar comments
@sipa
Copy link
Member

@sipa sipa commented Nov 4, 2015

ACK

@dcousens
Copy link
Contributor

@dcousens dcousens commented Nov 5, 2015

ACK

@btcdrak btcdrak mentioned this pull request Nov 5, 2015
Merged
@laanwj laanwj merged commit d1c3762 into bitcoin:master Nov 5, 2015
1 check passed
laanwj added a commit that referenced this issue Nov 5, 2015
@laanwj
Merge pull request #6934
3038eb6 
d1c3762 Revert "Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints"" (Gregory Maxwell)
e4e5334 Restore MedianTimePast for locktime. (Gregory Maxwell)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Mempool
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@gmaxwell @btcdrak @luke-jr @petertodd @sipa @dcousens @laanwj