Restores mempool only BIP113 enforcement #6934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes my prior revert to restore BIP113 (MedianTimePast) mempool only.
After careful analysis and testing I determined that the behavior is, in fact, safe-- I and others were just suffering momentary confusion related to locktime semantics.
The block time must be beyond the tx lock time for the transaction to be included. The MTP is already required to be before the blocktime, so using it instead is strictly more strict.