Restores mempool only BIP113 enforcement #6934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations"" This reverts commit 40cd32e. After careful analysis it was determined that the change was, in fact, safe and several people were suffering momentary confusion about locktime semantics.
…point of lock-time constraints"" This reverts commit 8537ecd.
gmaxwell
changed the title
|
utACK |
|
Concept ACK |
|
ACK |
2 similar comments
|
ACK |
|
ACK |
laanwj
added a commit
that referenced
this pull request
Nov 5, 2015
d1c3762 Revert "Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints"" (Gregory Maxwell) e4e5334 Restore MedianTimePast for locktime. (Gregory Maxwell)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes my prior revert to restore BIP113 (MedianTimePast) mempool only.
After careful analysis and testing I determined that the behavior is, in fact, safe-- I and others were just suffering momentary confusion related to locktime semantics.
The block time must be beyond the tx lock time for the transaction to be included. The MTP is already required to be before the blocktime, so using it instead is strictly more strict.