-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] First-draft release notes for 0.11.2RC1 #6968
Conversation
- Revisions to text as proposed by Greg Maxwell - Add Btcdrak to contributors for backporting bitcoin#6884 - Fix spelling mistake [ci skip]
Perhaps it's worth mentioning that a bug which caused frequent database corruption on Windows was fixed? |
Block v4 graphs: http://bitcoin.sipa.be/ver-50k.png and http://bitcoin.sipa.be/ver-2k.png |
@sipa Yea, the leveldb fix change is big news for a lot of people. Unfortunately we don't have the AV robustness (chainstate obfsucation) so we can't say that ALL known common sources of corruption on windows are gone. |
Commit 98d77c5 links to @sipa's graphs and adds a note about the Level DB change to the Notable changes section. |
**Notice to miners:** Bitcoin Core’s block templates are now for | ||
version 4 blocks only, and any mining software relying on its | ||
getblocktemplate must be updated in parallel to use libblkmaker either | ||
version FIXME or any version from FIXME onward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a release version from @luke-jr for libblkmaker and replace FIXME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btcdrak agreed. This is listed in the FIXME checklist at the top of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes more sense. I'll update it. Thanks.
98d77c5
to
a5faaa0
Compare
ACK the BIP65 and BIP113 notes. IMO you did a better job describing the changes then I did in git master; we should probably consider copying your text when we're closer to releasing v0.12.0 |
a5faaa0
to
9149589
Compare
Thanks for doing this! It's a bit unfortunate that #6825 (as well as #6707) doesn't refer to the individual original pull numbers of the backported fixes. This confuses my administration - and referring to a pull like "backport fixes" in the release notes isn't that useful. But we can live with that, better next time.
It's not that I didn't try: #6919. But it was to controversial for a backport apparently. |
@laanwj Indeed, I was mostly pointing out that there is one known common remaining source of corruption for harding's benefit, and not in any way attempting to impugn the incredible work you've done. |
Went ahead and merged this so that there are some release notes in the repository to refer to in my announcement, feel free to improve this later |
@laanwj I can dig up the the original information on the backported fixes. Can you clarify how you usually present that information? For example, if the original PR is 1111, the original commit is
|
what about the FIXME version numbers for libblkmaker? |
@harding Usually there would be no backport PR, as I cherry-pick them straight into the branch. If there is one, and you have the real PR number available, I'd say link that instead of the backport PR. |
FIXMEs:
Please feel free to make any other changes at merge time.
For reference, I generated the commit-level changelog from here: v0.11.1...v0.11.2rc1
And to make sure I didn't miss anything, I documented everything but the merge commits. Here's the complete changelog in the same order as that compare link above. Commits in bold are the ones I omitted from this pull because they didn't seem to affect behavior. (Commits not in bold are included in these notes.)
6707 6af25b0 Add BIP65 to getblockchaininfo softforks list
6945 21e58b8 build: make sure OpenSSL heeds noexecstack
6825 af6edac alias -h for --help
6945 95a5039 Set TCP_NODELAY on P2P sockets.
6884 f720c5f Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints
6917 0af5b8e leveldb: Win32WritableFile without memory mapping
6945 70de437 Update LevelDB
6948 4e895b0 Always flush block and undo when switching to new file