Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always allow getheaders from whitelisted peers #6974

Merged
merged 1 commit into from Nov 11, 2015

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Nov 9, 2015

Process getheaders messages from whitelisted peers even if we are in initial block download. Whitelisted peers can always use a node as a block source.

Also log a debug message when the request is ignored, for troubleshooting.

Addresses #6971.

Process `getheaders` messages from whitelisted peers even if we are in
initial block download. Whitelisted peers can always use a node as a
block source.

Also log a debug message when the request is ignored, for
troubleshooting.

Fixes bitcoin#6971.
@laanwj laanwj added the P2P label Nov 9, 2015
@sdaftuar
Copy link
Member

sdaftuar commented Nov 9, 2015

utACK

1 similar comment
@dcousens
Copy link
Contributor

dcousens commented Nov 9, 2015

utACK

@gmaxwell
Copy link
Contributor

gmaxwell commented Nov 9, 2015

I think this should also whitelist bypass maxuploadtarget-- for the same reason, no?

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Nov 10, 2015

@gmaxwell: Agree with a pass for all whitelisted nodes --maxuploadtarget. I think that should be addresses in another PR (which I will open soon).

@laanwj laanwj merged commit 40b77d4 into bitcoin:master Nov 11, 2015
1 check passed
laanwj added a commit that referenced this issue Nov 11, 2015
40b77d4 Always allow getheaders from whitelisted peers (Wladimir J. van der Laan)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this issue Nov 18, 2015
Process `getheaders` messages from whitelisted peers even if we are in
initial block download. Whitelisted peers can always use a node as a
block source.

Also log a debug message when the request is ignored, for
troubleshooting.

Fixes bitcoin#6971.

Github-Pull: bitcoin#6974
Rebased-From: 40b77d4
rebroad added a commit to rebroad/bitcoin that referenced this issue Nov 2, 2016
An improvement over bitcoin#6172. Fixes bitcoin#6971 rather than bypasses it
as bitcoin#6974 did, and reduces overloading of whitelisting.
zkbot added a commit to zcash/zcash that referenced this issue Feb 18, 2021
Bitcoin 0.12 misc P2P/Net PRs

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#5288
  - Only the reorg, option was removed in bitcoin/bitcoin#6374 which we merged in #1258
- bitcoin/bitcoin#6561
- bitcoin/bitcoin#6728
- bitcoin/bitcoin#6829
- bitcoin/bitcoin#6974
- bitcoin/bitcoin#7075
- bitcoin/bitcoin#7166

Part of #2074.
zkbot added a commit to zcash/zcash that referenced this issue Feb 19, 2021
Bitcoin 0.12 misc P2P/Net PRs

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#5288
  - Only the reorg, option was removed in bitcoin/bitcoin#6374 which we merged in #1258
- bitcoin/bitcoin#6561
- bitcoin/bitcoin#6728
- bitcoin/bitcoin#6829
- bitcoin/bitcoin#6974
- bitcoin/bitcoin#7075
- bitcoin/bitcoin#7166

Part of #2074.
zkbot added a commit to zcash/zcash that referenced this issue Feb 19, 2021
Bitcoin 0.12 misc P2P/Net PRs

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#5288
  - Only the reorg, option was removed in bitcoin/bitcoin#6374 which we merged in #1258
- bitcoin/bitcoin#6561
- bitcoin/bitcoin#6728
- bitcoin/bitcoin#6829
- bitcoin/bitcoin#6974
- bitcoin/bitcoin#7075
- bitcoin/bitcoin#7166

Part of #2074.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants