Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always allow getheaders from whitelisted peers #6974

Merged
merged 1 commit into from Nov 11, 2015

Conversation

@laanwj
Copy link
Member

laanwj commented Nov 9, 2015

Process getheaders messages from whitelisted peers even if we are in initial block download. Whitelisted peers can always use a node as a block source.

Also log a debug message when the request is ignored, for troubleshooting.

Addresses #6971.

Process `getheaders` messages from whitelisted peers even if we are in
initial block download. Whitelisted peers can always use a node as a
block source.

Also log a debug message when the request is ignored, for
troubleshooting.

Fixes #6971.
@laanwj laanwj added the P2P label Nov 9, 2015
@sdaftuar
Copy link
Member

sdaftuar commented Nov 9, 2015

utACK

1 similar comment
@dcousens
Copy link
Contributor

dcousens commented Nov 9, 2015

utACK

@gmaxwell
Copy link
Contributor

gmaxwell commented Nov 9, 2015

I think this should also whitelist bypass maxuploadtarget-- for the same reason, no?

@jonasschnelli
Copy link
Member

jonasschnelli commented Nov 10, 2015

@gmaxwell: Agree with a pass for all whitelisted nodes --maxuploadtarget. I think that should be addresses in another PR (which I will open soon).

@laanwj laanwj merged commit 40b77d4 into bitcoin:master Nov 11, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Nov 11, 2015
40b77d4 Always allow getheaders from whitelisted peers (Wladimir J. van der Laan)
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Nov 18, 2015
Process `getheaders` messages from whitelisted peers even if we are in
initial block download. Whitelisted peers can always use a node as a
block source.

Also log a debug message when the request is ignored, for
troubleshooting.

Fixes bitcoin#6971.

Github-Pull: bitcoin#6974
Rebased-From: 40b77d4
@rebroad

This comment has been minimized.

Copy link
Contributor

rebroad commented on 40b77d4 Oct 12, 2016

This does not "fix" #6971 for most cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.