Always allow getheaders from whitelisted peers #6974

Merged
merged 1 commit into from Nov 11, 2015

Conversation

Projects
None yet
6 participants
@laanwj
Member

laanwj commented Nov 9, 2015

Process getheaders messages from whitelisted peers even if we are in initial block download. Whitelisted peers can always use a node as a block source.

Also log a debug message when the request is ignored, for troubleshooting.

Addresses #6971.

Always allow getheaders from whitelisted peers
Process `getheaders` messages from whitelisted peers even if we are in
initial block download. Whitelisted peers can always use a node as a
block source.

Also log a debug message when the request is ignored, for
troubleshooting.

Fixes #6971.

@laanwj laanwj added the P2P label Nov 9, 2015

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Nov 9, 2015

Member

utACK

Member

sdaftuar commented Nov 9, 2015

utACK

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Nov 9, 2015

Contributor

utACK

Contributor

dcousens commented Nov 9, 2015

utACK

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Nov 9, 2015

Member

I think this should also whitelist bypass maxuploadtarget-- for the same reason, no?

Member

gmaxwell commented Nov 9, 2015

I think this should also whitelist bypass maxuploadtarget-- for the same reason, no?

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Nov 10, 2015

Member

@gmaxwell: Agree with a pass for all whitelisted nodes --maxuploadtarget. I think that should be addresses in another PR (which I will open soon).

Member

jonasschnelli commented Nov 10, 2015

@gmaxwell: Agree with a pass for all whitelisted nodes --maxuploadtarget. I think that should be addresses in another PR (which I will open soon).

@laanwj laanwj merged commit 40b77d4 into bitcoin:master Nov 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Nov 11, 2015

Merge pull request #6974
40b77d4 Always allow getheaders from whitelisted peers (Wladimir J. van der Laan)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Nov 18, 2015

Always allow getheaders from whitelisted peers
Process `getheaders` messages from whitelisted peers even if we are in
initial block download. Whitelisted peers can always use a node as a
block source.

Also log a debug message when the request is ignored, for
troubleshooting.

Fixes #6971.

Github-Pull: #6974
Rebased-From: 40b77d4
@rebroad

This comment has been minimized.

Show comment
Hide comment
@rebroad

rebroad Oct 12, 2016

Contributor

This does not "fix" #6971 for most cases.

Contributor

rebroad commented on 40b77d4 Oct 12, 2016

This does not "fix" #6971 for most cases.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 2, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 2, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 2, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 2, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 2, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 4, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 5, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 5, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 6, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 6, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

rebroad added a commit to rebroad/bitcoin that referenced this pull request Nov 6, 2016

Ignore getheaders prior to passing all checkpoints.
An improvement over #6172. Fixes #6971 rather than bypasses it
as #6974 did, and reduces overloading of whitelisting.

@daira daira referenced this pull request in zcash/zcash Mar 4, 2017

Merged

Bitcoin 0.12 misc PRs 1 #2099

@str4d str4d referenced this pull request in zcash/zcash Mar 4, 2017

Closed

Improvements to getheaders handling #2152

@str4d str4d referenced this pull request in zcash/zcash Jul 14, 2017

Open

Bitcoin 0.12 P2P/Net PRs 1 #2534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment