-
Notifications
You must be signed in to change notification settings - Fork 36.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always allow getheaders from whitelisted peers #6974
Merged
laanwj
merged 1 commit into
bitcoin:master
from
laanwj:2015_11_whitelisted_allow_headers
Nov 11, 2015
Merged
Always allow getheaders from whitelisted peers #6974
laanwj
merged 1 commit into
bitcoin:master
from
laanwj:2015_11_whitelisted_allow_headers
Nov 11, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process `getheaders` messages from whitelisted peers even if we are in initial block download. Whitelisted peers can always use a node as a block source. Also log a debug message when the request is ignored, for troubleshooting. Fixes bitcoin#6971.
utACK |
1 similar comment
utACK |
I think this should also whitelist bypass maxuploadtarget-- for the same reason, no? |
@gmaxwell: Agree with a pass for all whitelisted nodes |
laanwj
added a commit
that referenced
this pull request
Nov 11, 2015
40b77d4 Always allow getheaders from whitelisted peers (Wladimir J. van der Laan)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Nov 18, 2015
Process `getheaders` messages from whitelisted peers even if we are in initial block download. Whitelisted peers can always use a node as a block source. Also log a debug message when the request is ignored, for troubleshooting. Fixes bitcoin#6971. Github-Pull: bitcoin#6974 Rebased-From: 40b77d4
rebroad
added a commit
to rebroad/bitcoin
that referenced
this pull request
Nov 2, 2016
An improvement over bitcoin#6172. Fixes bitcoin#6971 rather than bypasses it as bitcoin#6974 did, and reduces overloading of whitelisting.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 19, 2021
Bitcoin 0.12 misc P2P/Net PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5288 - Only the reorg, option was removed in bitcoin/bitcoin#6374 which we merged in #1258 - bitcoin/bitcoin#6561 - bitcoin/bitcoin#6728 - bitcoin/bitcoin#6829 - bitcoin/bitcoin#6974 - bitcoin/bitcoin#7075 - bitcoin/bitcoin#7166 Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process
getheaders
messages from whitelisted peers even if we are in initial block download. Whitelisted peers can always use a node as a block source.Also log a debug message when the request is ignored, for troubleshooting.
Addresses #6971.