[Qt] simple mempool info in debug window by jonasschnelli · Pull Request #6979 · bitcoin/bitcoin

jonasschnelli · 2015-11-10T12:50:42Z

Having the mempool size in the debug window can be useful.
This PR also moves the "open debug log" button to the right side of the debug window.

The stats gets updated over the same TryLock that is used for the bandwidth graph (no additional blocking is required).

It will ~look like this:

laanwj · 2015-11-10T14:04:00Z

Current number of transactions

laanwj · 2015-11-10T14:04:44Z

Concept ACK

paveljanik · 2015-11-10T14:07:31Z

amount -> number

paveljanik · 2015-11-10T14:10:02Z

Can you please change Mempool in the above screenshot to Memory pool?
Nice. utACK. Will test later.

I'd like to see also the graph of the memory pool - similar to the Network Traffic tab...

jonasschnelli · 2015-11-10T14:15:57Z

@paveljanik: thanks for the review. Yes. The mempool chart is also on my list of things i'd like to do (... and that list is already very large).

fanquake · 2015-11-10T14:19:46Z

conceptACK

jonasschnelli · 2015-11-10T14:33:13Z

Nit's addressed with two squashme commits.

fanquake · 2015-11-10T15:55:27Z

OS X screenshot that includes the latest changes.

sipa · 2015-11-10T15:57:11Z

Random suggestion: under "Block chain", put a " Database cache siE" entry that is pcoinsTip->GetDynamicUsage()" ?

jonasschnelli · 2015-11-10T16:02:01Z

@sipa: good point. But because of the window height (I try not to enlarge), maybe the database cache size fits better in a new "limits" (or "usage") screen/graph. There i could imaging a mempool size/memusage chart as well as the database-cache (chart and current value).

sipa · 2015-11-10T16:03:09Z

Fair enough, keep the pull request as-is then.

maflcko · 2015-11-10T16:15:15Z

I don't like all those MB, MiB inconsistencies. At least make it consistent with the parameter which sets the mempool size. (Which is not MiB iirc)

We should be using MB (1e6 bytes) unless there is a convincing reason to use MiB (2^20 bytes).

Some people refer to 2^20 bytes as "MB", so at least MiB is clear what it does.

But it's used less commonly, so MB is fine as well. Just be consistent, which is what the NIT is complaining about. You can't parse the command line in MB (1e6) and then display MB (10^20)

In bitcoin core we stick to SI units and use MB, which is defined as 1000000, not 1024*1024, MiB, etc if we do that that's a mistake.

Technically, B in SI means bel. B as byte is defined by IEEE 1541 (which also defined b to mean bit).

maflcko · 2015-11-10T16:15:41Z

Looks good, Concept ACK.

paveljanik · 2015-11-10T17:08:01Z

Compile log compared to the master:

+qt/forms/debugwindow.ui: Warning: The name 'label_10' (QLabel) is already in use, defaulting to 'label_101'.
+qt/forms/debugwindow.ui: Warning: The name 'label_3' (QLabel) is already in use, defaulting to 'label_31'.
+qt/forms/debugwindow.ui: Warning: The name 'label_11' (QLabel) is already in use, defaulting to 'label_111'.
+qt/forms/debugwindow.ui: Warning: The name 'label_2' (QLabel) is already in use, defaulting to 'label_21'.
+qt/forms/debugwindow.ui: Warning: The name 'verticalLayout_4' (QVBoxLayout) is already in use, defaulting to 'verticalLayout_41'.
+qt/forms/debugwindow.ui: Warning: The name 'label_21' (QLabel) is already in use, defaulting to 'label_211'.

Mention use of SI units and prefixes. This has always been the case, but make it explicit after discussion in bitcoin#6979.

jonasschnelli · 2015-11-10T19:02:02Z

@paveljanik: these warning are well known and they are unrelated to this PR. Have also plans to fix the qt id/name conflicts (warnings) soon.

jonasschnelli · 2015-11-10T19:10:49Z

Switched to MB / SI units (1000^2 for MB).

paveljanik · 2015-11-10T19:24:18Z

@jonasschnelli I compared the log of the master with the log of the master with this PR. I do not see such warnings in the master builds... I have not investigated from where they come though.

maflcko · 2015-11-10T20:13:23Z

As pointed out by @paveljanik label_11 seems already in use: C.f. $ grep -r 'label_11' src/qt/

Generally speaking: Is it encouraged to use (name)_i++ for references? I'd prefer something like label_memp_whatever.

Right. Agree with that. It was already named label_11 before this PR. The diff looks a bit strange. But i have fixed this now.

jonasschnelli · 2015-11-11T08:12:31Z

Right. There where QT name/id conflicts (some introduced over this PR), although, Qt auto-increments conflicting IDs and because we don't access them through the code, it wouldn't be a problem.
But it's ugly, agreed.

Added a squashme-commit with a fix.

jonasschnelli · 2015-11-18T21:20:53Z

Here are the binaries if someone likes to test this: https://bitcoin.jonasschnelli.ch/pulls/6979/

paveljanik · 2015-11-18T21:39:24Z

Memory usage is continuously updated here, but always ends with .00 KB (on testnet). I have never seen any decimal number there. Do we need these two decimal zeroes?

jonasschnelli · 2015-11-18T21:42:15Z

@paveljanik: if the memory usage is grater than 1000000 bytes it will use "MB" and there the precision of two decimal places make sense IMO.

jonasschnelli · 2015-11-18T22:25:37Z

Fixed the size_t to float conversion. I accidentally dropped the 1000**.0**/1000000**.0** in the arithmetic.

paveljanik · 2015-11-19T08:34:16Z

ACK

paveljanik · 2015-11-19T08:34:46Z

I was wondering how you get the first screenshot 👍

jonasschnelli · 2015-11-19T08:44:53Z

I was wondering how you get the first screenshot

I think somewhere the .0 was lost during implementation of the KB/MB switch logic (and the screenshots was done before that). But this does not explain @fanquake 's screen. ?! Maybe on osx QString::number() does somehow evaluate the division always as float?

paveljanik · 2015-11-19T08:47:45Z

I do not think so (division is evaluated first). Maybe his screenshot is from the same code from which you did the screenshot.

maflcko · 2015-11-19T19:23:07Z

Nit: Isn't this long?

Thanks! Right, .. the map's size() itself is size_t, but the CTxMempool uses long size() in its interface.
Fixed.

maflcko · 2015-11-19T20:00:28Z

utACK c197798

maflcko · 2015-11-20T13:12:13Z

Teseted ACK c197798. Code looks clean.

laanwj · 2015-11-20T13:34:13Z

Tested ACK

c197798 [Qt] simple mempool info in debug window (Jonas Schnelli)

laanwj added the GUI label Nov 10, 2015

laanwj reviewed Nov 10, 2015
View reviewed changes

Comment thread src/qt/forms/debugwindow.ui Outdated

laanwj Nov 10, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current number of transactions

paveljanik reviewed Nov 10, 2015
View reviewed changes

Comment thread src/qt/rpcconsole.h Outdated

paveljanik Nov 10, 2015

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amount -> number

maflcko reviewed Nov 10, 2015
View reviewed changes

laanwj added a commit to laanwj/bitcoin that referenced this pull request Nov 10, 2015

doc: Add note about SI units to developer notes

cf4deb8

Mention use of SI units and prefixes. This has always been the case, but make it explicit after discussion in bitcoin#6979.

laanwj mentioned this pull request Nov 10, 2015

doc: Add note about SI units to developer notes #6981

Closed

maflcko reviewed Nov 10, 2015
View reviewed changes

jonasschnelli force-pushed the 2015/11/qt_mempool_easyinfo branch from 9824fb0 to 3573481 Compare November 11, 2015 08:09

jonasschnelli force-pushed the 2015/11/qt_mempool_easyinfo branch from 3573481 to 67b1393 Compare November 18, 2015 13:26

maflcko mentioned this pull request Nov 18, 2015

MAX_PROTOCOL_MESSAGE_LENGTH description #7055

Closed

jonasschnelli added this to the 0.12.0 milestone Nov 18, 2015

jonasschnelli force-pushed the 2015/11/qt_mempool_easyinfo branch from 67b1393 to 96a0007 Compare November 18, 2015 22:23

jonasschnelli force-pushed the 2015/11/qt_mempool_easyinfo branch from 96a0007 to 7dc0835 Compare November 19, 2015 15:04

maflcko reviewed Nov 19, 2015
View reviewed changes

jonasschnelli force-pushed the 2015/11/qt_mempool_easyinfo branch from 7dc0835 to 70a6ed8 Compare November 19, 2015 19:44

jonasschnelli force-pushed the 2015/11/qt_mempool_easyinfo branch 2 times, most recently from 0243ab8 to 88865f1 Compare November 20, 2015 07:30

[Qt] simple mempool info in debug window

c197798

jonasschnelli force-pushed the 2015/11/qt_mempool_easyinfo branch from 88865f1 to c197798 Compare November 20, 2015 07:40

laanwj merged commit c197798 into bitcoin:master Nov 20, 2015

laanwj added a commit that referenced this pull request Nov 20, 2015

Merge pull request #6979

776848a

c197798 [Qt] simple mempool info in debug window (Jonas Schnelli)

dgenr8 mentioned this pull request Dec 4, 2018

[rpc] Return tx-per-second in getmempoolinfo response bitcoinxt/bitcoinxt#517

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Uh oh!

Conversation

jonasschnelli commented Nov 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj commented Nov 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paveljanik commented Nov 10, 2015

Uh oh!

jonasschnelli commented Nov 10, 2015

Uh oh!

fanquake commented Nov 10, 2015

Uh oh!

jonasschnelli commented Nov 10, 2015

Uh oh!

fanquake commented Nov 10, 2015

Uh oh!

sipa commented Nov 10, 2015 via email

Uh oh!

jonasschnelli commented Nov 10, 2015

Uh oh!

sipa commented Nov 10, 2015 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sipa Nov 10, 2015 via email

Choose a reason for hiding this comment

Uh oh!

maflcko commented Nov 10, 2015

Uh oh!

paveljanik commented Nov 10, 2015

Uh oh!

jonasschnelli commented Nov 10, 2015

Uh oh!

jonasschnelli commented Nov 10, 2015

Uh oh!

paveljanik commented Nov 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Nov 11, 2015

Uh oh!

jonasschnelli commented Nov 18, 2015

Uh oh!

paveljanik commented Nov 18, 2015

Uh oh!

jonasschnelli commented Nov 18, 2015

Uh oh!

jonasschnelli commented Nov 18, 2015

Uh oh!

paveljanik commented Nov 19, 2015

Uh oh!

paveljanik commented Nov 19, 2015

Uh oh!

jonasschnelli commented Nov 19, 2015

Uh oh!

paveljanik commented Nov 19, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko commented Nov 19, 2015

Uh oh!

maflcko commented Nov 20, 2015