add (max)uploadtarget infos to getnettotals RPC help #6999

Merged
merged 1 commit into from Nov 17, 2015

Conversation

Projects
None yet
7 participants
@jonasschnelli
Member

jonasschnelli commented Nov 12, 2015

No description provided.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Nov 12, 2015

Member

utACK

Member

sipa commented Nov 12, 2015

utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Nov 12, 2015

Member

Same sample output to judge the formatting:
bildschirmfoto 2015-11-12 um 14 43 01

Member

jonasschnelli commented Nov 12, 2015

Same sample output to judge the formatting:
bildschirmfoto 2015-11-12 um 14 43 01

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Nov 12, 2015

Contributor

There are two { on uploadtarget line and missing commas after t...

Contributor

paveljanik commented Nov 12, 2015

There are two { on uploadtarget line and missing commas after t...

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Nov 12, 2015

Contributor

Boolean entries are described differently in the other help texts.

Contributor

paveljanik commented Nov 12, 2015

Boolean entries are described differently in the other help texts.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Nov 12, 2015

Member

Thanks for the review.
Fixed the double "{" and the description for the booleans.

Member

jonasschnelli commented Nov 12, 2015

Thanks for the review.
Fixed the double "{" and the description for the booleans.

@jonasschnelli jonasschnelli changed the title from add (max)uploadtarget infos to getnetinfos RPC help to add (max)uploadtarget infos to getnettotals RPC help Nov 12, 2015

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Nov 12, 2015

Contributor

The output here looks like this:

{
  "totalbytesrecv": 7718519,
  "totalbytessent": 56670,
  "timemillis": 1447337892394,
  "uploadtarget": {
    "timeframe": 86400,
    "target": 0,
    "target_reached": false,
    "serve_historical_blocks": true,
    "bytes_left_in_cycle": 0,
    "time_left_in_cycle": 0
  }
}

Please note the position of { in uploadtarget - it is on the same line. Can you move it there also in the helptext?

And this was the last nit.

ACK

Contributor

paveljanik commented Nov 12, 2015

The output here looks like this:

{
  "totalbytesrecv": 7718519,
  "totalbytessent": 56670,
  "timemillis": 1447337892394,
  "uploadtarget": {
    "timeframe": 86400,
    "target": 0,
    "target_reached": false,
    "serve_historical_blocks": true,
    "bytes_left_in_cycle": 0,
    "time_left_in_cycle": 0
  }
}

Please note the position of { in uploadtarget - it is on the same line. Can you move it there also in the helptext?

And this was the last nit.

ACK

@instagibbs

This comment has been minimized.

Show comment
Hide comment
@instagibbs

instagibbs Nov 12, 2015

Member

Would it hurt just to add "bytes" to "target"? aka "targetbytes"
Everything else has bytes in the field name.

nit aside, utACK

Meta-comment: if #6984 gets merged I'd want to know that whitelisted peers existed and I was serving historical blocks to them.

Member

instagibbs commented Nov 12, 2015

Would it hurt just to add "bytes" to "target"? aka "targetbytes"
Everything else has bytes in the field name.

nit aside, utACK

Meta-comment: if #6984 gets merged I'd want to know that whitelisted peers existed and I was serving historical blocks to them.

@laanwj laanwj added the RPC/REST/ZMQ label Nov 13, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Nov 13, 2015

Member

Would it hurt just to add "bytes" to "target"? aka "targetbytes"
Everything else has bytes in the field name.

Hah, yes, we could comment many things on consistency in the RPC interface. Some things have _ separators some have words written together, there are even a few camelCases here and there.

Only if it isn't in a release yet there is still scope for changing it.

@jonasschnelli Thanks for documenting it though - as it is.

Member

laanwj commented Nov 13, 2015

Would it hurt just to add "bytes" to "target"? aka "targetbytes"
Everything else has bytes in the field name.

Hah, yes, we could comment many things on consistency in the RPC interface. Some things have _ separators some have words written together, there are even a few camelCases here and there.

Only if it isn't in a release yet there is still scope for changing it.

@jonasschnelli Thanks for documenting it though - as it is.

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Nov 13, 2015

Member

utACK

Member

gmaxwell commented Nov 13, 2015

utACK

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Nov 17, 2015

Member

ACK.

Member

gmaxwell commented Nov 17, 2015

ACK.

@gmaxwell gmaxwell merged commit f6d9d5e into bitcoin:master Nov 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

gmaxwell added a commit that referenced this pull request Nov 17, 2015

Merge pull request #6999
f6d9d5e add (max)uploadtarget infos to getnettotals RPC help (Jonas Schnelli)
@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Nov 17, 2015

Contributor

ACK

Contributor

dcousens commented Nov 17, 2015

ACK

@str4d str4d referenced this pull request in zcash/zcash Jul 14, 2017

Open

Bitcoin 0.12 P2P/Net PRs 1 #2534

@str4d str4d referenced this pull request in zcash/zcash Dec 19, 2017

Open

Introduce -maxuploadtarget #2816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment