-
Notifications
You must be signed in to change notification settings - Fork 36.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Qt] add shortcurts for debug-/console-window #7000
[Qt] add shortcurts for debug-/console-window #7000
Conversation
utACK |
@@ -364,6 +365,9 @@ void BitcoinGUI::createActions() | |||
connect(openAction, SIGNAL(triggered()), this, SLOT(openClicked())); | |||
} | |||
#endif // ENABLE_WALLET | |||
|
|||
new QShortcut(QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_C), this, SLOT(showDebugWindowActivateConsole())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks weird, allocating a freely-floating object, but I do think it is correct. The object will become a child of *this
, and automatically freed with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. It looks a bit strange. But i think it should compile fine and leaves no men-leak (and requires less code).
But anyway - 7000 is yours! |
BTW - will test on OS X later today - Ctrl key... |
@paveljanik the problem with a parameter for I have testes it on OSX. QT automaps the |
08ed38b
to
3ce79f2
Compare
force push fixed @paveljanik's nits. |
3ce79f2
to
773ae46
Compare
tested ACK |
Binaries if someone likes to test this on Windows or Linux: https://bitcoin.jonasschnelli.ch/pulls/7000/ |
I need this! tested ACK 773ae46 |
Just tested this also on Windows and Linux/Ubuntu. Works. |
773ae46 [Qt] add shortcurts for debug-/console-window (Jonas Schnelli)
Github-Pull: bitcoin#7000 Rebased-From: 773ae46
Why not document this? |
Hah, would be awesome if someone wrote a manual/help function for the GUI in the first place... |
Opening the console- or the debug-window (info tab) seems to be a action that many users do often. This PR adds a shortcut for opening the debug window (
shift-ctrl-D
) and one for showing directly the console (shift-ctrl-C
). Considered to be a undocumented expert feature.