Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fundrawtransaction handling of includeWatching #7010

Merged

Conversation

petertodd
Copy link
Contributor

@petertodd petertodd commented Nov 13, 2015

Previously fundrawtransaction w/ includeWatching set to false was treated as thought it was set to true.

Also better error message for empty output case.

petertodd added 2 commits Nov 13, 2015
Previously if you called fundrawtransaction and set includeWatching to
false it'd act as through you set it to true.
Previously this case failed deep in Cwallet::CreateTransaction() with
the error message "Transaction amounts must be positive"
@kanzure
Copy link
Contributor

kanzure commented Nov 13, 2015

ACK.

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Nov 13, 2015

ACK

1 similar comment
@btcdrak
Copy link
Contributor

btcdrak commented Nov 14, 2015

ACK

@gmaxwell
Copy link
Contributor

gmaxwell commented Nov 14, 2015

ACK.

@gmaxwell gmaxwell merged commit 10953a7 into bitcoin:master Nov 14, 2015
1 check passed
gmaxwell added a commit that referenced this issue Nov 14, 2015
10953a7 Better error message for fundrawtransaction w/ empty vout (Peter Todd)
61e1eb2 Actually use includeWatching value in fundrawtransaction (Peter Todd)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this issue Nov 27, 2015
Previously this case failed deep in Cwallet::CreateTransaction() with
the error message "Transaction amounts must be positive"

Github-Pull: bitcoin#7010
Rebased-From: 10953a7
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants