Fix fundrawtransaction handling of includeWatching #7010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you called fundrawtransaction and set includeWatching to false it'd act as through you set it to true.
Previously this case failed deep in Cwallet::CreateTransaction() with the error message "Transaction amounts must be positive"
|
ACK. |
|
ACK |
1 similar comment
|
ACK |
|
ACK. |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Nov 27, 2015
Previously this case failed deep in Cwallet::CreateTransaction() with the error message "Transaction amounts must be positive" Github-Pull: bitcoin#7010 Rebased-From: 10953a7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously fundrawtransaction w/ includeWatching set to false was treated as thought it was set to true.
Also better error message for empty output case.