Fix fundrawtransaction handling of includeWatching #7010

Merged
merged 2 commits into from Nov 14, 2015

Conversation

Projects
None yet
6 participants
@petertodd
Contributor

petertodd commented Nov 13, 2015

Previously fundrawtransaction w/ includeWatching set to false was treated as thought it was set to true.

Also better error message for empty output case.

petertodd added some commits Nov 13, 2015

Actually use includeWatching value in fundrawtransaction
Previously if you called fundrawtransaction and set includeWatching to
false it'd act as through you set it to true.
Better error message for fundrawtransaction w/ empty vout
Previously this case failed deep in Cwallet::CreateTransaction() with
the error message "Transaction amounts must be positive"
@kanzure

This comment has been minimized.

Show comment
Hide comment
@kanzure

kanzure Nov 13, 2015

Contributor

ACK.

Contributor

kanzure commented Nov 13, 2015

ACK.

@TheBlueMatt

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Nov 13, 2015

Contributor

ACK

Contributor

TheBlueMatt commented Nov 13, 2015

ACK

@paveljanik

This comment has been minimized.

Show comment
Hide comment

utACK

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Nov 14, 2015

Member

ACK

Member

btcdrak commented Nov 14, 2015

ACK

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Nov 14, 2015

Member

ACK.

Member

gmaxwell commented Nov 14, 2015

ACK.

@gmaxwell gmaxwell merged commit 10953a7 into bitcoin:master Nov 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

gmaxwell added a commit that referenced this pull request Nov 14, 2015

Merge pull request #7010
10953a7 Better error message for fundrawtransaction w/ empty vout (Peter Todd)
61e1eb2 Actually use includeWatching value in fundrawtransaction (Peter Todd)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Nov 27, 2015

Better error message for fundrawtransaction w/ empty vout
Previously this case failed deep in Cwallet::CreateTransaction() with
the error message "Transaction amounts must be positive"

Github-Pull: #7010
Rebased-From: 10953a7

@str4d str4d referenced this pull request in zcash/zcash Mar 29, 2017

Open

Bitcoin 0.12 wallet PRs 1 #2225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment