New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LOCK(cs_main) from decodescript #7013

Merged
merged 1 commit into from Nov 14, 2015

Conversation

Projects
None yet
4 participants
@petertodd
Contributor

petertodd commented Nov 13, 2015

Completely static RPC call that doesn't change or even look at mutable state anywhere.

Fixes issue #7012

Remove LOCK(cs_main) from decodescript
Completely static RPC call that doesn't change or even look at mutable
state anywhere.
@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Nov 14, 2015

Member

utACK.

Member

gmaxwell commented Nov 14, 2015

utACK.

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Nov 14, 2015

Contributor

utACK

Contributor

dcousens commented Nov 14, 2015

utACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Nov 14, 2015

Member

Yes, makes sense, woohoo, a RPC call that can support parallelism.
utACK
(this, incidentally, was the longer-term goal of pushing down the RPC locks in #5711)

Member

laanwj commented Nov 14, 2015

Yes, makes sense, woohoo, a RPC call that can support parallelism.
utACK
(this, incidentally, was the longer-term goal of pushing down the RPC locks in #5711)

@laanwj laanwj added the RPC/REST/ZMQ label Nov 14, 2015

@laanwj laanwj merged commit b3ae384 into bitcoin:master Nov 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Nov 14, 2015

Merge pull request #7013
b3ae384 Remove LOCK(cs_main) from decodescript (Peter Todd)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Nov 18, 2015

Remove LOCK(cs_main) from decodescript
Completely static RPC call that doesn't change or even look at mutable
state anywhere.

Github-Pull: #7013
Rebased-From: b3ae384

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 8, 2015

Remove LOCK(cs_main) from decodescript
Completely static RPC call that doesn't change or even look at mutable
state anywhere.

Github-Pull: #7013
Rebased-From: b3ae384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment