New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set osx permissions in the dmg to make Gatekeeper happy #7092

Merged
merged 1 commit into from Nov 25, 2015

Conversation

Projects
None yet
4 participants
@theuni
Member

theuni commented Nov 24, 2015

Fixes #7085.

I can't reproduce the issue on 10.11, so I'll have to wait for someone else to verify. Locally, permissions look ok until added to the image, where 0555 appears to be the default.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Nov 25, 2015

Member

Tested ACK 392d3c5
https://bitcoin.jonasschnelli.ch/pulls/7092/

manpage if someone likes to verify the new argument: http://linux.die.net/man/1/genisoimage

Member

jonasschnelli commented Nov 25, 2015

Tested ACK 392d3c5
https://bitcoin.jonasschnelli.ch/pulls/7092/

manpage if someone likes to verify the new argument: http://linux.die.net/man/1/genisoimage

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Nov 25, 2015

Member

utACK

On Wednesday, November 25, 2015, Jonas Schnelli notifications@github.com
wrote:

Tested ACK 392d3c5
392d3c5
https://bitcoin.jonasschnelli.ch/pulls/7092/

manpage if someone likes to verify the new argument:
http://linux.die.net/man/1/genisoimage


Reply to this email directly or view it on GitHub
#7092 (comment).

Member

fanquake commented Nov 25, 2015

utACK

On Wednesday, November 25, 2015, Jonas Schnelli notifications@github.com
wrote:

Tested ACK 392d3c5
392d3c5
https://bitcoin.jonasschnelli.ch/pulls/7092/

manpage if someone likes to verify the new argument:
http://linux.die.net/man/1/genisoimage


Reply to this email directly or view it on GitHub
#7092 (comment).

@laanwj laanwj merged commit 392d3c5 into bitcoin:master Nov 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Nov 25, 2015

Merge pull request #7092
392d3c5 build: Set osx permissions in the dmg to make Gatekeeper happy (Cory Fields)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Nov 30, 2015

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 8, 2015

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Dec 9, 2015

Member

Needs backport IMO.

Member

jonasschnelli commented Dec 9, 2015

Needs backport IMO.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Dec 9, 2015

Member

@jonasschnelli it's part of #7047 at least

Member

laanwj commented Dec 9, 2015

@jonasschnelli it's part of #7047 at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment