Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scriptnum_test's normative ScriptNum implementation #7095

Merged

Conversation

@laanwj
Copy link
Member

laanwj commented Nov 25, 2015

Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL's BN.

Closes #7086.

@laanwj laanwj added the Tests label Nov 25, 2015
Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL.
Closes #7086.
@laanwj laanwj force-pushed the laanwj:2015_11_remove_openssl_consensus_checks branch to 4ec3561 Nov 25, 2015
@laanwj
Copy link
Member Author

laanwj commented Nov 25, 2015

Right, I didn't update the makefile at all, should pass now.

@theuni
Copy link
Member

theuni commented Nov 25, 2015

ut ACK. I didn't verify that this move-only-ish from 0.10.

@dcousens
Copy link
Contributor

dcousens commented Nov 25, 2015

concept ACK, once-over utACK , doesn't look like a move only. Functions were [at least] re-ordered hence the rename diff wasn't suppressed.

@laanwj
Copy link
Member Author

laanwj commented Nov 26, 2015

not a move only

Strange - I copied CScriptNum10 exactly from the 0.10 branch. The only change should be the comment and rename. There should have been no reordering.

@MarcoFalke
Copy link
Member

MarcoFalke commented Nov 26, 2015

@dcousens
Copy link
Contributor

dcousens commented Nov 27, 2015

taken from the .10 branch.

My fault, I was comparing against the current src/test/bignum.h.
Striked my comment above.

@laanwj laanwj merged commit 4ec3561 into bitcoin:master Nov 27, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Nov 27, 2015
4ec3561 Replace scriptnum_test's normative ScriptNum implementation (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.