Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scriptnum_test's normative ScriptNum implementation #7095

Merged

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Nov 25, 2015

Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL's BN.

Closes #7086.

@laanwj laanwj added the Tests label Nov 25, 2015
Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL.
Closes bitcoin#7086.
@laanwj laanwj force-pushed the 2015_11_remove_openssl_consensus_checks branch from 958a05b to 4ec3561 Compare Nov 25, 2015
@laanwj
Copy link
Member Author

laanwj commented Nov 25, 2015

Right, I didn't update the makefile at all, should pass now.

@theuni
Copy link
Member

theuni commented Nov 25, 2015

ut ACK. I didn't verify that this move-only-ish from 0.10.

@dcousens
Copy link
Contributor

dcousens commented Nov 25, 2015

concept ACK, once-over utACK , doesn't look like a move only. Functions were [at least] re-ordered hence the rename diff wasn't suppressed.

@laanwj
Copy link
Member Author

laanwj commented Nov 26, 2015

not a move only

Strange - I copied CScriptNum10 exactly from the 0.10 branch. The only change should be the comment and rename. There should have been no reordering.

@MarcoFalke
Copy link
Member

MarcoFalke commented Nov 26, 2015

Can confirm all the code in https://github.com/laanwj/bitcoin/blob/4ec3561eb3473638230ef780b41343bc6284b460/src/test/scriptnum10.h is taken from the .10 branch.

@dcousens
Copy link
Contributor

dcousens commented Nov 27, 2015

taken from the .10 branch.

My fault, I was comparing against the current src/test/bignum.h.
Striked my comment above.

@laanwj laanwj merged commit 4ec3561 into bitcoin:master Nov 27, 2015
1 check passed
laanwj added a commit that referenced this issue Nov 27, 2015
4ec3561 Replace scriptnum_test's normative ScriptNum implementation (Wladimir J. van der Laan)
@str4d str4d mentioned this pull request Sep 23, 2020
zkbot added a commit to zcash/zcash that referenced this issue Sep 23, 2020
Remove OpenSSL

Includes changes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7095
- bitcoin/bitcoin#17165
  - Only the commit removing SSL lib detection (we have long since removed the rest).
- bitcoin/bitcoin#17265
  - We had already migrated away from OpenSSL for randomness.
- bitcoin/bitcoin#17515
  - Only the second commit.
zkbot added a commit to zcash/zcash that referenced this issue Sep 29, 2020
Remove OpenSSL

Includes changes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7095
- bitcoin/bitcoin#11024
- bitcoin/bitcoin#17165
  - Only the commit removing SSL lib detection (we have long since removed the rest).
- bitcoin/bitcoin#17265
  - We had already migrated away from OpenSSL for randomness.
- bitcoin/bitcoin#17515
  - Only the second commit.

Closes #145.
zkbot added a commit to zcash/zcash that referenced this issue Oct 1, 2020
Remove OpenSSL

Includes changes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7095
- bitcoin/bitcoin#11024
- bitcoin/bitcoin#17165
  - Only the commit removing SSL lib detection (we have long since removed the rest).
- bitcoin/bitcoin#17265
  - We had already migrated away from OpenSSL for randomness.
- bitcoin/bitcoin#17515
  - Only the second commit.

Closes #145.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants