Replace scriptnum_test's normative ScriptNum implementation #7095

Merged
merged 1 commit into from Nov 27, 2015

Conversation

Projects
None yet
4 participants
@laanwj
Member

laanwj commented Nov 25, 2015

Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL's BN.

Closes #7086.

@laanwj laanwj added the Tests label Nov 25, 2015

Replace scriptnum_test's normative ScriptNum implementation
Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL.
Closes #7086.
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Nov 25, 2015

Member

Right, I didn't update the makefile at all, should pass now.

Member

laanwj commented Nov 25, 2015

Right, I didn't update the makefile at all, should pass now.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Nov 25, 2015

Member

ut ACK. I didn't verify that this move-only-ish from 0.10.

Member

theuni commented Nov 25, 2015

ut ACK. I didn't verify that this move-only-ish from 0.10.

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Nov 25, 2015

Contributor

concept ACK, once-over utACK , doesn't look like a move only. Functions were [at least] re-ordered hence the rename diff wasn't suppressed.

Contributor

dcousens commented Nov 25, 2015

concept ACK, once-over utACK , doesn't look like a move only. Functions were [at least] re-ordered hence the rename diff wasn't suppressed.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Nov 26, 2015

Member

not a move only

Strange - I copied CScriptNum10 exactly from the 0.10 branch. The only change should be the comment and rename. There should have been no reordering.

Member

laanwj commented Nov 26, 2015

not a move only

Strange - I copied CScriptNum10 exactly from the 0.10 branch. The only change should be the comment and rename. There should have been no reordering.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Nov 27, 2015

Contributor

taken from the .10 branch.

My fault, I was comparing against the current src/test/bignum.h.
Striked my comment above.

Contributor

dcousens commented Nov 27, 2015

taken from the .10 branch.

My fault, I was comparing against the current src/test/bignum.h.
Striked my comment above.

@laanwj laanwj merged commit 4ec3561 into bitcoin:master Nov 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Nov 27, 2015

Merge pull request #7095
4ec3561 Replace scriptnum_test's normative ScriptNum implementation (Wladimir J. van der Laan)

@jacobzlogar jacobzlogar referenced this pull request in obsidianproject/Obsidian-Qt Sep 21, 2017

Closed

fails to compile on debian 9.1 #37

@dagurval dagurval referenced this pull request in bitcoinxt/bitcoinxt Apr 5, 2018

Merged

Replace scriptnum_test's normative ScriptNum implementation #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment