Replace scriptnum_test's normative ScriptNum implementation #7095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL. Closes bitcoin#7086.
laanwj
force-pushed
the
2015_11_remove_openssl_consensus_checks
branch
from
958a05b to
4ec3561
Compare
|
Right, I didn't update the makefile at all, should pass now. |
|
ut ACK. I didn't verify that this move-only-ish from 0.10. |
|
concept ACK, once-over utACK |
Strange - I copied CScriptNum10 exactly from the 0.10 branch. The only change should be the comment and rename. There should have been no reordering. |
|
Can confirm all the code in https://github.com/laanwj/bitcoin/blob/4ec3561eb3473638230ef780b41343bc6284b460/src/test/scriptnum10.h is taken from the .10 branch. |
My fault, I was comparing against the current |
laanwj
added a commit
that referenced
this pull request
Nov 27, 2015
4ec3561 Replace scriptnum_test's normative ScriptNum implementation (Wladimir J. van der Laan)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Sep 23, 2020
Remove OpenSSL Includes changes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7095 - bitcoin/bitcoin#17165 - Only the commit removing SSL lib detection (we have long since removed the rest). - bitcoin/bitcoin#17265 - We had already migrated away from OpenSSL for randomness. - bitcoin/bitcoin#17515 - Only the second commit.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Oct 1, 2020
Remove OpenSSL Includes changes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7095 - bitcoin/bitcoin#11024 - bitcoin/bitcoin#17165 - Only the commit removing SSL lib detection (we have long since removed the rest). - bitcoin/bitcoin#17265 - We had already migrated away from OpenSSL for randomness. - bitcoin/bitcoin#17515 - Only the second commit. Closes #145.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL's BN.
Closes #7086.