[Wallet] Improve minimum absolute fee GUI options #7096
Conversation
|
Concept ACK. Haven't looked closely at the code yet.
That's pretty serious. Just curious: when did this break, did this problem make it into any release? |
I try to unroll the bug-history right now. But I'm pretty sure the 0.11er releases are affected because this RPC tests (which tests the buggy behavior) is from the 0.11er branch https://github.com/bitcoin/bitcoin/blob/v0.11.0/qa/rpc-tests/wallet.py#L107). |
|
I think the problem source lays in #5200 ... especially this line was a dangerous change (https://github.com/bitcoin/bitcoin/pull/5200/files#diff-d7618bdc04db23aa74d6a5a4198c58fdR1635) During the subtractFeeFromAmount work we started to take the wrong behavior into RPC tests: #5831 However: this PR needs a backport to 0.11. |
Let's not call it "supersedes". It's an alternative bug fix with a similar result. Someone needs to check if the GUI changes are ok this way. |
|
I think it would be best to split this into two pulls:
At least the former (which is straightforward to test) must be backported to 0.11. |
|
A quick fix was already opened (#6649). This PR would fix the settxfee RPC issue. But, if one uses the PRC together with the GUI, it can result in a wrong behavior. If a user presses the radio button "Use a minimum absolute fee of", suddenly all RPC send commands use the former We could merge and backport 6649 and fix the GUI within this PR. |
|
|
||
| #send a tx with value in a string (PR#6380 +) | ||
| txId = self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), "2") | ||
| txObj = self.nodes[0].gettransaction(txId) | ||
| assert_equal(txObj['amount'], Decimal('-2.00000000')) |
There was a problem hiding this comment.
@jonasschnelli Needs rebase on fa506c0 (#7103)
|
@jonasschnelli Mind to address the rebase "nit"? |
jonasschnelli
force-pushed
the
2015/11/feefix
branch
from
a3a5a14 to
12b9d87
Compare
- Only display the minimum absolute fee control if CoinControl is enabled
jonasschnelli
force-pushed
the
2015/11/feefix
branch
from
12b9d87 to
ff723da
Compare
jonasschnelli
changed the title
|
Rebased and – after #7103 – it's now GUI only. |
|
ACK |
ff723da [Qt] improve minimum absolute fee option - Only display the minimum absolute fee control if CoinControl is enabled (Jonas Schnelli) 31b508a [Qt] make use of the nMinimumTotalFee (absolute) in coincontrols fee calculation (Jonas Schnelli) 80462dd [Qt] use ASYMP_UTF8 (≈) whenever we show a fee that is not absolute (Jonas Schnelli) ecc7c82 Move fPayAtLeastCustomFee function to CC (Pieter Wuille)
Currently,settxfeeRPC call is broken.It is supposed to take a feerate (fee per KB), instead it uses the given feerate as absolute fee. We have even started taking this misconduct into RPC tests (https://github.com/bitcoin/bitcoin/blob/0.11/qa/rpc-tests/wallet.py#L107).(fixed by #7103)This PR fixes the
settxfeeRPC call (by fixing the underlaying problem) and decouples the UI CoinControl function for absolute min. fees from the global wallet state. Absolute fees without actually controlling the amount and type/size of inputs makes no sense and therefore this PR "hides" the absolute minimum fee behind the coin control feature and will only be enabled if the user has manually selected inputs.Includes work from @sipa. Thanks!
Supersedes: #6708Fixes: #6479