Qt: Add network port input box to GUI settings #7107

hsjoberg · 2015-11-26T22:43:16Z

Related issue #7039

tulip0 · 2015-11-27T02:23:17Z

It's counterintuitive to most people that Bitcoin Core will refuse to use non-standard ports as anything but a last resort, does the option label need a GUI label or a confirmation popup to reflect this? I suspect a lot of people will be mystified otherwise that they don't get any incoming connections after changing a fairly innocuous looking option.

jonasschnelli · 2015-11-27T07:52:11Z

src/qt/optionsdialog.cpp

We need a better protection to not run into a startup termination if the user did enter a invalid port. IIRC the QIntValidator still allows one to enter 0 as port number which will very likely result in a locked Bitcoin-QT (startup will stop because of a invalid port). Haven't tested although.
Maybe check: #7025

This should probably see 1-1023 as invalid as well.

@tulip0 That is not universally true. I think Windows allows non-admin to bind them, and on Linux there are capabilities to allow binding them.

jonasschnelli · 2015-11-27T07:57:17Z

Concept ACK.

We just need to make sure, people can only enter reasonable/valid ports. Because if someone enters port 80, bitcoin-qt is very likely "bricked" (unless he start with root permissions!) until he manages to startup Bitcoin-Qt with a override port setting (through a shell with `-port=8333' or by changing bitcoin.conf).

Best would be to ask the user – during startup – if he likes to switch to the standard port if the given port can't be used (permissions or already used through another process).

jonasschnelli · 2015-11-28T08:46:28Z

https://bitcoin.jonasschnelli.ch/pulls/7107/

hsjoberg · 2015-11-28T11:31:59Z

Thanks for the feedback @jonasschnelli, I'll work on the things you pointed out.
I'll be available more and more in #bitcoin #bitcoin-dev etc as cocoBTC.

fanquake · 2015-12-24T10:55:09Z

@cocosoft Are you still working on this?

hsjoberg · 2015-12-26T00:44:02Z

@fanquake Yes, I do intend to continue working on this.

tulip0 · 2015-12-26T02:17:47Z

Again, this needs a warning that users will get essentially no incoming connections if they change the port. It's not initiative behaviour and will cause significant confusion, I'm not convinced that this option should even be in a configuration window like this to begin with.

 // do not allow non-default ports, unless after 50 invalid addresses selected already
if (addr.GetPort() != Params().GetDefaultPort() && nTries < 50)
    continue;

The address rumouring system really can't be used in conjunction with anything but a single static port.

laanwj · 2016-01-28T11:57:21Z

Concept ACK.

Agree that adding a warning (e.g. as mouseover) would make sense, and that ports should be restricted to valid ports (>1024 at least).

hsjoberg · 2016-01-28T12:05:57Z

Just FYI, I am still committed to this issue. I am still alive.

@laanwj, agreed.

luke-jr · 2016-02-12T20:48:33Z

@cocosoft I've addressed the port number concern, and modified NetworkStyle to store regtest settings separately from testnet.

git pull https://github.com/luke-jr/bitcoin.git qtnetworkport

hsjoberg · 2016-02-18T21:56:50Z

@luke-jr, great, thank you for your help!

hsjoberg · 2016-02-18T22:25:07Z

src/qt/optionsmodel.cpp

+            if (settings.value("nNetworkPort") != value) {
+                // If the port input box is empty, set to default port
+                if (value.toString().isEmpty()) {
+                    settings.setValue("nNetworkPort", (quint16)Params().GetDefaultPort());


Maybe I'm mistaken, but won't this code never be reached because of acc8f4e?

You mean because the empty field is invalid input? I suppose so.

jonasschnelli · 2016-02-19T16:03:53Z

Needs rebase.
I could continue this. I think it needs some additional "focus-lost" checks (also see how proxy port settings do work) and I could imaging a problem when setting the port to a port-number that is already in use (could prevent from starting Bitcoin-Qt).

jonasschnelli · 2016-04-05T07:27:22Z

@ping Cocosoft. Are you interested to finish this?

hsjoberg · 2016-04-05T09:08:44Z

@jonasschnelli, I am interested in finishing this. I do understand however if you or someone else wants to take over because it has been idling for so long.

I'll try to be on the IRC channel this week.

laanwj · 2016-04-25T14:10:46Z

I could imaging a problem when setting the port to a port-number that is already in use (could prevent from starting Bitcoin-Qt).

Possibly in the case of the GUI it could be non-fatal if binding a port at startup fails. After warning the user there's no harm in continuing with the port closed.

This would make this change a lot less dangerous.

fanquake · 2016-06-22T10:47:31Z

@cocosoft Are you still planning on finishing this? This needs a rebase at least.

hsjoberg · 2016-06-22T12:55:16Z

@fanquake Yes, I haven't forgotten about this and I still plan to continue, I just need to find time. I fully understand if someone wants to finish it up though, as it has been delayed for so long.

luke-jr · 2016-06-27T21:29:27Z

Why did you add an enableOkButton and disableOkButton methods that are unused?

hsjoberg · 2016-06-27T21:56:01Z

I did not, actually you made them according to Git:

$ git blame -L 227,227 src/qt/optionsdialog.cpp
578064a6 (Luke Dashjr 2016-02-12 20:08:00 +0000 227) void OptionsDialog::enableOkButton()

I'll rebase again and fix that.

Or did you merge the qtnetworkport branch to the master branch of Bitcoinknots? If that's the case, I maybe could just make a new commit removed the unused code.

luke-jr · 2016-06-27T21:57:52Z

That code wasn't part of my commit; somehow it got added in when you rebased. Perhaps an accident during a merge?

hsjoberg · 2016-06-27T22:02:08Z

You're right, sorry. It seems like Philip Kaufman wrote the functions back in 2013:

$ git blame -L 227,227 src/qt/optionsdialog.cpp
7e195e84 (Philip Kaufmann 2013-12-03 09:10:10 +0100 227)     setOkButtonState(false);

hsjoberg · 2016-06-27T22:19:22Z

I'm not sure where the functions come from, I can confirm (by a backup) that they existed before the rebase I did.

I'll remove them.

Edit: Right, I had a merge conflict regarding the functions during the rebase. My bad!

fanquake · 2016-08-31T12:55:12Z

This needs a rebase.

Adds Network port input box to the Network tab in the Options dialog. -port takes priority over the GUI setting. If left blank, it will default to the default port

…e already

Lets you override an argument even if it has already been set, in contrast to SoftSetArg/SoftSetBoolArg.

If the port (specified by -port or GUI setting) is already in use when starting the GUI client, and it's not the standard port, ask the user if they want to listen via the standard network port instead.

hsjoberg · 2016-09-05T22:13:39Z

As per @jonasschnelli suggestion, I added a Question box on startup to ask if the user wants to use the standard network port if the specified port (whether it's from -port or in GUI) is already in use.

jonasschnelli · 2016-09-20T13:37:18Z

Needs rebase and nit fixes.

jonasschnelli · 2016-10-18T19:35:09Z

Closing due to inactivity. Happy to reopen once this has made progress.

Lets you override an argument even if it has already been set, in contrast to SoftSetArg/SoftSetBoolArg. Github-Pull: bitcoin#7107 Rebased-From: f5267bf

If the port (specified by -port or GUI setting) is already in use when starting the GUI client, and it's not the standard port, ask the user if they want to listen via the standard network port instead. Github-Pull: bitcoin#7107 Rebased-From: 1f37c87

Lets you override an argument even if it has already been set, in contrast to SoftSetArg/SoftSetBoolArg. Github-Pull: bitcoin#7107 Rebased-From: f5267bf

If the port (specified by -port or GUI setting) is already in use when starting the GUI client, and it's not the standard port, ask the user if they want to listen via the standard network port instead. Github-Pull: bitcoin#7107 Rebased-From: 1f37c87

hsjoberg · 2017-02-23T00:15:27Z

Hi @jonasschnelli, I've rebased the branch upon master on cocosoft/bitcoin branch qtnetworkport.
I'm not sure what nits are still missing, but I would be happy to fix them.

I added a warning prompt on startup if the user tries to use a non-standard port that is already in use, and gives the option to use the standard port.

Best
Hampus

If the port (specified by -port or GUI setting) is already in use when starting the GUI client, and it's not the standard port, ask the user if they want to listen via the standard network port instead. Github-Pull: bitcoin#7107 Rebased-From: 1f37c87

jonasschnelli reviewed Nov 27, 2015
View reviewed changes

jonasschnelli added the GUI label Nov 27, 2015

laanwj added the Feature label Nov 27, 2015

hsjoberg reviewed Feb 18, 2016
View reviewed changes

hsjoberg force-pushed the qtnetworkport branch from 3d69602 to bbc052a Compare June 26, 2016 15:30

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 28, 2016

Merge bitcoin#7107 qtnetworkport

f9669fc

hsjoberg and others added 6 commits September 3, 2016 14:16

Qt/Options: Adding network port to GUI settings, fixes bitcoin#7039

8b23b2c

Adds Network port input box to the Network tab in the Options dialog. -port takes priority over the GUI setting. If left blank, it will default to the default port

Qt/Options: Avoid changing names of unrelated widgets

fb9083d

Qt/Options: Don't allow setting a port below 1024

4cd0d46

Qt/Options: Actually check validator acceptability for network port

b438458

Qt/Options: Allow an "invalid" network port if it is the current valu…

ccdb3b7

…e already

Qt/NetworkStyle: Use different QSettings for regtest vs testnet

4396a3a

hsjoberg force-pushed the qtnetworkport branch from bbc052a to 4396a3a Compare September 3, 2016 12:28

hsjoberg added 2 commits September 5, 2016 23:30

Adding functions SetArg and SetBoolArg to util.cpp

f5267bf

Lets you override an argument even if it has already been set, in contrast to SoftSetArg/SoftSetBoolArg.

Qt: Ask user to use standard port on startup if specified port is in use

1f37c87

If the port (specified by -port or GUI setting) is already in use when starting the GUI client, and it's not the standard port, ask the user if they want to listen via the standard network port instead.

hsjoberg force-pushed the qtnetworkport branch from a5819d7 to 1f37c87 Compare September 5, 2016 22:11

jonasschnelli closed this Oct 18, 2016

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Qt: Add network port input box to GUI settings #7107

Qt: Add network port input box to GUI settings #7107

Uh oh!

Conversation

hsjoberg commented Nov 26, 2015

Uh oh!

tulip0 commented Nov 27, 2015

Uh oh!

jonasschnelli Nov 27, 2015

Choose a reason for hiding this comment

Uh oh!

tulip0 Nov 27, 2015

Choose a reason for hiding this comment

Uh oh!

luke-jr Nov 27, 2015

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Nov 27, 2015

Uh oh!

jonasschnelli commented Nov 28, 2015

Uh oh!

hsjoberg commented Nov 28, 2015

Uh oh!

fanquake commented Dec 24, 2015

Uh oh!

hsjoberg commented Dec 26, 2015

Uh oh!

tulip0 commented Dec 26, 2015

Uh oh!

laanwj commented Jan 28, 2016

Uh oh!

hsjoberg commented Jan 28, 2016

Uh oh!

luke-jr commented Feb 12, 2016

Uh oh!

hsjoberg commented Feb 18, 2016

Uh oh!

hsjoberg Feb 18, 2016

Choose a reason for hiding this comment

Uh oh!

luke-jr Apr 5, 2016

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Feb 19, 2016

Uh oh!

jonasschnelli commented Apr 5, 2016

Uh oh!

hsjoberg commented Apr 5, 2016

Uh oh!

laanwj commented Apr 25, 2016

Uh oh!

fanquake commented Jun 22, 2016

Uh oh!

hsjoberg commented Jun 22, 2016

Uh oh!

luke-jr commented Jun 27, 2016

Uh oh!

hsjoberg commented Jun 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luke-jr commented Jun 27, 2016

Uh oh!

hsjoberg commented Jun 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hsjoberg commented Jun 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanquake commented Aug 31, 2016

Uh oh!

hsjoberg commented Sep 5, 2016

Uh oh!

jonasschnelli commented Sep 20, 2016

Uh oh!

jonasschnelli commented Oct 18, 2016

Uh oh!

hsjoberg commented Feb 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

hsjoberg commented Jun 27, 2016 •

edited

Loading

hsjoberg commented Jun 27, 2016 •

edited

Loading

hsjoberg commented Jun 27, 2016 •

edited

Loading

hsjoberg commented Feb 23, 2017 •

edited

Loading