Qt: Add network port input box to GUI settings #7107

Cocosoft · Nov 26, 2015

Related issue #7039

tulip0 · Nov 27, 2015

It's counterintuitive to most people that Bitcoin Core will refuse to use non-standard ports as anything but a last resort, does the option label need a GUI label or a confirmation popup to reflect this? I suspect a lot of people will be mystified otherwise that they don't get any incoming connections after changing a fairly innocuous looking option.

We need a better protection to not run into a startup termination if the user did enter a invalid port. IIRC the QIntValidator still allows one to enter 0 as port number which will very likely result in a locked Bitcoin-QT (startup will stop because of a invalid port). Haven't tested although.
Maybe check: #7025

This should probably see 1-1023 as invalid as well.

@tulip0 That is not universally true. I think Windows allows non-admin to bind them, and on Linux there are capabilities to allow binding them.

jonasschnelli · Nov 27, 2015

Concept ACK.

We just need to make sure, people can only enter reasonable/valid ports. Because if someone enters port 80, bitcoin-qt is very likely "bricked" (unless he start with root permissions!) until he manages to startup Bitcoin-Qt with a override port setting (through a shell with `-port=8333' or by changing bitcoin.conf).

Best would be to ask the user – during startup – if he likes to switch to the standard port if the given port can't be used (permissions or already used through another process).

jonasschnelli · Nov 28, 2015

https://bitcoin.jonasschnelli.ch/pulls/7107/

Cocosoft · Nov 28, 2015

Thanks for the feedback @jonasschnelli, I'll work on the things you pointed out.
I'll be available more and more in #bitcoin #bitcoin-dev etc as cocoBTC.

fanquake · Dec 24, 2015

@Cocosoft Are you still working on this?

Cocosoft · Dec 26, 2015

@fanquake Yes, I do intend to continue working on this.

tulip0 · Dec 26, 2015

Again, this needs a warning that users will get essentially no incoming connections if they change the port. It's not initiative behaviour and will cause significant confusion, I'm not convinced that this option should even be in a configuration window like this to begin with.

 // do not allow non-default ports, unless after 50 invalid addresses selected already
if (addr.GetPort() != Params().GetDefaultPort() && nTries < 50)
    continue;

The address rumouring system really can't be used in conjunction with anything but a single static port.

laanwj · Jan 28, 2016

Concept ACK.

Agree that adding a warning (e.g. as mouseover) would make sense, and that ports should be restricted to valid ports (>1024 at least).

Cocosoft · Jan 28, 2016

Just FYI, I am still committed to this issue. I am still alive.

@laanwj, agreed.

luke-jr · Feb 12, 2016

@Cocosoft I've addressed the port number concern, and modified NetworkStyle to store regtest settings separately from testnet.

git pull https://github.com/luke-jr/bitcoin.git qtnetworkport

Cocosoft · Feb 18, 2016

@luke-jr, great, thank you for your help!

Maybe I'm mistaken, but won't this code never be reached because of acc8f4e?

You mean because the empty field is invalid input? I suppose so.

jonasschnelli · Feb 19, 2016

Needs rebase.
I could continue this. I think it needs some additional "focus-lost" checks (also see how proxy port settings do work) and I could imaging a problem when setting the port to a port-number that is already in use (could prevent from starting Bitcoin-Qt).

jonasschnelli · Apr 5, 2016

@ping Cocosoft. Are you interested to finish this?

Cocosoft · Apr 5, 2016

@jonasschnelli, I am interested in finishing this. I do understand however if you or someone else wants to take over because it has been idling for so long.

I'll try to be on the IRC channel this week.

laanwj · Apr 25, 2016

I could imaging a problem when setting the port to a port-number that is already in use (could prevent from starting Bitcoin-Qt).

Possibly in the case of the GUI it could be non-fatal if binding a port at startup fails. After warning the user there's no harm in continuing with the port closed.

This would make this change a lot less dangerous.

fanquake · Jun 22, 2016

@Cocosoft Are you still planning on finishing this? This needs a rebase at least.

Cocosoft · Jun 22, 2016

@fanquake Yes, I haven't forgotten about this and I still plan to continue, I just need to find time. I fully understand if someone wants to finish it up though, as it has been delayed for so long.

luke-jr · Jun 27, 2016

Why did you add an enableOkButton and disableOkButton methods that are unused?

Cocosoft · Jun 27, 2016

I did not, actually you made them according to Git:

$ git blame -L 227,227 src/qt/optionsdialog.cpp
578064a6 (Luke Dashjr 2016-02-12 20:08:00 +0000 227) void OptionsDialog::enableOkButton()

I'll rebase again and fix that.

Or did you merge the qtnetworkport branch to the master branch of Bitcoinknots? If that's the case, I maybe could just make a new commit removed the unused code.

luke-jr · Jun 27, 2016

That code wasn't part of my commit; somehow it got added in when you rebased. Perhaps an accident during a merge?

Cocosoft · Jun 27, 2016

You're right, sorry. It seems like Philip Kaufman wrote the functions back in 2013:

$ git blame -L 227,227 src/qt/optionsdialog.cpp
7e195e84 (Philip Kaufmann 2013-12-03 09:10:10 +0100 227)     setOkButtonState(false);

Cocosoft · Jun 27, 2016

I'm not sure where the functions come from, I can confirm (by a backup) that they existed before the rebase I did.

I'll remove them.

Edit: Right, I had a merge conflict regarding the functions during the rebase. My bad!

fanquake · Aug 31, 2016

This needs a rebase.

Cocosoft · Sep 5, 2016

As per @jonasschnelli suggestion, I added a Question box on startup to ask if the user wants to use the standard network port if the specified port (whether it's from -port or in GUI) is already in use.

jonasschnelli · Sep 20, 2016

Needs rebase and nit fixes.

jonasschnelli · Oct 18, 2016

Closing due to inactivity. Happy to reopen once this has made progress.

Cocosoft · Feb 23, 2017

Hi @jonasschnelli, I've rebased the branch upon master on cocosoft/bitcoin branch qtnetworkport.
I'm not sure what nits are still missing, but I would be happy to fix them.

I added a warning prompt on startup if the user tries to use a non-standard port that is already in use, and gives the option to use the standard port.

Best
Hampus

jonasschnelli added the GUI label Nov 27, 2015

laanwj added the Feature label Nov 27, 2015

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 28, 2016

Merge #7107 qtnetworkport

f9669fc

jonasschnelli closed this Oct 18, 2016

@@ -45,6 +45,8 @@ OptionsDialog::OptionsDialog(QWidget *parent, bool enableWallet) :
          ui->threadsScriptVerif->setMinimum(-GetNumCores());
          ui->threadsScriptVerif->setMaximum(MAX_SCRIPTCHECK_THREADS);
+    +    ui->networkPort->setValidator(new QIntValidator(1, 65535, this));

@@ -246,6 +254,18 @@ bool OptionsModel::setData(const QModelIndex & index, const QVariant & value, in
                  fMinimizeToTray = value.toBool();
                  settings.setValue("fMinimizeToTray", fMinimizeToTray);
                  break;
+    +        case NetworkPort:
+    +            if (settings.value("nNetworkPort") != value) {
+    +                // If the port input box is empty, set to default port
+    +                if (value.toString().isEmpty()) {
+    +                    settings.setValue("nNetworkPort", (quint16)Params().GetDefaultPort());

bitcoin/bitcoin

Join GitHub today

Qt: Add network port input box to GUI settings #7107

Conversation

Cocosoft commented Nov 26, 2015

tulip0 commented Nov 27, 2015

Show 3 comments Hide comments jonasschnelli and 2 others commented on an outdated diff Nov 27, 2015

jonasschnelli Nov 27, 2015

tulip0 Nov 27, 2015

luke-jr Nov 27, 2015

jonasschnelli added the GUI label Nov 27, 2015

jonasschnelli commented Nov 27, 2015

laanwj added the Feature label Nov 27, 2015

jonasschnelli commented Nov 28, 2015

Cocosoft commented Nov 28, 2015

fanquake commented Dec 24, 2015

Cocosoft commented Dec 26, 2015

tulip0 commented Dec 26, 2015

laanwj commented Jan 28, 2016

Cocosoft commented Jan 28, 2016

luke-jr commented Feb 12, 2016

Cocosoft commented Feb 18, 2016

Cocosoft commented on the diff Feb 18, 2016

Cocosoft Feb 18, 2016

luke-jr Apr 5, 2016

jonasschnelli commented Feb 19, 2016

jonasschnelli commented Apr 5, 2016

Cocosoft commented Apr 5, 2016

laanwj commented Apr 25, 2016

fanquake commented Jun 22, 2016

Cocosoft commented Jun 22, 2016

luke-jr commented Jun 27, 2016

Cocosoft commented Jun 27, 2016 • edited Edited 1 time Cocosoft Jun 27, 2016

luke-jr commented Jun 27, 2016

Cocosoft commented Jun 27, 2016 • edited Edited 1 time Cocosoft Jun 27, 2016

Cocosoft commented Jun 27, 2016 • edited Edited 1 time Cocosoft Jun 27, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 28, 2016

fanquake commented Aug 31, 2016

Cocosoft and others added some commits Nov 26, 2015

Cocosoft commented Sep 5, 2016

jonasschnelli commented Sep 20, 2016

jonasschnelli commented Oct 18, 2016

jonasschnelli closed this Oct 18, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 18, 2017

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 18, 2017

Cocosoft commented Feb 23, 2017 • edited Edited 1 time Cocosoft Feb 23, 2017

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Aug 27, 2017

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Aug 29, 2017

jonasschnelli and 2 others commented on an outdated diff Nov 27, 2015

Cocosoft commented Jun 27, 2016 •

Edited 1 time

Cocosoft
Jun 27, 2016

Cocosoft commented Jun 27, 2016 •

Edited 1 time

Cocosoft
Jun 27, 2016

Cocosoft commented Jun 27, 2016 •

Edited 1 time

Cocosoft
Jun 27, 2016

Cocosoft commented Feb 23, 2017 •

Edited 1 time

Cocosoft
Feb 23, 2017