Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct headers announcement (rebase of #6494) #7129

Merged
merged 2 commits into from Nov 29, 2015

Conversation

sipa
Copy link
Member

@sipa sipa commented Nov 29, 2015

This is a rebase of #6494, with one line (which @sdaftuar commented he forgot to remove) deleted.

It also adds a commit to add the change to the bips document and the release notes.

sdaftuar and others added 2 commits Nov 29, 2015
This replaces using inv messages to announce new blocks, when a peer requests
(via the new "sendheaders" message) that blocks be announced with headers
instead of inv's.

Since headers-first was introduced, peers send getheaders messages in response
to an inv, which requires generating a block locator that is large compared to
the size of the header being requested, and requires an extra round-trip before
a reorg can be relayed.  Save time by tracking headers that a peer is likely to
know about, and send a headers chain that would connect to a peer's known
headers, unless the chain would be too big, in which case we revert to sending
an inv instead.

Based off of @sipa's commit to announce all blocks in a reorg via inv,
which has been squashed into this commit.

Rebased-by: Pieter Wuille
@gmaxwell
Copy link
Contributor

gmaxwell commented Nov 29, 2015

DOC ACK.

@sipa sipa merged commit 49fb8e8 into bitcoin:master Nov 29, 2015
1 check passed
sipa added a commit that referenced this issue Nov 29, 2015
49fb8e8 Documentation updates for BIP 130 (Pieter Wuille)
50262d8 Allow block announcements with headers (Suhas Daftuar)
snogcel referenced this issue in snogcel/bitcore-p2p-dash Aug 11, 2016
zkbot added a commit to zcash/zcash that referenced this issue Feb 22, 2021
Replace setInventoryKnown with a rolling bloom filter

Cherry-picked from bitcoin/bitcoin#7133.
- Excluding for last commit, which needs bitcoin/bitcoin#7129.

Part of #2074.
zkbot added a commit to zcash/zcash that referenced this issue Mar 5, 2021
Replace setInventoryKnown with a rolling bloom filter

Cherry-picked from bitcoin/bitcoin#7133.
- Excluding for last commit, which needs bitcoin/bitcoin#7129.

Part of #2074.
str4d pushed a commit to str4d/zcash that referenced this issue Aug 13, 2021
filterInventoryKnown is only used when relaying transactions,
so stop adding block hashes to the filter.

(cherry picked from commit bitcoin/bitcoin@383fc10)

Zcash: Excludes comment change, as bitcoin/bitcoin#7129 has not been
backported  yet.
str4d pushed a commit to str4d/zcash that referenced this issue Aug 13, 2021
filterInventoryKnown is only used when relaying transactions,
so stop adding block hashes to the filter.

(cherry picked from commit bitcoin/bitcoin@383fc10)

Zcash: Excludes comment change, as bitcoin/bitcoin#7129 has not been
backported  yet.
zkbot added a commit to zcash/zcash that referenced this issue Aug 13, 2021
Bitcoin 0.12 P2P/Net PRs 1

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7129
  - Zcash equivalent of BIP 130
- bitcoin/bitcoin#7133
  - Just the last commit (the rest is in #4997)
- bitcoin/bitcoin#7482

Part of #2074.
str4d pushed a commit to str4d/zcash that referenced this issue Aug 13, 2021
filterInventoryKnown is only used when relaying transactions,
so stop adding block hashes to the filter.

(cherry picked from commit bitcoin/bitcoin@383fc10)

Zcash: Excludes comment change, as bitcoin/bitcoin#7129 has not been
backported  yet.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants