Direct headers announcement (rebase of #6494) #7129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces using inv messages to announce new blocks, when a peer requests (via the new "sendheaders" message) that blocks be announced with headers instead of inv's. Since headers-first was introduced, peers send getheaders messages in response to an inv, which requires generating a block locator that is large compared to the size of the header being requested, and requires an extra round-trip before a reorg can be relayed. Save time by tracking headers that a peer is likely to know about, and send a headers chain that would connect to a peer's known headers, unless the chain would be too big, in which case we revert to sending an inv instead. Based off of @sipa's commit to announce all blocks in a reorg via inv, which has been squashed into this commit. Rebased-by: Pieter Wuille
|
DOC ACK. |
snogcel
referenced
this pull request
in snogcel/bitcore-p2p-dash
Aug 11, 2016
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 22, 2021
Replace setInventoryKnown with a rolling bloom filter Cherry-picked from bitcoin/bitcoin#7133. - Excluding for last commit, which needs bitcoin/bitcoin#7129. Part of #2074.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 5, 2021
Replace setInventoryKnown with a rolling bloom filter Cherry-picked from bitcoin/bitcoin#7133. - Excluding for last commit, which needs bitcoin/bitcoin#7129. Part of #2074.
str4d
pushed a commit
to str4d/zcash
that referenced
this pull request
Aug 13, 2021
filterInventoryKnown is only used when relaying transactions, so stop adding block hashes to the filter. (cherry picked from commit bitcoin/bitcoin@383fc10) Zcash: Excludes comment change, as bitcoin/bitcoin#7129 has not been backported yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #6494, with one line (which @sdaftuar commented he forgot to remove) deleted.
It also adds a commit to add the change to the bips document and the release notes.