Direct headers announcement (rebase of #6494) #7129

Merged
merged 2 commits into from Nov 29, 2015

Conversation

Projects
None yet
3 participants
@sipa
Member

sipa commented Nov 29, 2015

This is a rebase of #6494, with one line (which @sdaftuar commented he forgot to remove) deleted.

It also adds a commit to add the change to the bips document and the release notes.

sdaftuar and others added some commits Nov 18, 2014

Allow block announcements with headers
This replaces using inv messages to announce new blocks, when a peer requests
(via the new "sendheaders" message) that blocks be announced with headers
instead of inv's.

Since headers-first was introduced, peers send getheaders messages in response
to an inv, which requires generating a block locator that is large compared to
the size of the header being requested, and requires an extra round-trip before
a reorg can be relayed.  Save time by tracking headers that a peer is likely to
know about, and send a headers chain that would connect to a peer's known
headers, unless the chain would be too big, in which case we revert to sending
an inv instead.

Based off of @sipa's commit to announce all blocks in a reorg via inv,
which has been squashed into this commit.

Rebased-by: Pieter Wuille
@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Nov 29, 2015

Member

DOC ACK.

Member

gmaxwell commented Nov 29, 2015

DOC ACK.

@sipa sipa merged commit 49fb8e8 into bitcoin:master Nov 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request Nov 29, 2015

Merge pull request #7129
49fb8e8 Documentation updates for BIP 130 (Pieter Wuille)
50262d8 Allow block announcements with headers (Suhas Daftuar)

@dgenr8 dgenr8 referenced this pull request in bitcoinxt/bitcoinxt Mar 20, 2016

Closed

[WIP] Direct headers announcement #137

snogcel referenced this pull request in snogcel/bitcore-p2p-dash Aug 11, 2016

@str4d str4d referenced this pull request in zcash/zcash Jul 14, 2017

Open

Bitcoin 0.12 P2P/Net PRs 1 #2534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment