Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Don't translate warning messages #7141

Merged
merged 1 commit into from Dec 1, 2015

Conversation

@laanwj
Copy link
Member

laanwj commented Dec 1, 2015

But keep translating them in the GUI.
This - necessarily - requires duplication of a few messages. This would allow using different messages in GUI and RPC, but keep them the same for now.
Alternative take on #7134, that keeps the translations from being wiped.

Also document GetWarnings() input argument.

@laanwj laanwj added the GUI label Dec 1, 2015
@laanwj laanwj force-pushed the laanwj:2015_12_warnings_translations branch Dec 1, 2015
But keep translating them in the GUI.
This - necessarily - requires duplication of a few messages.
Alternative take on #7134, that keeps the translations from being wiped.

Also document GetWarnings() input argument.

Fixes #5895.
@laanwj laanwj force-pushed the laanwj:2015_12_warnings_translations branch to aabc897 Dec 1, 2015
@jonasschnelli
Copy link
Member

jonasschnelli commented Dec 1, 2015

Nice! This is the right way to do it.
utACK.

@MarcoFalke
Copy link
Member

MarcoFalke commented Dec 1, 2015

utACK aabc897

@laanwj laanwj merged commit aabc897 into bitcoin:master Dec 1, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Dec 1, 2015
aabc897 rpc: Don't translate warning messages (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.