New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Correctly calculate priority when inputs are mined after dependent transactions enter the memory pool #7149

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
5 participants
@luke-jr
Member

luke-jr commented Dec 1, 2015

This is needed to restore proper CreateNewBlock functioning for unconfirmed transaction chains.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jan 13, 2016

Member

Added RPC tests and fixed an additional bug found with them. This should now be ready for merging to master and 0.12.

Member

luke-jr commented Jan 13, 2016

Added RPC tests and fixed an additional bug found with them. This should now be ready for merging to master and 0.12.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 2, 2016

Member

Weak concept NACK. I don't think we should be spending effort on maintaining the old priority system (which was completely arbirary anyway).

Member

sipa commented Jun 2, 2016

Weak concept NACK. I don't think we should be spending effort on maintaining the old priority system (which was completely arbirary anyway).

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 9, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 27, 2016

morcos and others added some commits Jun 30, 2015

Change GetPriority calculation to dynamically update
Track the value of inputs that get confirmed in the chain and keep a cached value of priority at a given height and return current priority by only assuming these in chain inputs are aging.
Bugfix: Correct off-by-one errors in getrawmempool startingpriority a…
…nd currentpriority

- Since the transaction arrives after block N, its starting priority is that for block N+1.
- The current priority is likewise as considered for mining the next block.
Bugfix: rpc-tests/txn_priority: When connecting disconnected nodes, t…
…heir mempools may not sync, so only sync blocks
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jan 12, 2017

Member

Closing this due to inactivity.

Member

fanquake commented Jan 12, 2017

Closing this due to inactivity.

@fanquake fanquake closed this Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment