New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] add InMempool() info to transaction details #7154

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
5 participants
@jonasschnelli
Member

jonasschnelli commented Dec 2, 2015

Adds the information if a transaction is in the mempool, in case it has 0 confirmations.

@jonasschnelli jonasschnelli added the GUI label Dec 2, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Dec 2, 2015

Member

Concept ACK

Member

laanwj commented Dec 2, 2015

Concept ACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Dec 8, 2015

utACK a3c3ddb

@GIJensen

This comment has been minimized.

Show comment
Hide comment
@GIJensen

GIJensen Dec 9, 2015

ACK a3c3ddb, thorough code review, and passed test_bitcoin.

GIJensen commented Dec 9, 2015

ACK a3c3ddb, thorough code review, and passed test_bitcoin.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Dec 9, 2015

Member

passed test_bitcoin.

@GIJensen Travis already does this. If you test locally, you may also check in the GUI if the change looks good. (And post a screenshot if appropriate)

Member

MarcoFalke commented Dec 9, 2015

passed test_bitcoin.

@GIJensen Travis already does this. If you test locally, you may also check in the GUI if the change looks good. (And post a screenshot if appropriate)

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Dec 9, 2015

Member

Started a gitian build in case someone needs binaries to test this: https://bitcoin.jonasschnelli.ch/pulls/7154/

Member

jonasschnelli commented Dec 9, 2015

Started a gitian build in case someone needs binaries to test this: https://bitcoin.jonasschnelli.ch/pulls/7154/

@jonasschnelli jonasschnelli added this to the 0.13.0 milestone Dec 9, 2015

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake
Member

fanquake commented Dec 9, 2015

utACK a3c3ddb

@laanwj laanwj merged commit a3c3ddb into bitcoin:master Dec 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 9, 2015

Merge pull request #7154
a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

morcos added a commit to morcos/bitcoin that referenced this pull request Jan 13, 2016

add InMempool() function
Github-Pull: #7154
Partial verison of commit: a3c3ddb

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 28, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 5, 2017

Merge pull request #7154
a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 7, 2017

Backport Bitcoin Qt/Gui changes up to 0.14.x part 1 (#1614)
* Merge pull request #7154

a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

* Merge pull request #7218

fa5769e [qt] Fix misleading translation (MarcoFalke)
fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)

* Merge pull request #7255

6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

* Merge pull request #7263

a5a0831 Double semicolon cleanup. (21E14)

* Merge pull request #7334

fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)

* Merge pull request #7329

9d263bd Typo fixes in comments (Chris Wheeler)

* Merge #7396: [Qt] Add option to increase/decrease font size in the console window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)

* Merge #7628: QT: Add 'copy full transaction details' option

b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw)

* Merge #7668: Fix history deletion bug after font size change

21e45a0 Fix history deletion bug after font change (Andrew C)

* Copy/Move font size related icons into theme folders

* Use formatTxDate for date/time in TxPlainTextRole
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment