New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: remove cs_main lock from `createrawtransaction` #7156

Merged
merged 1 commit into from Dec 11, 2015

Conversation

Projects
None yet
7 participants
@laanwj
Member

laanwj commented Dec 2, 2015

Continues work to remove/push down RPC locks from #7013.
createrawtransaction is a pure utility function that doesn't use main's data structures, so it does not require that lock.

Despite being a one-line change, needs to be reviewed carefully. Although I didn't find any, there may be unguarded use of main data structures deeper in the call chain. Not meant for 0.12

rpc: remove cs_main lock from `createrawtransaction`
This is a pure utility function that doesn't use
main's data structures, so it does not require that lock.

@laanwj laanwj added the RPC/REST/ZMQ label Dec 2, 2015

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Dec 2, 2015

Member

Code Review utACK. Can't find any unguarded deeper structure either.

Member

jonasschnelli commented Dec 2, 2015

Code Review utACK. Can't find any unguarded deeper structure either.

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Dec 2, 2015

Contributor

ACK

Contributor

jgarzik commented Dec 2, 2015

ACK

@jtimon

This comment has been minimized.

Show comment
Hide comment
@jtimon

jtimon Dec 4, 2015

Member

createrawtransaction() doesn't use any non-local variable and its parameters const UniValue& params, bool fHelp are both cs_main-safe.
I don't need to test this.
ACK

Member

jtimon commented Dec 4, 2015

createrawtransaction() doesn't use any non-local variable and its parameters const UniValue& params, bool fHelp are both cs_main-safe.
I don't need to test this.
ACK

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Dec 4, 2015

Contributor

utACK

I couldn't find any unguarded paths.

Contributor

dcousens commented Dec 4, 2015

utACK

I couldn't find any unguarded paths.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Dec 5, 2015

Contributor

ACK

Contributor

paveljanik commented Dec 5, 2015

ACK

@instagibbs

This comment has been minimized.

Show comment
Hide comment
@instagibbs

instagibbs Dec 8, 2015

Member

utACK

Member

instagibbs commented Dec 8, 2015

utACK

@laanwj laanwj merged commit 6e76587 into bitcoin:master Dec 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 11, 2015

Merge pull request #7156
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 28, 2015

rpc: remove cs_main lock from `createrawtransaction`
This is a pure utility function that doesn't use
main's data structures, so it does not require that lock.

Github-Pull: #7156
Rebased-From: 6e76587

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 28, 2015

rpc: remove cs_main lock from `createrawtransaction`
This is a pure utility function that doesn't use
main's data structures, so it does not require that lock.

Github-Pull: #7156
Rebased-From: 6e76587

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 9, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 26, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge pull request #7156
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge pull request #7156
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge pull request #7156
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge pull request #7156
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment