/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

rpc: remove cs_main lock from `createrawtransaction` #7156

Merged
merged 1 commit into from Dec 11, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
7 participants
@laanwj @jonasschnelli @jgarzik @jtimon @dcousens @paveljanik @instagibbs
@laanwj
Owner

laanwj commented Dec 2, 2015

Continues work to remove/push down RPC locks from #7013.
createrawtransaction is a pure utility function that doesn't use main's data structures, so it does not require that lock.

Despite being a one-line change, needs to be reviewed carefully. Although I didn't find any, there may be unguarded use of main data structures deeper in the call chain. Not meant for 0.12
@laanwj
rpc: remove cs_main lock from `createrawtransaction` 
This is a pure utility function that doesn't use
main's data structures, so it does not require that lock.
6e76587

@laanwj laanwj added the RPC/REST/ZMQ label Dec 2, 2015

@jonasschnelli
Member

jonasschnelli commented Dec 2, 2015

Code Review utACK. Can't find any unguarded deeper structure either.
@jgarzik
Contributor

jgarzik commented Dec 2, 2015

ACK
@jtimon
Member

jtimon commented Dec 4, 2015

createrawtransaction() doesn't use any non-local variable and its parameters const UniValue& params, bool fHelp are both cs_main-safe.
I don't need to test this.
ACK
@dcousens
Contributor

dcousens commented Dec 4, 2015

utACK

I couldn't find any unguarded paths.
@paveljanik
Contributor

paveljanik commented Dec 5, 2015

ACK
@instagibbs
Member

instagibbs commented Dec 8, 2015

utACK

@laanwj laanwj merged commit 6e76587 into bitcoin:master Dec 11, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 11, 2015

@laanwj
Merge pull request #7156 
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
9ee02cf

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 28, 2015

@laanwj @luke-jr
rpc: remove cs_main lock from `createrawtransaction` 
This is a pure utility function that doesn't use
main's data structures, so it does not require that lock.

Github-Pull: #7156
Rebased-From: 6e76587
d658fe2

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 28, 2015

@laanwj @luke-jr
rpc: remove cs_main lock from `createrawtransaction` 
This is a pure utility function that doesn't use
main's data structures, so it does not require that lock.

Github-Pull: #7156
Rebased-From: 6e76587
73e32e3

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 9, 2016

@luke-jr
Merge #7156 laanwj/2015_12_createrawtransaction_nolock
d4952b8

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 26, 2016

@luke-jr
Merge #7156 laanwj/2015_12_createrawtransaction_nolock
d527ff1

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

@laanwj @codablock
Merge pull request #7156 
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)
fa749ee

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

@laanwj @codablock
Merge pull request #7156 
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)
14afd71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment