Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
net: Fix sent reject messages for blocks and transactions #7179
To be clear, this solves the following issue:
Normal reject message
Reject message from 0.11.99+
Reason seems empty, and part of the reason message ends up in the "hash". This is due to the reject code being sent as multiple bytes instead of one, misaligning the message.
Edit: trying to think of a test. Hopefully it could fit somewhere in the Python P2P test framework, without creating a new script.
Would it make sense for this object to also check the other parts of the reject message? For instance you noted in this PR that the block hash being returned in the