New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5: Use the fixed font the system recommends #7214

Merged
merged 1 commit into from Dec 23, 2015

Conversation

Projects
None yet
5 participants
@MarcoFalke
Member

MarcoFalke commented Dec 14, 2015

Guess it can't hurt to use the system recommendation in fixedPitchFont(). This may even provide a workaround for #7017.

http://doc.qt.io/qt-5/qfontdatabase.html#systemFont was introduced in Qt 5.2.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Dec 14, 2015

Member

@jonasschnelli Mind to create binaries?

Member

MarcoFalke commented Dec 14, 2015

@jonasschnelli Mind to create binaries?

@jonasschnelli jonasschnelli added the GUI label Dec 15, 2015

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Dec 15, 2015

Member

Great, will try this soon: https://bitcoin.jonasschnelli.ch/pulls/7214/

... Looks like this does not change anything.

Member

MarcoFalke commented Dec 15, 2015

Great, will try this soon: https://bitcoin.jonasschnelli.ch/pulls/7214/

... Looks like this does not change anything.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Dec 15, 2015

Member

@luke-jr @ptschip Is this helpful? Can you change the font via the system?

Member

MarcoFalke commented Dec 15, 2015

@luke-jr @ptschip Is this helpful? Can you change the font via the system?

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Dec 15, 2015

Member

@MarcoFalke I don't have a problem with the current code, and I don't use Qt5...

Member

luke-jr commented Dec 15, 2015

@MarcoFalke I don't have a problem with the current code, and I don't use Qt5...

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Dec 17, 2015

Member

Concept ACK, although I'd expect <pre> already does this

Member

laanwj commented Dec 17, 2015

Concept ACK, although I'd expect <pre> already does this

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Dec 17, 2015

Member

@laanwj Good point... <pre> would likely be Qt4-compatible too. Has anyone tried this?

Member

luke-jr commented Dec 17, 2015

@laanwj Good point... <pre> would likely be Qt4-compatible too. Has anyone tried this?

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Dec 17, 2015

Member

I think I already tried < pre > in #6864

Member

MarcoFalke commented Dec 17, 2015

I think I already tried < pre > in #6864

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Dec 17, 2015

Member

Concept ACK

It looks like this does not fix any bug or change the behavior. We could as well just close this PR, but I don't have a strong opinion here.

Member

MarcoFalke commented Dec 17, 2015

Concept ACK

It looks like this does not fix any bug or change the behavior. We could as well just close this PR, but I don't have a strong opinion here.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Dec 22, 2015

Member

Looks much better on OSX now:

Current Master
bildschirmfoto 2015-12-22 um 14 09 50

This PR:
bildschirmfoto 2015-12-22 um 14 09 06

Will test on Linux/Windows soon.

Member

jonasschnelli commented Dec 22, 2015

Looks much better on OSX now:

Current Master
bildschirmfoto 2015-12-22 um 14 09 50

This PR:
bildschirmfoto 2015-12-22 um 14 09 06

Will test on Linux/Windows soon.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Dec 22, 2015

Member

Will test on Linux/Windows soon.

I think I did this and could not find a difference.

Member

MarcoFalke commented Dec 22, 2015

Will test on Linux/Windows soon.

I think I did this and could not find a difference.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Dec 22, 2015

Member

Tested ACK fa2f4bc
nit (not related to this PR): the font "feels" smaller on windows? Any reason why?

bildschirmfoto 2015-12-22 um 14 12 08

bildschirmfoto 2015-12-22 um 14 13 31

Member

jonasschnelli commented Dec 22, 2015

Tested ACK fa2f4bc
nit (not related to this PR): the font "feels" smaller on windows? Any reason why?

bildschirmfoto 2015-12-22 um 14 12 08

bildschirmfoto 2015-12-22 um 14 13 31

@jonasschnelli jonasschnelli merged commit fa2f4bc into bitcoin:master Dec 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Dec 23, 2015

Merge pull request #7214
fa2f4bc qt5: Use the fixed font the system recommends (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:MarcoFalke-2015-qt5monospace branch Dec 23, 2015

@@ -90,6 +94,9 @@ QString dateTimeStr(qint64 nTime)
QFont fixedPitchFont()

This comment has been minimized.

@parker24j

parker24j Dec 27, 2015

16c999e8c71134401a78d4d46435517b2271d6ac mojombo@16c999e8c71134401a78d4d46435517b2271d6ac mojombo/github-flavored-markdown@16c999e

@parker24j

parker24j Dec 27, 2015

16c999e8c71134401a78d4d46435517b2271d6ac mojombo@16c999e8c71134401a78d4d46435517b2271d6ac mojombo/github-flavored-markdown@16c999e

This comment has been minimized.

@parker24j
@parker24j

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment