Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Eliminate unnecessary call to CheckBlock #7225
This should result in one fewer call to
Concept ACK. If we're going to remove this call can we also drop the
As the comment in
CheckBlock is also called in ConnectBlock() [which is the function that does ALL the consensus checks for a block].
I'm also fine with taking CheckBlockHeader() out of CheckBlock() as @fanquake suggests [as long as it's properly moved out where needed, for example, in ConnectBlock()].
As a side note this would very slightly simplify https://github.com/jtimon/bitcoin/commits/libconsensus-f2 so I consider this "libconsensus encapsulation friendly"(TM) [even if nobody ever asked for that kind of approval from me].