Tests: Add more tests to p2p-fullblocktest #7226
Merged
Conversation
qa/rpc-tests/p2p-fullblocktest.py
Outdated
| from test_framework.script import CScript, CScriptOp, SignatureHash, SIGHASH_ALL, OP_TRUE | ||
| from test_framework.script import CScript, CScriptOp, SignatureHash, SIGHASH_ALL, OP_TRUE, OP_FALSE | ||
|
|
||
| MAX_BLOCK_SIZE = 1000000 |
MarcoFalke
Dec 18, 2015
Member
What about moving this to the framework instead?
What about moving this to the framework instead?
|
@MarcoFalke Moved the global to |
|
ACK |
laanwj
added a commit
that referenced
this pull request
Dec 22, 2015
laanwj
added a commit
that referenced
this pull request
Dec 22, 2015
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Github-Pull: bitcoin#7226 Rebased-From: 9b41a5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@laanwj This is part of a longer-run effort towards being able to deprecate the java comparison tool, without losing test coverage.
I've ported a handful more tests from the java test to
p2p-fullblocktest.py. I intend to continue to port more tests over (unless someone can please beat me to it!) but it'll be at least a few weeks before I return to working on this, so I thought I'd share what I have now.