Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTests: Add more tests to p2p-fullblocktest #7226
+146
−12
Conversation
MarcoFalke
reviewed
Dec 18, 2015
View changes
qa/rpc-tests/p2p-fullblocktest.py
| from test_framework.script import CScript, CScriptOp, SignatureHash, SIGHASH_ALL, OP_TRUE | ||
| from test_framework.script import CScript, CScriptOp, SignatureHash, SIGHASH_ALL, OP_TRUE, OP_FALSE | ||
| MAX_BLOCK_SIZE = 1000000 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
sdaftuar
Dec 18, 2015
Member
@MarcoFalke Moved the global to mininode.py. Also fixed a bug in the next-to-last test that was causing travis to fail (there's a separate PR to fix the issue noted in the TODO, see #7225).
|
@MarcoFalke Moved the global to |
jonasschnelli
added
the
Tests
label
Dec 19, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
ACK |
laanwj
merged commit 9b41a5f
into
bitcoin:master
Dec 22, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
added a commit
that referenced
this pull request
Dec 22, 2015
added a commit
that referenced
this pull request
Dec 22, 2015
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sdaftuar commentedDec 17, 2015
@laanwj This is part of a longer-run effort towards being able to deprecate the java comparison tool, without losing test coverage.
I've ported a handful more tests from the java test to
p2p-fullblocktest.py. I intend to continue to port more tests over (unless someone can please beat me to it!) but it'll be at least a few weeks before I return to working on this, so I thought I'd share what I have now.