Tests: Add more tests to p2p-fullblocktest#7226
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
What about moving this to the framework instead?
sdaftuar
force-pushed
the
add-more-tests
branch
from
83ce22e to
9b41a5f
Compare
Member
Author
|
@MarcoFalke Moved the global to |
Member
|
ACK |
laanwj
added a commit
that referenced
this pull request
Dec 22, 2015
9b41a5f Add more tests to p2p-fullblocktest (Suhas Daftuar)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Github-Pull: bitcoin#7226 Rebased-From: 9b41a5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@laanwj This is part of a longer-run effort towards being able to deprecate the java comparison tool, without losing test coverage.
I've ported a handful more tests from the java test to
p2p-fullblocktest.py. I intend to continue to port more tests over (unless someone can please beat me to it!) but it'll be at least a few weeks before I return to working on this, so I thought I'd share what I have now.