Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add more tests to p2p-fullblocktest #7226

Merged
merged 1 commit into from Dec 22, 2015
Merged

Conversation

@sdaftuar
Copy link
Member

@sdaftuar sdaftuar commented Dec 17, 2015

@laanwj This is part of a longer-run effort towards being able to deprecate the java comparison tool, without losing test coverage.

I've ported a handful more tests from the java test to p2p-fullblocktest.py. I intend to continue to port more tests over (unless someone can please beat me to it!) but it'll be at least a few weeks before I return to working on this, so I thought I'd share what I have now.

@MarcoFalke
MarcoFalke reviewed Dec 18, 2015
View changes
qa/rpc-tests/p2p-fullblocktest.py Outdated
from test_framework.script import CScript, CScriptOp, SignatureHash, SIGHASH_ALL, OP_TRUE
from test_framework.script import CScript, CScriptOp, SignatureHash, SIGHASH_ALL, OP_TRUE, OP_FALSE

MAX_BLOCK_SIZE = 1000000

This comment has been minimized.

@MarcoFalke

MarcoFalke Dec 18, 2015
Member

What about moving this to the framework instead?

@sdaftuar sdaftuar force-pushed the sdaftuar:add-more-tests branch to 9b41a5f Dec 18, 2015
@sdaftuar
Copy link
Member Author

@sdaftuar sdaftuar commented Dec 18, 2015

@MarcoFalke Moved the global to mininode.py. Also fixed a bug in the next-to-last test that was causing travis to fail (there's a separate PR to fix the issue noted in the TODO, see #7225).

@jonasschnelli jonasschnelli added the Tests label Dec 19, 2015
@laanwj
Copy link
Member

@laanwj laanwj commented Dec 22, 2015

ACK

@laanwj laanwj merged commit 9b41a5f into bitcoin:master Dec 22, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Dec 22, 2015
9b41a5f Add more tests to p2p-fullblocktest (Suhas Daftuar)
laanwj added a commit that referenced this pull request Dec 22, 2015
Github-Pull: #7226
Rebased-From: 9b41a5f
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants